From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5944 invoked by alias); 25 May 2005 05:37:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5859 invoked by uid 22791); 25 May 2005 05:37:25 -0000 Received: from ausmtp01.au.ibm.com (HELO ausmtp01.au.ibm.com) (202.81.18.186) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 25 May 2005 05:37:25 +0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp01.au.ibm.com (8.12.10/8.12.10) with ESMTP id j4P5dRa7326954 for ; Wed, 25 May 2005 15:39:29 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0208e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4P5dma8132754 for ; Wed, 25 May 2005 15:39:48 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11/8.13.3) with ESMTP id j4P5atXe023402 for ; Wed, 25 May 2005 15:36:55 +1000 Received: from plinuxt18.cn.ibm.com (plinuxt18.cn.ibm.com [9.181.140.28]) by d23av02.au.ibm.com (8.12.11/8.12.11) with ESMTP id j4P5arqW023272; Wed, 25 May 2005 15:36:54 +1000 Date: Wed, 25 May 2005 06:48:00 -0000 From: Wu Zhou To: Daniel Jacobowitz cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Is this kind of patch welcomed? In-Reply-To: <20050524130425.GA1543@nevyn.them.org> Message-ID: References: <20050524130425.GA1543@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-05/txt/msg00540.txt.bz2 OK. Followed is the revised patch: another typo is fixed and changlog entry added. 2005-05-25 Wu Zhou * remote.c: Fix two comment typos Index: remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.190 diff -c -p -r1.190 remote.c *** remote.c 16 May 2005 16:36:24 -0000 1.190 --- remote.c 25 May 2005 02:11:20 -0000 *************** struct gdb_ext_thread_info *** 1114,1120 **** int active; /* Has state interesting to GDB? regs, stack. */ char display[256]; /* Brief state display, name, ! blocked/syspended. */ char shortname[32]; /* To be used to name threads. */ char more_display[256]; /* Long info, statistics, queue depth, whatever. */ --- 1114,1120 ---- int active; /* Has state interesting to GDB? regs, stack. */ char display[256]; /* Brief state display, name, ! blocked/suspended. */ char shortname[32]; /* To be used to name threads. */ char more_display[256]; /* Long info, statistics, queue depth, whatever. */ *************** remote_unpack_thread_info_response (char *** 1489,1495 **** int mask, length; unsigned int tag; threadref ref; ! char *limit = pkt + (rs->remote_packet_size); /* plausable parsing limit */ int retval = 1; /* info->threadid = 0; FIXME: implement zero_threadref. */ --- 1489,1495 ---- int mask, length; unsigned int tag; threadref ref; ! char *limit = pkt + (rs->remote_packet_size); /* plausible parsing limit */ int retval = 1; /* info->threadid = 0; FIXME: implement zero_threadref. */ On Tue, 24 May 2005, Daniel Jacobowitz wrote: > On Tue, May 24, 2005 at 05:13:32AM -0700, Wu Zhou wrote: > > This is to fix a typo in remote.c, found while I am reading the > > source code. Is this kind of patch welcomed? If it is, should > > I add a changelog entry as well? If not, please ignore it. > > > > Thanks. > > The patch is fine - but yes, it does need a changelog entry. > > -- > Daniel Jacobowitz > CodeSourcery, LLC > >