From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1707 invoked by alias); 18 Apr 2007 08:24:07 -0000 Received: (qmail 1691 invoked by uid 22791); 18 Apr 2007 08:24:06 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 09:23:59 +0100 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1He5SF-0003GO-00; Wed, 18 Apr 2007 09:23:55 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1He5S1-000461-00; Wed, 18 Apr 2007 09:23:41 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1He5S1-0007lb-TO; Wed, 18 Apr 2007 09:23:41 +0100 Date: Wed, 18 Apr 2007 08:31:00 -0000 From: "Maciej W. Rozycki" To: Daniel Jacobowitz cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Style fixes In-Reply-To: <20070417191838.GA13068@caradoc.them.org> Message-ID: References: <20070417180313.GA9378@caradoc.them.org> <20070417191838.GA13068@caradoc.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00275.txt.bz2 On Tue, 17 Apr 2007, Daniel Jacobowitz wrote: > > I can revert these, no problem > > Please do. Done now: 2007-04-18 Maciej W. Rozycki * mips-tdep.c (mips_eabi_push_dummy_call): Revert the last change to rearrange some brackets. (mips_n32n64_push_dummy_call): Likewise. (mips_o32_push_dummy_call): Likewise. (mips_o64_push_dummy_call): Likewise. > > -- it just looks strange and is not useful > > from the language's point of view to have the right-hand side of an > > assignment in brackets. OTOH, this qualifies as a workaround for what > > should probably be considered a bug in the respective tools, so perhaps > > those should be fixed instead? > > Maybe, but I'm not about to suggest changes to GNU formatting at this > date :-) OK -- the question is whether this is a bug in software not doing the GNU formatting correctly or whether it is our code that diverges. Maciej Index: gdb/mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.413 diff -u -p -r1.413 mips-tdep.c --- gdb/mips-tdep.c 17 Apr 2007 17:57:03 -0000 1.413 +++ gdb/mips-tdep.c 18 Apr 2007 08:17:05 -0000 @@ -2558,8 +2558,8 @@ mips_eabi_push_dummy_call (struct gdbarc { /* Remember if the argument was written to the stack. */ int stack_used_p = 0; - int partial_len = (len < mips_abi_regsize (gdbarch)) - ? len : mips_abi_regsize (gdbarch); + int partial_len = (len < mips_abi_regsize (gdbarch) + ? len : mips_abi_regsize (gdbarch)); if (mips_debug) fprintf_unfiltered (gdb_stdlog, " -- partial=%d", @@ -2785,8 +2785,8 @@ mips_n32n64_push_dummy_call (struct gdba { /* Remember if the argument was written to the stack. */ int stack_used_p = 0; - int partial_len = (len < mips_abi_regsize (gdbarch)) - ? len : mips_abi_regsize (gdbarch); + int partial_len = (len < mips_abi_regsize (gdbarch) + ? len : mips_abi_regsize (gdbarch)); if (mips_debug) fprintf_unfiltered (gdb_stdlog, " -- partial=%d", @@ -2873,8 +2873,8 @@ mips_n32n64_push_dummy_call (struct gdba && partial_len < mips_abi_regsize (gdbarch) && (typecode == TYPE_CODE_STRUCT || typecode == TYPE_CODE_UNION)) - regval <<= (mips_abi_regsize (gdbarch) - partial_len) - * TARGET_CHAR_BIT; + regval <<= ((mips_abi_regsize (gdbarch) - partial_len) + * TARGET_CHAR_BIT); if (mips_debug) fprintf_filtered (gdb_stdlog, " - reg=%d val=%s", @@ -3219,8 +3219,8 @@ mips_o32_push_dummy_call (struct gdbarch { /* Remember if the argument was written to the stack. */ int stack_used_p = 0; - int partial_len = (len < mips_abi_regsize (gdbarch)) - ? len : mips_abi_regsize (gdbarch); + int partial_len = (len < mips_abi_regsize (gdbarch) + ? len : mips_abi_regsize (gdbarch)); if (mips_debug) fprintf_unfiltered (gdb_stdlog, " -- partial=%d", @@ -3308,8 +3308,8 @@ mips_o32_push_dummy_call (struct gdbarch && partial_len < mips_abi_regsize (gdbarch) && (typecode == TYPE_CODE_STRUCT || typecode == TYPE_CODE_UNION)) - regval <<= (mips_abi_regsize (gdbarch) - partial_len) - * TARGET_CHAR_BIT; + regval <<= ((mips_abi_regsize (gdbarch) - partial_len) + * TARGET_CHAR_BIT); if (mips_debug) fprintf_filtered (gdb_stdlog, " - reg=%d val=%s", @@ -3680,8 +3680,8 @@ mips_o64_push_dummy_call (struct gdbarch { /* Remember if the argument was written to the stack. */ int stack_used_p = 0; - int partial_len = (len < mips_abi_regsize (gdbarch)) - ? len : mips_abi_regsize (gdbarch); + int partial_len = (len < mips_abi_regsize (gdbarch) + ? len : mips_abi_regsize (gdbarch)); if (mips_debug) fprintf_unfiltered (gdb_stdlog, " -- partial=%d", @@ -3752,8 +3752,8 @@ mips_o64_push_dummy_call (struct gdbarch && partial_len < mips_abi_regsize (gdbarch) && (typecode == TYPE_CODE_STRUCT || typecode == TYPE_CODE_UNION)) - regval <<= (mips_abi_regsize (gdbarch) - partial_len) - * TARGET_CHAR_BIT; + regval <<= ((mips_abi_regsize (gdbarch) - partial_len) + * TARGET_CHAR_BIT); if (mips_debug) fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",