Re: mips-tdep.c: Style fixes

Maciej W. Rozycki
2007-04-18T08:24:07Z

On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:

> > I can revert these, no problem
>
> Please do.

Done now:

2007-04-18 Maciej W. Rozycki <macro@mips.com>

* mips-tdep.c (mips_eabi_push_dummy_call): Revert the last
change to rearrange some brackets.
(mips_n32n64_push_dummy_call): Likewise.
(mips_o32_push_dummy_call): Likewise.
(mips_o64_push_dummy_call): Likewise.

> > -- it just looks strange and is not useful
> > from the language's point of view to have the right-hand side of an
> > assignment in brackets. OTOH, this qualifies as a workaround for what
> > should probably be considered a bug in the respective tools, so perhaps
> > those should be fixed instead?
>
> Maybe, but I'm not about to suggest changes to GNU formatting at this
> date :-)

OK -- the question is whether this is a bug in software not doing the GNU
formatting correctly or whether it is our code that diverges.

Maciej

Index: gdb/mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.413
diff -u -p -r1.413 mips-tdep.c
--- gdb/mips-tdep.c 17 Apr 2007 17:57:03 -0000 1.413
+++ gdb/mips-tdep.c 18 Apr 2007 08:17:05 -0000
@@ -2558,8 +2558,8 @@ mips_eabi_push_dummy_call (struct gdbarc
{
/* Remember if the argument was written to the stack. */
int stack_used_p = 0;
- int partial_len = (len < mips_abi_regsize (gdbarch))
- ? len : mips_abi_regsize (gdbarch);
+ int partial_len = (len < mips_abi_regsize (gdbarch)
+ ? len : mips_abi_regsize (gdbarch));

if (mips_debug)
fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -2785,8 +2785,8 @@ mips_n32n64_push_dummy_call (struct gdba
{
/* Remember if the argument was written to the stack. */
int stack_used_p = 0;
- int partial_len = (len < mips_abi_regsize (gdbarch))
- ? len : mips_abi_regsize (gdbarch);
+ int partial_len = (len < mips_abi_regsize (gdbarch)
+ ? len : mips_abi_regsize (gdbarch));

if (mips_debug)
fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -2873,8 +2873,8 @@ mips_n32n64_push_dummy_call (struct gdba
&& partial_len < mips_abi_regsize (gdbarch)
&& (typecode == TYPE_CODE_STRUCT
|| typecode == TYPE_CODE_UNION))
- regval <<= (mips_abi_regsize (gdbarch) - partial_len)
- * TARGET_CHAR_BIT;
+ regval <<= ((mips_abi_regsize (gdbarch) - partial_len)
+ * TARGET_CHAR_BIT);

if (mips_debug)
fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",
@@ -3219,8 +3219,8 @@ mips_o32_push_dummy_call (struct gdbarch
{
/* Remember if the argument was written to the stack. */
int stack_used_p = 0;
- int partial_len = (len < mips_abi_regsize (gdbarch))
- ? len : mips_abi_regsize (gdbarch);
+ int partial_len = (len < mips_abi_regsize (gdbarch)
+ ? len : mips_abi_regsize (gdbarch));

if (mips_debug)
fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -3308,8 +3308,8 @@ mips_o32_push_dummy_call (struct gdbarch
&& partial_len < mips_abi_regsize (gdbarch)
&& (typecode == TYPE_CODE_STRUCT
|| typecode == TYPE_CODE_UNION))
- regval <<= (mips_abi_regsize (gdbarch) - partial_len)
- * TARGET_CHAR_BIT;
+ regval <<= ((mips_abi_regsize (gdbarch) - partial_len)
+ * TARGET_CHAR_BIT);

if (mips_debug)
fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",
@@ -3680,8 +3680,8 @@ mips_o64_push_dummy_call (struct gdbarch
{
/* Remember if the argument was written to the stack. */
int stack_used_p = 0;
- int partial_len = (len < mips_abi_regsize (gdbarch))
- ? len : mips_abi_regsize (gdbarch);
+ int partial_len = (len < mips_abi_regsize (gdbarch)
+ ? len : mips_abi_regsize (gdbarch));

if (mips_debug)
fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -3752,8 +3752,8 @@ mips_o64_push_dummy_call (struct gdbarch
&& partial_len < mips_abi_regsize (gdbarch)
&& (typecode == TYPE_CODE_STRUCT
|| typecode == TYPE_CODE_UNION))
- regval <<= (mips_abi_regsize (gdbarch) - partial_len)
- * TARGET_CHAR_BIT;
+ regval <<= ((mips_abi_regsize (gdbarch) - partial_len)
+ * TARGET_CHAR_BIT);

if (mips_debug)
fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",