Re: mips-tdep.c: Style fixes

Michael Snyder
2007-04-17T20:39:31Z

On Tue, 2007-04-17 at 19:12 +0100, Maciej W. Rozycki wrote:
> On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:
>
> > > - int partial_len = (len < mips_abi_regsize (gdbarch)
> > > - ? len : mips_abi_regsize (gdbarch));
> > > + int partial_len = (len < mips_abi_regsize (gdbarch))
> > > + ? len : mips_abi_regsize (gdbarch);
> >
> > These (and most of the others) were actually there for a reason.
> > Emacs will move that second line leftwards if there isn't an outer
> > layer of parentheses; I believe GNU Indent and gdb_indent.sh will also.
>
> I can revert these, no problem -- it just looks strange and is not useful
> from the language's point of view to have the right-hand side of an
> assignment in brackets.

Both statements contain redundant parens.

> OTOH, this qualifies as a workaround for what should probably be considered
> a bug in the respective tools, so perhaps those should be fixed instead?

Probably, but we don't maintain those - we maintain gdb.