Re: mips-tdep.c: Style fixes

Andreas Schwab
2007-04-17T18:57:36Z

"Maciej W. Rozycki" <macro@mips.com> writes:

> On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:
>
>> > - int partial_len = (len < mips_abi_regsize (gdbarch)
>> > - ? len : mips_abi_regsize (gdbarch));
>> > + int partial_len = (len < mips_abi_regsize (gdbarch))
>> > + ? len : mips_abi_regsize (gdbarch);
>>
>> These (and most of the others) were actually there for a reason.
>> Emacs will move that second line leftwards if there isn't an outer
>> layer of parentheses; I believe GNU Indent and gdb_indent.sh will also.
>
> I can revert these, no problem -- it just looks strange and is not useful
> from the language's point of view to have the right-hand side of an
> assignment in brackets.

There are still redundant parens, and those are even less useful.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃŸe 5, 90409 NÃ¼rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."