From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13906 invoked by alias); 17 Apr 2007 18:13:05 -0000 Received: (qmail 13896 invoked by uid 22791); 17 Apr 2007 18:13:04 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Apr 2007 19:12:58 +0100 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1HdsAg-00084x-00; Tue, 17 Apr 2007 19:12:54 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1HdsAH-0006Om-00; Tue, 17 Apr 2007 19:12:29 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1HdsAH-0008Kk-FO; Tue, 17 Apr 2007 19:12:29 +0100 Date: Tue, 17 Apr 2007 18:57:00 -0000 From: "Maciej W. Rozycki" To: Daniel Jacobowitz cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Style fixes In-Reply-To: <20070417180313.GA9378@caradoc.them.org> Message-ID: References: <20070417180313.GA9378@caradoc.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00266.txt.bz2 On Tue, 17 Apr 2007, Daniel Jacobowitz wrote: > > - int partial_len = (len < mips_abi_regsize (gdbarch) > > - ? len : mips_abi_regsize (gdbarch)); > > + int partial_len = (len < mips_abi_regsize (gdbarch)) > > + ? len : mips_abi_regsize (gdbarch); > > These (and most of the others) were actually there for a reason. > Emacs will move that second line leftwards if there isn't an outer > layer of parentheses; I believe GNU Indent and gdb_indent.sh will also. I can revert these, no problem -- it just looks strange and is not useful from the language's point of view to have the right-hand side of an assignment in brackets. OTOH, this qualifies as a workaround for what should probably be considered a bug in the respective tools, so perhaps those should be fixed instead? Maciej