From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6572 invoked by alias); 6 Jun 2005 22:26:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6057 invoked by uid 22791); 6 Jun 2005 22:26:44 -0000 Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.132) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 06 Jun 2005 22:26:44 +0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e34.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j56MQg8E216336 for ; Mon, 6 Jun 2005 18:26:42 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j56MQgXR209158 for ; Mon, 6 Jun 2005 16:26:42 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j56MQg6t008932 for ; Mon, 6 Jun 2005 16:26:42 -0600 Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j56MQgAp008927 for ; Mon, 6 Jun 2005 16:26:42 -0600 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j56MQfeQ130544 for ; Mon, 6 Jun 2005 17:26:41 -0500 Date: Mon, 06 Jun 2005 22:26:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: gdb-patches@sources.redhat.com Subject: Re: [RFC] GDBserver compiler warnings patch In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-06/txt/msg00049.txt.bz2 Any comments on this patch? ok to commit? Thanks ----- manjo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Cogito ergo sum + +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ On Wed, 1 Jun 2005, Manoj Iyer wrote: > > 2005-06-01 Manoj Iyer > > * gdbreplay.c: Added #include . > (remote_open): Change type of 'tmp' from int to socklen_t. > * remote-utils.c: Added #include . > (remote_open): Change type of 'tmp' from int to socklen_t. > * server.c: Change type of 'sig' from unsigned char to char. > > > -------------------------------------------------------------------- > diff -Naurp old/src/gdb/gdbserver/gdbreplay.c new/src/gdb/gdbserver/gdbreplay.c > --- old/src/gdb/gdbserver/gdbreplay.c 2004-03-12 12:51:21.000000000 -0800 > +++ new/src/gdb/gdbserver/gdbreplay.c 2005-06-01 11:24:52.792975800 -0700 > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -105,7 +106,7 @@ remote_open (char *name) > char *port_str; > int port; > struct sockaddr_in sockaddr; > - int tmp; > + socklen_t tmp; > int tmp_desc; > > port_str = strchr (name, ':'); > diff -Naurp old/src/gdb/gdbserver/remote-utils.c new/src/gdb/gdbserver/remote-utils.c > --- old/src/gdb/gdbserver/remote-utils.c 2005-05-12 05:14:23.000000000 -0700 > +++ new/src/gdb/gdbserver/remote-utils.c 2005-06-01 11:17:39.946018968 -0700 > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -122,7 +123,7 @@ remote_open (char *name) > char *port_str; > int port; > struct sockaddr_in sockaddr; > - int tmp; > + socklen_t tmp; > int tmp_desc; > > port_str = strchr (name, ':'); > diff -Naurp old/src/gdb/gdbserver/server.c new/src/gdb/gdbserver/server.c > --- old/src/gdb/gdbserver/server.c 2005-05-12 05:14:23.000000000 -0700 > +++ new/src/gdb/gdbserver/server.c 2005-06-01 11:21:52.040032192 -0700 > @@ -379,7 +379,7 @@ main (int argc, char *argv[]) > setjmp (toplevel); > while (getpkt (own_buf) > 0) > { > - unsigned char sig; > + char sig; > i = 0; > ch = own_buf[i++]; > switch (ch) > > ----- > manjo > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > + Cogito ergo sum + > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >