From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27925 invoked by alias); 18 May 2005 04:44:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27814 invoked from network); 18 May 2005 04:44:18 -0000 Received: from unknown (HELO e32.co.us.ibm.com) (32.97.110.130) by sourceware.org with SMTP; 18 May 2005 04:44:18 -0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j4I4iH0c027982 for ; Wed, 18 May 2005 00:44:17 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4I4iHLN259606 for ; Tue, 17 May 2005 22:44:17 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j4I4iHB3020883 for ; Tue, 17 May 2005 22:44:17 -0600 Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j4I4iGtm020867 for ; Tue, 17 May 2005 22:44:17 -0600 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j4I4iFdr044160 for ; Tue, 17 May 2005 23:44:16 -0500 Date: Wed, 18 May 2005 09:52:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: gdb-patches@sources.redhat.com Subject: Re: [RFC] gdb.server testcases (resend) In-Reply-To: <20050518012521.GB8672@nevyn.them.org> Message-ID: References: <20050518012521.GB8672@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-05/txt/msg00446.txt.bz2 Daniel, I misunderstood the use of gdb.server directory. I thought that this directory is for testing gdbserver remote debugging functionality. I am trying to get gdbserver working on ppc. As a starting point I used these tests. But you are correct. In this perspective my testcases seem useless. To begin with gdbserver program fails outright on ppc64 PPC970 Altivec hardware: ./gdbserver uranus.ltc.austin.ibm.com:1234 /tmp/server Process /tmp/server created; pid = 30836 reading register 1: Input/output error Exiting I am trying to chase down the problem and get gdbserver working. If you have any insight into this problem please advice. Thanks ----- manjo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Cogito ergo sum + +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ On Tue, 17 May 2005, Daniel Jacobowitz wrote: > On Mon, May 16, 2005 at 12:13:17PM -0500, Manoj Iyer wrote: > > > > In my previous email I missed the changelog. Here is my complete patch. > > Please review and comment. > > > > 2005-05-16 Manoj Iyer > > > > * gdb.server/server-run.exp: added testcases. > > * gdb.server/server.c: added nested function call to test > > backtrace. > > That's not a changelog; it does not describe what has changed. Please > follow the conventions for C code when changing C files in the > testsuite; each function needs its own entry, for instance. > > You've changed the indentation in server.c, away from the GNU style. > It's not as important to maintain GNU Coding Standards in the > testsuite, but please don't ignore it without a reason. > > > +# test setting a breakpoint > > Comments are full sentences, start with capital letters, and end with > periods. > > > gdb_breakpoint main > > -gdb_test "continue" "Breakpoint.* main .*" "continue to main" > > + > > +gdb_test "continue" ".*Continuing\\..*Breakpoint \[0-9\], main.*at .*$srcfile:\[0-9\]+.*" > > + > > +# test if list command displays source code > > +gdb_test "list" ".*main.*\{.*\}" > > + > > +# set breakpoint at a function and test backtrace command > > +gdb_test "break function3" "Breakpoint 2 at.*file .*$srcfile, line \[0-9\]+." > > + > > +gdb_test "continue" ".*Continuing\\..*Breakpoint \[0-9\]+, function3.*at.*$srcfile:\[0-9\]+.*" > > You'll need to give names to tests; otherwise this test is going to > report "PASS: gdb.server/server-run.exp: continue" multiple times. > > Manoj, before you revise the patch again, could you explain why you > want to add these tests? It is possible to run the entire testsuite > using gdbserver if you want to specifically validate gdbserver; the > purpose of the gdb.server directory is: > > 1. To make sure that minimal remote protocol support is not > accidentally broken by people working on native debuggers. > > 2. (Someday) to test gdbserver-specific features, like gdbserver > --attach. > > Do these tests add value to #1? We're already testing that we can > reach main; on a native configuration that tests breakpoints, > continuing, and single-stepping (for the dynamic linker breakpoints). > > -- > Daniel Jacobowitz > CodeSourcery, LLC >