From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24500 invoked by alias); 19 Apr 2005 14:56:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24398 invoked from network); 19 Apr 2005 14:55:42 -0000 Received: from unknown (HELO e34.co.us.ibm.com) (32.97.110.132) by sourceware.org with SMTP; 19 Apr 2005 14:55:42 -0000 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e34.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j3JEtceE167434 for ; Tue, 19 Apr 2005 10:55:39 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay05.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j3JEta7M234544 for ; Tue, 19 Apr 2005 08:55:36 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j3JEtYHM021921 for ; Tue, 19 Apr 2005 08:55:35 -0600 Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j3JEtX1B021826; Tue, 19 Apr 2005 08:55:33 -0600 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j3JEtWeT042320; Tue, 19 Apr 2005 09:55:32 -0500 Date: Tue, 19 Apr 2005 14:56:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: Daniel Jacobowitz cc: "M.M. Kettenis" , gdb-patches@sources.redhat.com Subject: Re: [RFC] Use HAVE_LONGLONG instead of __GNUC__ to check for long long support. In-Reply-To: <20050419123249.GA22692@nevyn.them.org> Message-ID: References: <7320552869539569@webhare> <20050419123249.GA22692@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-04/txt/msg00220.txt.bz2 I resubmitted the patch with AC_CHECK_TYPES. The manual says that "Autoconf, up to 2.13, used to provide to another version of AC_CHECK_TYPE, broken by design." (http://www.delorie.com/gnu/docs/autoconf/autoconf_60.html) Is this what you are refering to? Please review my updated patch and ok for commmit. ----- manjo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Cogito ergo sum + +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ On Tue, 19 Apr 2005, Daniel Jacobowitz wrote: > On Tue, Apr 19, 2005 at 07:58:15AM +0000, M.M. Kettenis wrote: > > Manoj Iyer wrote: > > > > > > > >Daniel, > > > > > >Used autoheader to generate the config.in file, but it does not look > > >pretty, also, removed the comments that you did not like. > > > > > >2005-04-18 Manoj Iyer > > > * configure.ac: Added check for long long. > > > * config.in: Regenerated. > > > * configure: Regenerated. > > > * words.h: Modified logic to check for HAVE_LONGLONG instead of > > > __GNUC__, added config.h header file. > > > > Please use AC_CHECK_TYPES, it should take care of defining > > HAVE_LONG_LONG (note the extra underscore) and the comment all by > > itself. > > Wasn't there some problem with AC_CHECK_TYPES? I remember there used > to be a comment in gdb/configure.in saying to use it, but it was > removed and the manual check is still there. > > -- > Daniel Jacobowitz > CodeSourcery, LLC >