From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28396 invoked by alias); 29 Mar 2005 23:43:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28356 invoked from network); 29 Mar 2005 23:43:53 -0000 Received: from unknown (HELO e35.co.us.ibm.com) (32.97.110.133) by sourceware.org with SMTP; 29 Mar 2005 23:43:53 -0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e35.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j2TNhqLg371658 for ; Tue, 29 Mar 2005 18:43:52 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j2TNhqIg242206 for ; Tue, 29 Mar 2005 16:43:52 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j2TNhqfY025551 for ; Tue, 29 Mar 2005 16:43:52 -0700 Received: from austin.ibm.com (netmail2.austin.ibm.com [9.41.248.176]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j2TNhp10025539 for ; Tue, 29 Mar 2005 16:43:51 -0700 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id j2TNhpOV154966 for ; Tue, 29 Mar 2005 17:43:51 -0600 Date: Tue, 29 Mar 2005 23:43:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: gdb-patches@sources.redhat.com Subject: [RFC]sim/common/sim-types.h multiple defines defines? Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-03/txt/msg00385.txt.bz2 I notice in src/sim/common/sim-types.h there are multiple defines of unsigned32 and unsigned64. I think it was intended to be signed32 and signed64. Or am I wrong? Also, why does not gcc generate an error message/warning for this? The XLC compiler on AIX reports this as an error. Here is a patch that shows what I think should be the right definitions... --- ./sim-types.h 2005-03-29 17:18:40.000000000 -0600 +++ ./new/sim-types.h 2005-03-29 17:19:13.000000000 -0600 @@ -112,11 +112,11 @@ typedef struct { signed64 a[2]; } signed typedef signed char signed8; typedef signed short signed16; #if defined (__ALPHA__) -typedef signed int unsigned32; -typedef signed long unsigned64; +typedef signed int signed32; +typedef signed long signed64; #else -typedef signed long unsigned32; -typedef signed long long unsigned64; +typedef signed long signed32; +typedef signed long long signed64; #endif typedef unsigned char unsigned8; ----- manjo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Cogito ergo sum + +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++