From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22273 invoked by alias); 27 Aug 2004 18:51:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22259 invoked from network); 27 Aug 2004 18:51:17 -0000 Received: from unknown (HELO e33.co.us.ibm.com) (32.97.110.131) by sourceware.org with SMTP; 27 Aug 2004 18:51:17 -0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id i7RIp0DD084866; Fri, 27 Aug 2004 14:51:00 -0400 Received: from austin.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id i7RIoxrK368984; Fri, 27 Aug 2004 12:50:59 -0600 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id i7RIowRn030976; Fri, 27 Aug 2004 13:50:58 -0500 Date: Fri, 27 Aug 2004 18:51:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: gdb-patches@sources.redhat.com, Michael Snyder Subject: Re: New thread testcase (resubmit) In-Reply-To: <412F7572.2070704@redhat.com> Message-ID: References: <412F7572.2070704@redhat.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-352137877-1093630602=:19165" X-SW-Source: 2004-08/txt/msg00756.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --8323328-352137877-1093630602=:19165 Content-Type: TEXT/PLAIN; charset=US-ASCII Content-length: 2088 Michael, Incorporated your comments. Thanks ----- manjo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + Cognito ergo sum + +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ On Fri, 27 Aug 2004, Michael Snyder wrote: > Manoj Iyer wrote: > > I have attached two modified versions of my new thread testcase. > > > > - version 1 > > incorporates Michael Chastain's suggestions and it includes > > the step and backtrace tests from the thread fucntion. > > > > -version 2 > > incorporates Michael Snyder suggestion to remove the step and backtrace > > tests from the testcase. > > > > Please let me know which one you like and any other comments or changes. > > ChangeLog is pasted at the begning of the patch. > > Version 2 is OK as is, if you're tired of messing with it. > You didn't have to remove the backtrace, though, if you'd > like to keep that. > > Also, > > > +# > > +# > > +# continue to tf() breakpoint #2 > > +# > > +gdb_test_multiple "continue\n" "continue to thread fucntion breakpoint #2" { > > + -re ".*Breakpoint 2.*tf.* at .*tbug.* .*\r\n.*$gdb_prompt $" { > > + pass "continue to tf"; > > + } > > + -re ".*$gdb_prompt $" { > > + fail "continue to tf"; > > + return 1; > > + } > > +} > > I think this could be simplified to: > gdb_test "continue" \ > "Breakpoint 2.*tf.* at .*tbug.*" \ > "continue to tf" > > Similarly, your backtrace test could be as simple as: > gdb_test "backtrace" \ > "#0 .*tf .*at .*tbug.*" \ > "backtrace from thread function" > > I don't think you can predict what will be on any > higher frames, but you could test the current frame > and make sure backtrace didn't just die or show you > the wrong thread. > > > > + > > + > > +# > > +# delete all breakpoints > > +# > > +send_gdb "delete\n" > > +gdb_expect { > > + -re "Delete all breakpoint.*$gdb_prompt $" { > > + send_gdb "y\n" > > For this, all you need is the existing procedure call: > > delete_breakpoints > > > > --8323328-352137877-1093630602=:19165 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="gdb.newtest.version3.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: GDB thread testcase Content-Disposition: attachment; filename="gdb.newtest.version3.patch" Content-length: 7475 MjAwNC0wOC0yNyAgTWFub2ogSXllciAgPG1hbmpvQGF1c3Rpbi5pYm0uY29t Pg0KDQogICAgICAgICogZ2RiLnRocmVhZHMvdGhyZWFkX2NoZWNrLmV4cDog TmV3IHRlc3RjYXNlLg0KICAgICAgICAqIGdkYi50aHJlYWRzL3RocmVhZF9j aGVjay5jOiBOZXcgdGVzdGNhc2UuDQoNCi0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQ0KZGlmZiAtcGF1ck4gLi9vbGQvc3JjL2dkYi90ZXN0 c3VpdGUvZ2RiLnRocmVhZHMvdGhyZWFkX2NoZWNrLmMgLi9uZXcvc3JjL2dk Yi90ZXN0c3VpdGUvZ2RiLnRocmVhZHMvdGhyZWFkX2NoZWNrLmMNCi0tLSAu L29sZC9zcmMvZ2RiL3Rlc3RzdWl0ZS9nZGIudGhyZWFkcy90aHJlYWRfY2hl Y2suYwkxOTY5LTEyLTMxIDE4OjAwOjAwLjAwMDAwMDAwMCAtMDYwMA0KKysr IC4vbmV3L3NyYy9nZGIvdGVzdHN1aXRlL2dkYi50aHJlYWRzL3RocmVhZF9j aGVjay5jCTIwMDQtMDgtMjcgMDU6MzI6MTguNDM0MjgxODk2IC0wNTAwDQpA QCAtMCwwICsxLDc1IEBADQorLyoNCisqIENvcHlyaWdodCAoQykgMjAwNCBG cmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4NCisNCisqIFRoaXMgcHJv Z3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IgbW9kaWZ5DQorKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0K KyogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNp b24gMiBvZiB0aGUgTGljZW5zZSwgb3INCisqIChhdCB5b3VyIG9wdGlvbikg YW55IGxhdGVyIHZlcnNpb24uDQorKg0KKyogVGhpcyBwcm9ncmFtIGlzIGRp c3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWws DQorKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0 aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KKyogTUVSQ0hBTlRBQklMSVRZIG9y IEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0K KyogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWls cy4NCisqDQorKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9m IHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQ0KKyogYWxvbmcgd2l0 aCB0aGlzIHByb2dyYW07IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29m dHdhcmUNCisqIEZvdW5kYXRpb24sIEluYy4sIDU5IFRlbXBsZSBQbGFjZSAt IFN1aXRlIDMzMCwgQm9zdG9uLCBNQSAwMjExMS0xMzA3LCBVU0EuDQorDQor KiBUaGlzIGZpbGUgd2FzIHdyaXR0ZW4gYnkgU3RldmUgTXVucm9lLiAoc2pt dW5yb2VAdXMuaWJtLmNvbSkNCisqIFRlc3QgYnJlYWsgcG9pbnRzIGFuZCBz aW5nbGUgc3RlcCBvbiB0aHJlYWQgZnVuY3Rpb25zLg0KKyovDQorDQorI2lu Y2x1ZGUgPHN0cmluZy5oPg0KKyNpbmNsdWRlIDx1bmlzdGQuaD4NCisjaW5j bHVkZSA8cHRocmVhZC5oPg0KKyNpbmNsdWRlIDxzdGRsaWIuaD4NCisjaW5j bHVkZSA8c3RkaW8uaD4NCisjaW5jbHVkZSA8ZXJybm8uaD4NCisNCisjZGVm aW5lIE4gICAgICAgMg0KKw0KK3N0YXRpYyB2b2lkICoNCit0ZiAodm9pZCAq YXJnKQ0KK3sNCisgICAgaW50IG4gPSAoaW50KSAobG9uZyBpbnQpIGFyZzsN CisgICAgY2hhciBudW1iZXJbMTYwXTsNCisgICAgaW50IHVuc2xlcHQgPSAx MDsNCisNCisgICAgc3ByaW50ZihudW1iZXIsICJ0ZiglbGQpOiBiZWdpbiIs IChsb25nKWFyZyk7DQorICAgIHB1dHMgKG51bWJlcik7DQorDQorICAgIHdo aWxlICh1bnNsZXB0ID4gMCkNCisgICAgICAgIHVuc2xlcHQgPSBzbGVlcCh1 bnNsZXB0KTsNCisNCisgICAgc3ByaW50ZihudW1iZXIsICJ0ZiglbGQpOiBl bmQiLCAobG9uZylhcmcpOw0KKyAgICBwdXRzIChudW1iZXIpOw0KKyAgICBy ZXR1cm4gTlVMTDsNCit9DQorDQoraW50IG1haW4gKGludCBhcmdjLCBjaGFy ICphcmd2W10pDQorew0KKyAgICBpbnQgbjsNCisgICAgaW50IHVuc2xlcHQg PSAyOw0KKyAgICBwdGhyZWFkX3QgdGhbTl07DQorDQorICAgIGZvciAobiA9 IDA7IG4gPCBOOyArK24pDQorICAgIGlmIChwdGhyZWFkX2NyZWF0ZSAoJnRo W25dLCBOVUxMLCB0ZiwgKHZvaWQgKikgKGxvbmcgaW50KSBuKSAhPSAwKQ0K KyAgICB7DQorICAgICAgICB3aGlsZSAodW5zbGVwdCA+IDApDQorICAgICAg ICAgICB1bnNsZXB0ID0gc2xlZXAoMik7DQorICAgICAgICBwdXRzICgiY3Jl YXRlIGZhaWxlZCIpOw0KKyAgICAgICAgZXhpdCAoMSk7DQorICAgIH0NCisN CisgICAgcHV0cygiYWZ0ZXIgY3JlYXRlIik7DQorDQorICAgIGZvciAobiA9 IDA7IG4gPCBOOyArK24pDQorICAgIGlmIChwdGhyZWFkX2pvaW4gKHRoW25d LCBOVUxMKSAhPSAwKQ0KKyAgICB7DQorICAgICAgICBwdXRzICgiam9pbiBm YWlsZWQiKTsNCisgICAgICAgIGV4aXQgKDEpOw0KKyAgICB9DQorDQorICAg IHB1dHMoImFmdGVyIGpvaW4iKTsNCisgICAgcmV0dXJuIDA7DQorfQ0KZGlm ZiAtcGF1ck4gLi9vbGQvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLnRocmVhZHMv dGhyZWFkX2NoZWNrLmV4cCAuL25ldy9zcmMvZ2RiL3Rlc3RzdWl0ZS9nZGIu dGhyZWFkcy90aHJlYWRfY2hlY2suZXhwDQotLS0gLi9vbGQvc3JjL2dkYi90 ZXN0c3VpdGUvZ2RiLnRocmVhZHMvdGhyZWFkX2NoZWNrLmV4cAkxOTY5LTEy LTMxIDE4OjAwOjAwLjAwMDAwMDAwMCAtMDYwMA0KKysrIC4vbmV3L3NyYy9n ZGIvdGVzdHN1aXRlL2dkYi50aHJlYWRzL3RocmVhZF9jaGVjay5leHAJMjAw NC0wOC0yNyAwODoxMDoyMy4wODYzMjE3NDQgLTA1MDANCkBAIC0wLDAgKzEs OTYgQEANCisjIENvcHlyaWdodCAoQykgMjAwNCBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb24sIEluYy4NCisNCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNv ZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5 DQorIyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1 YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KKyMgdGhlIEZyZWUgU29m dHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGlj ZW5zZSwgb3INCisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNp b24uDQorIw0KKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRo ZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQorIyBidXQgV0lUSE9V VCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJy YW50eSBvZg0KKyMgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQ0KKyMgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4NCisjDQorIyBZb3Ug c2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZQ0KKyMgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW07 IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUNCisjIEZvdW5k YXRpb24sIEluYy4sIDU5IFRlbXBsZSBQbGFjZSAtIFN1aXRlIDMzMCwgQm9z dG9uLCBNQSAwMjExMS0xMzA3LCBVU0EuDQorDQorIyBQbGVhc2UgZW1haWwg YW55IGJ1Z3MsIGNvbW1lbnRzLCBhbmQvb3IgYWRkaXRpb25zIHRvIHRoaXMg ZmlsZSB0bzoNCisjIGJ1Zy1nZGJAcHJlcC5haS5taXQuZWR1DQorDQorIyBU aGlzIGZpbGUgd2FzIHdyaXR0ZW4gYnkgTWFub2ogSXllci4gKG1hbmpvQGF1 c3Rpbi5pYm0uY29tKQ0KKyMgVGVzdCBicmVhayBwb2ludHMgYW5kIHNpbmds ZSBzdGVwIG9uIHRocmVhZCBmdW5jdGlvbnMuDQorIyANCisjIFRlc3QgUHVy cG9zZToNCisjIC0gVGVzdCB0aGF0IGJyZWFrcG9pbnRzLCBjb250aW51ZSBp biBhIHRocmVhZGVkICBhcHBsaWNhdGlvbiB3b3Jrcy4gDQorIyAgIE9uIHBv d2VycGM2NC11bmtub3duLWxpbnV4LWdudSBzeXN0ZW0sIHJ1bm5pbmcga2Vy bmVsIHZlcnNpb24NCisjICAgMi42LjUtNy43MS1wc2VyaWVzNjQgdGhpcyB0 ZXN0IGlzIGtub3duIHRvIGZhaWwgZHVlIHRvIGtlcm5lbCBidWcNCisjICAg aW4gcHRyYWNlIHN5c3RlbSBjYWxsLg0KKyMNCisjIFRlc3QgU3RyYXRlZ3k6 DQorIyAtIHRidWcuYyBjcmVhdGVzIDIgdGhyZWFkcw0KKyMgLSBzdGFydCBn ZGIgDQorIyAtIGNyZWF0ZSAyIGJyZWFrcG9pbnRzICMxIG1haW4oKSAjMiB0 ZigpICh0aGUgdGhyZWFkIGZ1bmN0aW9uKQ0KKyMgLSBydW4gZ2RiIHRpbGwg IzEgbWFpbigpIGJyZWFrcG9pbnQgaXMgcmVhY2hlZA0KKyMgLSBjb250aW51 ZSB0byBicmVha3BvaW50ICMyIHRmKCkNCisjIC0gZGVsZXRlIGFsbCBicmVh a3BvaW50cyANCisjIC0gZXhpdCBnZGIuDQorDQoraWYgJHRyYWNlbGV2ZWwg dGhlbiB7DQorICAgICAgICBzdHJhY2UgJHRyYWNlbGV2ZWwNCit9DQorDQor c2V0IHBybXNfaWQgMA0KK3NldCBidWdfaWQgMA0KKw0KK3NldCB0ZXN0Zmls ZSAidGhyZWFkX2NoZWNrIg0KK3NldCBzcmNmaWxlICR7dGVzdGZpbGV9LmMN CitzZXQgYmluZmlsZSAke29iamRpcn0vJHtzdWJkaXJ9LyR7dGVzdGZpbGV9 DQorDQoraWYge1tnZGJfY29tcGlsZV9wdGhyZWFkcyAiJHtzcmNkaXJ9LyR7 c3ViZGlyfS8ke3NyY2ZpbGV9IiAiJHtiaW5maWxlfSIgZXhlY3V0YWJsZSBb bGlzdCBkZWJ1ZyAiaW5jZGlyPSR7b2JqZGlyfSJdXSAhPSAiIiB9IHsNCisg ICAgcmV0dXJuIC0xDQorfQ0KKw0KKw0KK2dkYl9zdGFydA0KK2dkYl9yZWlu aXRpYWxpemVfZGlyICRzcmNkaXIvJHN1YmRpcg0KK2dkYl9sb2FkICR7Ymlu ZmlsZX0NCisNCitpZiAhW3J1bnRvX21haW5dIHRoZW4gew0KKyAgIGZhaWwg IkNhbid0IHJ1biB0byBtYWluIg0KKyAgICAgIHJldHVybiAxOw0KK30NCisN CisNCisjDQorIyBzZXQgYnJlYWtwb2ludCBhdCB0aHJlYWQgZnVjbnRpb24g dGYNCisjDQorZ2RiX3Rlc3QgImJyZWFrIHRmIiBcDQorICAgICJCcmVha3Bv aW50LiphdC4qIGZpbGUgLiokc3JjZmlsZSwgbGluZS4qIiBcDQorICAgICJi cmVha3BvaW50IGF0IHRmIg0KKw0KKw0KKyMNCisjDQorIyBjb250aW51ZSB0 byB0ZigpIGJyZWFrcG9pbnQgIzINCisjDQorZ2RiX3Rlc3QgImNvbnRpbnVl IiBcDQorICAgICIuKkJyZWFrcG9pbnQgMi4qdGYuKiBhdCAuKnRidWcuKiAu KlxyXG4uKiRnZGJfcHJvbXB0ICQiIFwNCisgICAgICJjb250aW51ZSB0byB0 ZiINCisNCisjICAgDQorIyBiYWNrdHJhY2UgZnJvbSB0aHJlYWQgZnVuY3Rp b24uDQorIw0KK2dkYl90ZXN0ICJiYWNrdHJhY2UiIFwNCisgICAgIiMwIC4q dGYgLiphdCAuKnRidWcuKiIgXA0KKyAgICAiYmFja3RyYWNlIGZyb20gdGhy ZWFkIGZ1bmN0aW9uIg0KKw0KKw0KKyMNCisjIGRlbGV0ZSBhbGwgYnJlYWtw b2ludHMNCisjDQorZGVsZXRlX2JyZWFrcG9pbnRzDQorDQorIw0KKyMgZXhp dCBnZGINCisjDQorZ2RiX2V4aXQNCg== --8323328-352137877-1093630602=:19165--