From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22424 invoked by alias); 27 Aug 2004 00:00:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22349 invoked from network); 27 Aug 2004 00:00:16 -0000 Received: from unknown (HELO e31.co.us.ibm.com) (32.97.110.129) by sourceware.org with SMTP; 27 Aug 2004 00:00:16 -0000 Received: from westrelay04.boulder.ibm.com (westrelay04.boulder.ibm.com [9.17.193.32]) by e31.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id i7R00FgM265586; Thu, 26 Aug 2004 20:00:15 -0400 Received: from austin.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id i7QNEgLj103748; Thu, 26 Aug 2004 18:00:14 -0600 Received: from lazy.austin.ibm.com (lazy.austin.ibm.com [9.53.94.97]) by austin.ibm.com (8.12.10/8.12.10) with ESMTP id i7QG3QRn047700; Thu, 26 Aug 2004 11:03:26 -0500 Date: Fri, 27 Aug 2004 00:00:00 -0000 From: Manoj Iyer X-X-Sender: manjo@lazy To: gdb-patches@sources.redhat.com cc: Michael Chastain Subject: [RFC] GDB testsuite patch. (revised version) In-Reply-To: <412C98BD.nail10P1YTPHK@mindspring.com> Message-ID: References: <41251A45.nail58D215HD7@mindspring.com> <4125BB8B.nailJWP1FZGHJ@mindspring.com> <20040825124945.GA25217@nevyn.them.org> <412C98BD.nail10P1YTPHK@mindspring.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-240562666-1093533317=:2290" Content-ID: X-SW-Source: 2004-08/txt/msg00719.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --8323328-240562666-1093533317=:2290 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: Content-length: 1448 Michael, Ok here is another attempt, let me know what you think of this one. I added the change log to the begning of the attached file, and I am pasting the same below. 2004-08-26 Manoj Iyer Daniel Jacobowitz wrote: > > That's not the same as what you've done. gdb_file_cmd should not > > always fail for objects without debugging information, since there are > > other tests that work OK without it. This only applies to the gdb.gdb/ > > tests. > > Damn, I noticed this, but I got so caught up in the procedural criticism, > I forgot to mention it. > > Daniel is right; gdb_file_cmd is not a good place to test for this > unconditionally. You have to look in gdb.gdb/*.exp and find a good > way so that you make this check only for gdb.gdb/*.exp. > > Michael > --8323328-240562666-1093533317=:2290 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="gdb.testsuite.2004-08-26.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: testsuite patch Content-Disposition: ATTACHMENT; FILENAME="gdb.testsuite.2004-08-26.patch" Content-length: 7573 MjAwNC0wOC0yNiAgTWFub2ogSXllciAgPG1hbmpvQGF1c3Rpbi5pYm0uY29t DQoNCiAgICAgICAgKiBsaWIvZ2RiLmV4cCAoZ2RiX2NoZWNrX2RlYnVnaW5m byk6IE5ldyBwcm9jZWR1cmUNCiAgICAgICAgKiBnZGIuZ2RiL2NvbXBsYWlu dHMuZXhwOiBjaGVjayBpZiBnZGIgaGFzIGRlYnVnIGluZm9ybWF0aW9uLg0K ICAgICAgICAqIGdkYi5nZGIvb2JzZXJ2ZXIuZXhwOiBjaGVjayBpZiBnZGIg aGFzIGRlYnVnIGluZm9ybWF0aW9uLg0KICAgICAgICAqIGdkYi5nZGIvc2Vs ZnRlc3QuZXhwOiBjaGVjayBpZiBnZGIgaGFzIGRlYnVnIGluZm9ybWF0aW9u Lg0KICAgICAgICAqIGdkYi5nZGIveGZ1bGxwYXRoLmV4cDogY2hlY2sgaWYg Z2RiIGhhcyBkZWJ1ZyBpbmZvcm1hdGlvbi4NCg0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCg0KZGlmZiAtTmF1ciAuL29sZC9zcmMvZ2RiL3Rlc3Rz dWl0ZS9nZGIuZ2RiL2NvbXBsYWludHMuZXhwIC4vbmV3L3NyYy9nZGIvdGVz dHN1aXRlL2dkYi5nZGIvY29tcGxhaW50cy5leHANCi0tLSAuL29sZC9zcmMv Z2RiL3Rlc3RzdWl0ZS9nZGIuZ2RiL2NvbXBsYWludHMuZXhwCTIwMDQtMDgt MjQgMTg6MTY6MDAuODg5MTkxMjQ4IC0wNTAwDQorKysgLi9uZXcvc3JjL2dk Yi90ZXN0c3VpdGUvZ2RiLmdkYi9jb21wbGFpbnRzLmV4cAkyMDA0LTA4LTI2 IDA0OjQwOjI4LjM3NzI5NDEyMCAtMDUwMA0KQEAgLTMwMiwxMyArMzAyLDIw IEBADQogDQogZ2RiX3N0YXJ0DQogDQorDQogc2V0IGZpbGUgW3JlbW90ZV9k b3dubG9hZCBob3N0ICRHREJfRlVMTFBBVEggeCR0b29sXQ0KIA0KK3NldCBk ZWJ1Z19yZXN1bHQgW2dkYl9jaGVja19kZWJ1Z2luZm8geCR0b29sIF0NCitp ZiB7JGRlYnVnX3Jlc3VsdCA8IDB9IHRoZW4gew0KKyAgIHJldHVybiAtMQ0K K30NCisNCiBzZXQgc2V0dXBfcmVzdWx0IFtzZXR1cF90ZXN0ICRmaWxlIF0N CiBpZiB7JHNldHVwX3Jlc3VsdCA8MH0gdGhlbiB7DQogICAgIHJldHVybiAt MQ0KIH0NCiANCisNCiB0ZXN0X2luaXRpYWxfY29tcGxhaW50cw0KIHRlc3Rf c2VyaWFsX2NvbXBsYWludHMNCiB0ZXN0X3Nob3J0X2NvbXBsYWludHMNCmRp ZmYgLU5hdXIgLi9vbGQvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLmdkYi9vYnNl cnZlci5leHAgLi9uZXcvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLmdkYi9vYnNl cnZlci5leHANCi0tLSAuL29sZC9zcmMvZ2RiL3Rlc3RzdWl0ZS9nZGIuZ2Ri L29ic2VydmVyLmV4cAkyMDA0LTA4LTI0IDE4OjE2OjAwLjg4OTE5MTI0OCAt MDUwMA0KKysrIC4vbmV3L3NyYy9nZGIvdGVzdHN1aXRlL2dkYi5nZGIvb2Jz ZXJ2ZXIuZXhwCTIwMDQtMDgtMjYgMDQ6NDA6NDEuODU1MjQyMTM2IC0wNTAw DQpAQCAtMjU0LDYgKzI1NCwxMiBAQA0KIA0KIGdkYl9zdGFydA0KIHNldCBm aWxlIFtyZW1vdGVfZG93bmxvYWQgaG9zdCAkR0RCX0ZVTExQQVRIIHgkdG9v bF0NCisNCitzZXQgZGVidWdfcmVzdWx0IFtnZGJfY2hlY2tfZGVidWdpbmZv IHgkdG9vbCBdDQoraWYgeyRkZWJ1Z19yZXN1bHQgPCAwfSB0aGVuIHsNCisg ICByZXR1cm4gLTENCit9DQorDQogc2V0IHJlc3VsdCBbdGVzdF9vYnNlcnZl cl9ub3JtYWxfc3RvcCAkZmlsZV07DQogZ2RiX2V4aXQ7DQogY2F0Y2ggInJl bW90ZV9maWxlIGhvc3QgZGVsZXRlICRmaWxlIjsNCmRpZmYgLU5hdXIgLi9v bGQvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLmdkYi9zZWxmdGVzdC5leHAgLi9u ZXcvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLmdkYi9zZWxmdGVzdC5leHANCi0t LSAuL29sZC9zcmMvZ2RiL3Rlc3RzdWl0ZS9nZGIuZ2RiL3NlbGZ0ZXN0LmV4 cAkyMDA0LTA4LTI0IDE4OjE2OjAwLjg4OTE5MTI0OCAtMDUwMA0KKysrIC4v bmV3L3NyYy9nZGIvdGVzdHN1aXRlL2dkYi5nZGIvc2VsZnRlc3QuZXhwCTIw MDQtMDgtMjYgMDQ6NDA6NTcuMTk3MzA1OTc2IC0wNTAwDQpAQCAtNTA3LDYg KzUwNywxMiBAQA0KIA0KIGdkYl9zdGFydA0KIHNldCBmaWxlIFtyZW1vdGVf ZG93bmxvYWQgaG9zdCAkR0RCX0ZVTExQQVRIIHgkdG9vbF0NCisNCitzZXQg ZGVidWdfcmVzdWx0IFtnZGJfY2hlY2tfZGVidWdpbmZvIHgkdG9vbCBdDQor aWYgeyRkZWJ1Z19yZXN1bHQgPCAwfSB0aGVuIHsNCisgICByZXR1cm4gLTEN Cit9DQorDQogc2V0IHJlc3VsdCBbdGVzdF93aXRoX3NlbGYgJGZpbGVdOw0K IGdkYl9leGl0Ow0KIGNhdGNoICJyZW1vdGVfZmlsZSBob3N0IGRlbGV0ZSAk ZmlsZSI7DQpkaWZmIC1OYXVyIC4vb2xkL3NyYy9nZGIvdGVzdHN1aXRlL2dk Yi5nZGIveGZ1bGxwYXRoLmV4cCAuL25ldy9zcmMvZ2RiL3Rlc3RzdWl0ZS9n ZGIuZ2RiL3hmdWxscGF0aC5leHANCi0tLSAuL29sZC9zcmMvZ2RiL3Rlc3Rz dWl0ZS9nZGIuZ2RiL3hmdWxscGF0aC5leHAJMjAwNC0wOC0yNCAxODoxNjow MC44ODkxOTEyNDggLTA1MDANCisrKyAuL25ldy9zcmMvZ2RiL3Rlc3RzdWl0 ZS9nZGIuZ2RiL3hmdWxscGF0aC5leHAJMjAwNC0wOC0yNiAwNDo0MToxMS4y MDYzMDY0MzIgLTA1MDANCkBAIC0xNzksNiArMTc5LDEyIEBADQogDQogZ2Ri X3N0YXJ0DQogc2V0IGZpbGUgW3JlbW90ZV9kb3dubG9hZCBob3N0ICRHREJf RlVMTFBBVEggeCR0b29sXQ0KKw0KK3NldCBkZWJ1Z19yZXN1bHQgW2dkYl9j aGVja19kZWJ1Z2luZm8geCR0b29sIF0NCitpZiB7JGRlYnVnX3Jlc3VsdCA8 IDB9IHRoZW4gew0KKyAgIHJldHVybiAtMQ0KK30NCisNCiBzZXQgcmVzdWx0 IFt0ZXN0X3dpdGhfc2VsZiAkZmlsZV07DQogZ2RiX2V4aXQ7DQogY2F0Y2gg InJlbW90ZV9maWxlIGhvc3QgZGVsZXRlICRmaWxlIjsNCmRpZmYgLU5hdXIg Li9vbGQvc3JjL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAgLi9uZXcvc3Jj L2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHANCi0tLSAuL29sZC9zcmMvZ2Ri L3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cAkyMDA0LTA4LTI0IDE4OjE2OjAwLjg5 MjE5MDc5MiAtMDUwMA0KKysrIC4vbmV3L3NyYy9nZGIvdGVzdHN1aXRlL2xp Yi9nZGIuZXhwCTIwMDQtMDgtMjYgMDQ6NDA6MDEuNjQ1MjMxMTkyIC0wNTAw DQpAQCAtMTAyMyw2ICsxMDIzLDgyIEBADQogICAgIH0NCiB9DQogDQorDQor Iw0KKyMgQ2hlY2sgdG8gc2VlIGlmIHRoZSBleGVjdXRhYmxlIGhhcyBkZWJ1 ZyBpbmZvcm1hdGlvbi4gDQorIyBJZiBub3QgdGhlIHJldHVybiAtMSBhbmQg ZXhpdC4NCisjDQorcHJvYyBnZGJfY2hlY2tfZGVidWdpbmZvIHsgYXJnIH0g ew0KKyAgICBnbG9iYWwgdmVyYm9zZQ0KKyAgICBnbG9iYWwgbG9hZHBhdGgN CisgICAgZ2xvYmFsIGxvYWRmaWxlDQorICAgIGdsb2JhbCBHREINCisgICAg Z2xvYmFsIGdkYl9wcm9tcHQNCisgICAgdXB2YXIgdGltZW91dCB0aW1lb3V0 DQorDQorICAgIGlmIFtpc19yZW1vdGUgaG9zdF0gew0KKwlzZXQgYXJnIFty ZW1vdGVfZG93bmxvYWQgaG9zdCAkYXJnXTsNCisJaWYgeyAkYXJnID09ICIi IH0gew0KKwkgICAgZXJyb3IgImRvd25sb2FkIGZhaWxlZCINCisJICAgIHJl dHVybiAtMTsNCisJfQ0KKyAgICB9DQorDQorICAgIHNlbmRfZ2RiICJmaWxl ICRhcmdcbiINCisgICAgZ2RiX2V4cGVjdCAxMjAgew0KKwktcmUgIlJlYWRp bmcgc3ltYm9scyBmcm9tLipubyBkZWJ1Z2dpbmcgc3ltYm9scyBmb3VuZC4q JGdkYl9wcm9tcHQgJCIgew0KKwkgICAgdW50ZXN0ZWQgInNraXAgdGVzdHMg bm8gZGVidWdnaW5nIGluZm9ybWF0aW9uIGZvdW5kLiINCisJICAgIHJldHVy biAtMQ0KKwl9DQorICAgICAgICAtcmUgIlJlYWRpbmcgc3ltYm9scyBmcm9t Lipkb25lLiokZ2RiX3Byb21wdCAkIiB7DQorICAgICAgICAgICAgdmVyYm9z ZSAiXHRcdExvYWRlZCAkYXJnIGludG8gdGhlICRHREIiDQorICAgICAgICAg ICAgcmV0dXJuIDANCisgICAgICAgIH0NCisgICAgICAgIC1yZSAiaGFzIG5v IHN5bWJvbC10YWJsZS4qJGdkYl9wcm9tcHQgJCIgew0KKyAgICAgICAgICAg IHBlcnJvciAiJGFyZyB3YXNuJ3QgY29tcGlsZWQgd2l0aCBcIi1nXCIiDQor ICAgICAgICAgICAgcmV0dXJuIC0xDQorICAgICAgICB9DQorICAgICAgICAt cmUgIkEgcHJvZ3JhbSBpcyBiZWluZyBkZWJ1Z2dlZCBhbHJlYWR5LipLaWxs IGl0Lip5IG9yIG4uICQiIHsNCisgICAgICAgICAgICBzZW5kX2dkYiAieVxu Ig0KKyAgICAgICAgICAgICAgICB2ZXJib3NlICJcdFx0S2lsbGluZyBwcmV2 aW91cyBwcm9ncmFtIGJlaW5nIGRlYnVnZ2VkIg0KKyAgICAgICAgICAgIGV4 cF9jb250aW51ZQ0KKyAgICAgICAgfQ0KKyAgICAgICAgLXJlICJMb2FkIG5l dyBzeW1ib2wgdGFibGUgZnJvbSBcIi4qXCIuKnkgb3Igbi4gJCIgew0KKyAg ICAgICAgICAgIHNlbmRfZ2RiICJ5XG4iDQorICAgICAgICAgICAgZ2RiX2V4 cGVjdCAxMjAgew0KKyAgICAgICAgICAgICAgICAtcmUgIlJlYWRpbmcgc3lt Ym9scyBmcm9tLipkb25lLiokZ2RiX3Byb21wdCAkIiB7DQorICAgICAgICAg ICAgICAgICAgICB2ZXJib3NlICJcdFx0TG9hZGVkICRhcmcgd2l0aCBuZXcg c3ltYm9sIHRhYmxlIGludG8gJEdEQiINCisgICAgICAgICAgICAgICAgICAg IHJldHVybiAwDQorICAgICAgICAgICAgICAgIH0NCisgICAgICAgICAgICAg ICAgdGltZW91dCB7DQorICAgICAgICAgICAgICAgICAgICBwZXJyb3IgIih0 aW1lb3V0KSBDb3VsZG4ndCBsb2FkICRhcmcsIG90aGVyIHByb2dyYW0gYWxy ZWFkeSBsb2FkZWQuIg0KKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIC0x DQorICAgICAgICAgICAgICAgIH0NCisgICAgICAgICAgICB9DQorCX0NCisg ICAgICAgIC1yZSAiTm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeS4qJGdkYl9w cm9tcHQgJCIgew0KKyAgICAgICAgICAgIHBlcnJvciAiKCRhcmcpIE5vIHN1 Y2ggZmlsZSBvciBkaXJlY3RvcnlcbiINCisgICAgICAgICAgICByZXR1cm4g LTENCisgICAgICAgIH0NCisgICAgICAgIC1yZSAiJGdkYl9wcm9tcHQgJCIg ew0KKyAgICAgICAgICAgIHBlcnJvciAiY291bGRuJ3QgbG9hZCAkYXJnIGlu dG8gJEdEQi4iDQorICAgICAgICAgICAgcmV0dXJuIC0xDQorICAgICAgICAg ICAgfQ0KKyAgICAgICAgdGltZW91dCB7DQorICAgICAgICAgICAgcGVycm9y ICJjb3VsZG4ndCBsb2FkICRhcmcgaW50byAkR0RCICh0aW1lZCBvdXQpLiIN CisgICAgICAgICAgICByZXR1cm4gLTENCisgICAgICAgIH0NCisgICAgICAg IGVvZiB7DQorICAgICAgICAgICAgIyBUaGlzIGlzIGFuIGF0dGVtcHQgdG8g ZGV0ZWN0IGEgY29yZSBkdW1wLCBidXQgc2VlbXMgbm90IHRvDQorICAgICAg ICAgICAgIyB3b3JrLiAgUGVyaGFwcyB3ZSBuZWVkIHRvIG1hdGNoIC4qIGZv bGxvd2VkIGJ5IGVvZiwgaW4gd2hpY2gNCisgICAgICAgICAgICAjIGdkYl9l eHBlY3QgZG9lcyBub3Qgc2VlbSB0byBoYXZlIGEgd2F5IHRvIGRvIHRoYXQu DQorICAgICAgICAgICAgcGVycm9yICJjb3VsZG4ndCBsb2FkICRhcmcgaW50 byAkR0RCIChlbmQgb2YgZmlsZSkuIg0KKyAgICAgICAgICAgIHJldHVybiAt MQ0KKyAgICAgICAgfQ0KKyAgICB9DQorfQ0KKw0KKw0KICMNCiAjIHN0YXJ0 IGdkYiAtLSBzdGFydCBnZGIgcnVubmluZywgZGVmYXVsdCBwcm9jZWR1cmUN CiAjDQo= --8323328-240562666-1093533317=:2290--