From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1719 invoked by alias); 19 Oct 2004 20:22:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1705 invoked from network); 19 Oct 2004 20:22:14 -0000 Received: from unknown (HELO mail.amplepower.com) (216.39.162.139) by sourceware.org with SMTP; 19 Oct 2004 20:22:14 -0000 Received: from [192.168.8.30] (helo=knuth.amplepower.com ident=roth) by mail.amplepower.com with esmtp (Exim 3.36 #1 (Debian)) id 1CK0Un-0006E6-00 for ; Tue, 19 Oct 2004 13:22:13 -0700 Date: Tue, 19 Oct 2004 20:22:00 -0000 From: "Theodore A. Roth" X-X-Sender: roth@knuth.amplepower.com To: gdb-patches@sources.redhat.com Subject: [RFA] initialize err variable in load_section_callback() Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463804408-1568122446-1098216925=:17223" Content-ID: X-SW-Source: 2004-10/txt/msg00324.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---1463804408-1568122446-1098216925=:17223 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: Content-length: 849 Hi, I just encountered a problem with using the "load" command with a remote avr target. The first packet would be sent to the remote target and then gdb would just give up with this error message: (gdb) load Loading section .text, size 0x1f8 lma 0x0 Sending packet: $M0,a:0c9446000c9463000c94#d7...Ack Packet received: OK Memory access error while loading section .text. It looks like load_section_callback() in symfile.c is assuming that a call to target_write_memory_partial() will set the err variable. Unfortunately, that is not a valid assumption. The attached patch got things working again, but this feels like a hack to me since target_write_memory_partial() should really be setting err to a sane value before returning. Patch is against today's cvs mainline. --- Ted Roth PGP Key ID: 0x18F846E9 Jabber ID: troth@jabber.org ---1463804408-1568122446-1098216925=:17223 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="gdb-symfile-init-err.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME="gdb-symfile-init-err.diff" Content-length: 1070 MjAwNC0xMC0xOSAgVGhlb2RvcmUgQS4gUm90aCAgPHRyb3RoQG9wZW5hdnIu b3JnPg0KDQoJKiBzeW1maWxlLmMgKGxvYWRfc2VjdGlvbl9jYWxsYmFjayk6 IEluaXRpYWxpemUgZXJyIHRvIHplcm8gc2luY2UNCgl0YXJnZXRfd3JpdGVf bWVtb3J5X3BhcnRpYWwoKSBtYXkgbm90IHNldCBpdCBpbiBhbGwgc2l0dWF0 aW9ucy4NCg0KSW5kZXg6IHN5bWZpbGUuYw0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvc3ltZmlsZS5jLHYN CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNDMNCmRpZmYgLXUgLXAgLXAgLXIx LjE0MyBzeW1maWxlLmMNCi0tLSBzeW1maWxlLmMJMSBPY3QgMjAwNCAxMDoy MzowOSAtMDAwMAkxLjE0Mw0KKysrIHN5bWZpbGUuYwkxOSBPY3QgMjAwNCAy MDowNzo1OCAtMDAwMA0KQEAgLTE0MDUsNyArMTQwNSw3IEBAIGxvYWRfc2Vj dGlvbl9jYWxsYmFjayAoYmZkICphYmZkLCBhc2VjdGkNCiAJICBzdHJ1Y3Qg Y2xlYW51cCAqb2xkX2NoYWluOw0KIAkgIENPUkVfQUREUiBsbWEgPSBiZmRf c2VjdGlvbl9sbWEgKGFiZmQsIGFzZWMpICsgYXJncy0+bG9hZF9vZmZzZXQ7 DQogCSAgYmZkX3NpemVfdHlwZSBibG9ja19zaXplOw0KLQkgIGludCBlcnI7 DQorCSAgaW50IGVyciA9IDA7DQogCSAgY29uc3QgY2hhciAqc2VjdF9uYW1l ID0gYmZkX2dldF9zZWN0aW9uX25hbWUgKGFiZmQsIGFzZWMpOw0KIAkgIGJm ZF9zaXplX3R5cGUgc2VudDsNCiANCg== ---1463804408-1568122446-1098216925=:17223--