From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25161 invoked by alias); 7 Oct 2003 22:03:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25151 invoked from network); 7 Oct 2003 22:03:23 -0000 Received: from unknown (HELO planck.amplepower.com) (216.39.162.139) by sources.redhat.com with SMTP; 7 Oct 2003 22:03:23 -0000 Received: from [192.168.8.30] (helo=knuth.amplepower.com ident=roth) by planck.amplepower.com with esmtp (Exim 3.36 #1 (Debian)) id 1A6zv6-0005O3-00 for ; Tue, 07 Oct 2003 15:03:04 -0700 Date: Tue, 07 Oct 2003 22:03:00 -0000 From: "Theodore A. Roth" X-X-Sender: roth@knuth.amplepower.com cc: gdb-patches@sources.redhat.com Subject: Re: RFC: Use program_transform_name correctly In-Reply-To: <20031007215028.GA11817@nevyn.them.org> Message-ID: References: <20031007215028.GA11817@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2003-10/txt/msg00175.txt.bz2 On Tue, 7 Oct 2003, Daniel Jacobowitz wrote: > On Tue, Oct 07, 2003 at 04:41:35PM -0500, Jim Blandy wrote: > > > > It seems as if some Makefiles aren't properly using > > program_transform_name. > > > > The same kind of weirdness corrected(?) in the patch below appears in > > gdb/Makefile.in, so I'm not at all sure I'm not misunderstanding > > what's going on. If folks agree that the change below would be > > correct, then I'll put together a larger patch that fixes the ones I > > can find elsewhere, too. > > > > (Not sure why this hasn't come up before; Daniel J.'s recent posts on > > the topic seem to be about setting program_transform_name, not on how > > to use it.) > > That is _bizarre_. Does it even give you anything but a sed error now? > > > 2003-10-07 Jim Blandy > > > > * Makefile.in (RUNTEST_FOR_TARGET): Pass the transformation to set > > properly. > > > > Index: gdb/testsuite//Makefile.in > > =================================================================== > > RCS file: /cvs/cvsfiles/devo/gdb/testsuite/Makefile.in,v > > retrieving revision 1.66 > > diff -c -r1.66 Makefile.in > > *** gdb/testsuite//Makefile.in 9 Sep 2003 21:03:53 -0000 1.66 > > --- gdb/testsuite//Makefile.in 7 Oct 2003 21:33:22 -0000 > > *************** > > *** 53,59 **** > > if [ "$(host_canonical)" = "$(target_canonical)" ]; then \ > > echo runtest; \ > > else \ > > ! t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \ > > fi; \ > > fi` > > > > --- 53,59 ---- > > if [ "$(host_canonical)" = "$(target_canonical)" ]; then \ > > echo runtest; \ > > else \ > > ! t='$(program_transform_name)'; echo runtest | sed -e '$$t'; \ > > fi; \ > > fi` > > That's certainly what it's supposed to look like. > You sure that the expression is right? I think the single quotes will hide the expansion of $t in the shell. I ran a simple test on my system with this make file fragment: roth@knuth:/tmp$ cat Makefile program_transform_name = s/^/avr-/ all: t='$(program_transform_name)'; echo runtest | sed -e '$$t' t='$(program_transform_name)'; echo runtest | sed -e "$$t" roth@knuth:/tmp$ make t='s/^/avr-/'; echo runtest | sed -e '$t' runtest t='s/^/avr-/'; echo runtest | sed -e "$t" avr-runtest Ted Roth