Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Theodore A. Roth" <troth@openavr.org>
To: gdb-patches@sources.redhat.com
Subject: [RFA] sed bug in Makefile.in
Date: Fri, 11 Jul 2003 17:08:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.53.0307111003570.22711@knuth.amplepower.com> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1239 bytes --]

Hi,

I just tried to configure and build gdb with:

  ../configure --prefix=$HOME/local/avr --program-suffix=-6.0 --target=avr --enable-gdb-build-warnings=,-Werror
  ../configure --prefix=$HOME/local/avr --program-suffix=-6.0 --program-prefix=avr- --target=avr --enable-gdb-build-warnings=,-Werror

Both failed to install avr-gdb-6.0 which I expected.

The failure (on 'make install') is this:

make[1]: Leaving directory
`/home/roth/dev/tools/gdb-6.0-cvs/obj-avr/gdb'
transformed_name=`t='s,$,-6.0,; s,^,avr-,; '; \
                  echo gdb | sed -e $t` ; \
        if test "x$transformed_name" = x; then \
          transformed_name=gdb ; \
        else \
          true ; \
        fi ; \
        /bin/sh ../../gdb/../mkinstalldirs /home/roth/local/avr/bin ; \
        /usr/bin/install -c gdb \
                /home/roth/local/avr/bin/$transformed_name ; \
        /bin/sh ../../gdb/../mkinstalldirs \
                /home/roth/local/avr/man/man1 ; \
        /usr/bin/install -c -m 644 ../../gdb/gdb.1 \
                /home/roth/local/avr/man/man1/$transformed_name.1
sed: can't read s,^,avr-,;: No such file or directory


The attached patch seems to fix this.

Ok to commit? Should probably go on both head and branch.

Ted Roth

[-- Attachment #2: Type: TEXT/PLAIN, Size: 714 bytes --]

2003-07-11  Theodore A. Roth  <troth@openavr.org>

	* Makefile.in: Quote sed expression when generating transformed_name.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.410.2.5
diff -u -r1.410.2.5 Makefile.in
--- Makefile.in	8 Jul 2003 20:17:35 -0000	1.410.2.5
+++ Makefile.in	11 Jul 2003 16:56:23 -0000
@@ -956,7 +956,7 @@
 install: all install-only
 install-only: $(CONFIG_INSTALL)
 	transformed_name=`t='$(program_transform_name)'; \
-			  echo gdb | sed -e $$t` ; \
+			  echo gdb | sed -e "$$t"` ; \
 		if test "x$$transformed_name" = x; then \
 		  transformed_name=gdb ; \
 		else \

             reply	other threads:[~2003-07-11 17:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-11 17:08 Theodore A. Roth [this message]
2003-07-11 17:38 ` Daniel Jacobowitz
2003-07-11 18:18   ` Theodore A. Roth
2003-07-11 19:35     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.53.0307111003570.22711@knuth.amplepower.com \
    --to=troth@openavr.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox