From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18206 invoked by alias); 3 Jun 2003 23:13:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18173 invoked from network); 3 Jun 2003 23:13:11 -0000 Received: from unknown (HELO planck.amplepower.com) (216.39.162.139) by sources.redhat.com with SMTP; 3 Jun 2003 23:13:11 -0000 Received: from [192.168.8.30] (helo=knuth.amplepower.com ident=roth) by planck.amplepower.com with esmtp (Exim 3.36 #1 (Debian)) id 19NKoo-0007Ir-00; Tue, 03 Jun 2003 16:03:50 -0700 Date: Tue, 03 Jun 2003 23:13:00 -0000 From: "Theodore A. Roth" X-X-Sender: roth@knuth.amplepower.com To: Andrew Cagney cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] fix calculation of sizeof_g_packet In-Reply-To: <3EDD1FA3.9020306@redhat.com> Message-ID: References: <3EDD1FA3.9020306@redhat.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463804408-1821821505-1054682227=:17269" X-SW-Source: 2003-06/txt/msg00151.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---1463804408-1821821505-1054682227=:17269 Content-Type: TEXT/PLAIN; charset=US-ASCII Content-length: 1351 On Tue, 3 Jun 2003, Andrew Cagney wrote: :) > The attached patch changes init_remote_state() so that sizeof_g_packet :) > computed using REGISTER_RAW_SIZE() instead of blindly set to :) > DEPRECATED_REGISTER_BYTES. :) > :) > I'm assuming two things which I'm not sure are true: :) > :) > 1) REGISTER_RAW_SIZE() is usable for all targets now :) > :) > 2) REGISTER_RAW_SIZE() is valid when passed pseudo register. :) > :) > Ok to commit? :) :) Just a few tweaks. :) > - /* Start out by having the remote protocol mimic the existing :) > - behavour - just copy in the description of the register cache. */ :) > - rs->sizeof_g_packet = DEPRECATED_REGISTER_BYTES; /* OK */ :) > + rs->sizeof_g_packet = 0; :) :) For the moment it is safer to do: :) :) if (DEPRECATED_REGISTER_BYTES_P ()) :) rs-> ... = ...; :) else :) rs-> ... = 0; Well, DEPRECATED_REGISTER_BYTES_P() doesn't seem to exist. So there should need to be a change in gdbarch.sh I assume. Round two is attached. Ok now? Ted Roth 2003-06-03 Theodore A. Roth * gdbarch.sh: Generate a predicate for DEPRECATED_REGISTER_BYTES. * gdbarch.[ch]: Re-generate. * remote.c (init_remote_state): Compute sizeof_g_packet by accumulation of the size of all registers instead of blindly using DEPRECATED_REGISTER_BYTES. ---1463804408-1821821505-1054682227=:17269 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="sizeof-g-packet-fix-2.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="sizeof-g-packet-fix-2.diff" Content-length: 8573 MjAwMy0wNi0wMyAgVGhlb2RvcmUgQS4gUm90aCAgPHRyb3RoQG9wZW5hdnIu b3JnPg0KDQoJKiBnZGJhcmNoLnNoOiBHZW5lcmF0ZSBhIHByZWRpY2F0ZSBm b3IgREVQUkVDQVRFRF9SRUdJU1RFUl9CWVRFUy4NCgkqIGdkYmFyY2guW2No XTogUmUtZ2VuZXJhdGUuDQoJKiByZW1vdGUuYyAoaW5pdF9yZW1vdGVfc3Rh dGUpOiBDb21wdXRlIHNpemVvZl9nX3BhY2tldCBieSANCglhY2N1bXVsYXRp b24gb2YgdGhlIHNpemUgb2YgYWxsIHJlZ2lzdGVycyBpbnN0ZWFkIG9mIGJs aW5kbHkgdXNpbmcNCglERVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVTLg0KDQpJ bmRleDogZ2RiYXJjaC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9nZGJhcmNoLmMsdg0KcmV0cmlldmlu ZyByZXZpc2lvbiAxLjIxOA0KZGlmZiAtdSAtcCAtcjEuMjE4IGdkYmFyY2gu Yw0KLS0tIGdkYmFyY2guYwkyIEp1biAyMDAzIDAyOjU0OjMzIC0wMDAwCTEu MjE4DQorKysgZ2RiYXJjaC5jCTMgSnVuIDIwMDMgMjI6NTg6NTYgLTAwMDAN CkBAIC02NDQsNiArNjQ0LDcgQEAgdmVyaWZ5X2dkYmFyY2ggKHN0cnVjdCBn ZGJhcmNoICpnZGJhcmNoKQ0KICAgLyogU2tpcCB2ZXJpZnkgb2Ygc2RiX3Jl Z190b19yZWdudW0sIGludmFsaWRfcCA9PSAwICovDQogICAvKiBTa2lwIHZl cmlmeSBvZiBkd2FyZjJfcmVnX3RvX3JlZ251bSwgaW52YWxpZF9wID09IDAg Ki8NCiAgIC8qIFNraXAgdmVyaWZ5IG9mIHJlZ2lzdGVyX25hbWUsIGludmFs aWRfcCA9PSAwICovDQorICAvKiBTa2lwIHZlcmlmeSBvZiBkZXByZWNhdGVk X3JlZ2lzdGVyX2J5dGVzLCBoYXMgcHJlZGljYXRlICovDQogICAvKiBTa2lw IHZlcmlmeSBvZiByZWdpc3Rlcl9ieXRlLCBoYXMgcHJlZGljYXRlICovDQog ICAvKiBTa2lwIHZlcmlmeSBvZiByZWdpc3Rlcl9yYXdfc2l6ZSwgaW52YWxp ZF9wID09IDAgKi8NCiAgIC8qIFNraXAgdmVyaWZ5IG9mIGRlcHJlY2F0ZWRf bWF4X3JlZ2lzdGVyX3Jhd19zaXplLCBoYXMgcHJlZGljYXRlICovDQpAQCAt MTQ4Myw2ICsxNDg0LDE1IEBAIGdkYmFyY2hfZHVtcCAoc3RydWN0IGdkYmFy Y2ggKmdkYmFyY2gsIHMNCiAgICAgICAgICAgICAgICAgICAgICAgICAobG9u ZykgY3VycmVudF9nZGJhcmNoLT5kZXByZWNhdGVkX3B1c2hfcmV0dXJuX2Fk ZHJlc3MNCiAgICAgICAgICAgICAgICAgICAgICAgICAvKkRFUFJFQ0FURURf UFVTSF9SRVRVUk5fQUREUkVTUyAoKSovKTsNCiAjZW5kaWYNCisjaWZkZWYg REVQUkVDQVRFRF9SRUdJU1RFUl9CWVRFU19QDQorICBmcHJpbnRmX3VuZmls dGVyZWQgKGZpbGUsDQorICAgICAgICAgICAgICAgICAgICAgICJnZGJhcmNo X2R1bXA6ICVzICMgJXNcbiIsDQorICAgICAgICAgICAgICAgICAgICAgICJE RVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVTX1AoKSIsDQorICAgICAgICAgICAg ICAgICAgICAgIFhTVFJJTkcgKERFUFJFQ0FURURfUkVHSVNURVJfQllURVNf UCAoKSkpOw0KKyAgZnByaW50Zl91bmZpbHRlcmVkIChmaWxlLA0KKyAgICAg ICAgICAgICAgICAgICAgICAiZ2RiYXJjaF9kdW1wOiBERVBSRUNBVEVEX1JF R0lTVEVSX0JZVEVTX1AoKSA9ICVkXG4iLA0KKyAgICAgICAgICAgICAgICAg ICAgICBERVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVTX1AgKCkpOw0KKyNlbmRp Zg0KICNpZmRlZiBERVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVTDQogICBmcHJp bnRmX3VuZmlsdGVyZWQgKGZpbGUsDQogICAgICAgICAgICAgICAgICAgICAg ICJnZGJhcmNoX2R1bXA6IERFUFJFQ0FURURfUkVHSVNURVJfQllURVMgIyAl c1xuIiwNCkBAIC0zMzIyLDYgKzMzMzIsMTMgQEAgc2V0X2dkYmFyY2hfZGVw cmVjYXRlZF9yZWdpc3Rlcl9zaXplIChzdA0KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW50IGRlcHJlY2F0ZWRfcmVnaXN0ZXJf c2l6ZSkNCiB7DQogICBnZGJhcmNoLT5kZXByZWNhdGVkX3JlZ2lzdGVyX3Np emUgPSBkZXByZWNhdGVkX3JlZ2lzdGVyX3NpemU7DQorfQ0KKw0KK2ludA0K K2dkYmFyY2hfZGVwcmVjYXRlZF9yZWdpc3Rlcl9ieXRlc19wIChzdHJ1Y3Qg Z2RiYXJjaCAqZ2RiYXJjaCkNCit7DQorICBnZGJfYXNzZXJ0IChnZGJhcmNo ICE9IE5VTEwpOw0KKyAgcmV0dXJuIGdkYmFyY2gtPmRlcHJlY2F0ZWRfcmVn aXN0ZXJfYnl0ZXMgIT0gMDsNCiB9DQogDQogaW50DQpJbmRleDogZ2RiYXJj aC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2dkYi9nZGJhcmNoLmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAx LjE4OA0KZGlmZiAtdSAtcCAtcjEuMTg4IGdkYmFyY2guaA0KLS0tIGdkYmFy Y2guaAkyIEp1biAyMDAzIDAyOjU0OjMzIC0wMDAwCTEuMTg4DQorKysgZ2Ri YXJjaC5oCTMgSnVuIDIwMDMgMjI6NTg6NTcgLTAwMDANCkBAIC02NjIsNiAr NjYyLDMxIEBAIGV4dGVybiB2b2lkIHNldF9nZGJhcmNoX2RlcHJlY2F0ZWRf cmVnaXMNCiAjZGVmaW5lIERFUFJFQ0FURURfUkVHSVNURVJfU0laRSAoZ2Ri YXJjaF9kZXByZWNhdGVkX3JlZ2lzdGVyX3NpemUgKGN1cnJlbnRfZ2RiYXJj aCkpDQogI2VuZGlmDQogDQorI2lmIGRlZmluZWQgKERFUFJFQ0FURURfUkVH SVNURVJfQllURVMpDQorLyogTGVnYWN5IGZvciBzeXN0ZW1zIHlldCB0byBt dWx0aS1hcmNoIERFUFJFQ0FURURfUkVHSVNURVJfQllURVMgKi8NCisjaWYg IWRlZmluZWQgKERFUFJFQ0FURURfUkVHSVNURVJfQllURVNfUCkNCisjZGVm aW5lIERFUFJFQ0FURURfUkVHSVNURVJfQllURVNfUCgpICgxKQ0KKyNlbmRp Zg0KKyNlbmRpZg0KKw0KKy8qIERlZmF1bHQgcHJlZGljYXRlIGZvciBub24t IG11bHRpLWFyY2ggdGFyZ2V0cy4gKi8NCisjaWYgKCFHREJfTVVMVElfQVJD SCkgJiYgIWRlZmluZWQgKERFUFJFQ0FURURfUkVHSVNURVJfQllURVNfUCkN CisjZGVmaW5lIERFUFJFQ0FURURfUkVHSVNURVJfQllURVNfUCgpICgwKQ0K KyNlbmRpZg0KKw0KK2V4dGVybiBpbnQgZ2RiYXJjaF9kZXByZWNhdGVkX3Jl Z2lzdGVyX2J5dGVzX3AgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoKTsNCisj aWYgKEdEQl9NVUxUSV9BUkNIID4gR0RCX01VTFRJX0FSQ0hfUEFSVElBTCkg JiYgZGVmaW5lZCAoREVQUkVDQVRFRF9SRUdJU1RFUl9CWVRFU19QKQ0KKyNl cnJvciAiTm9uIG11bHRpLWFyY2ggZGVmaW5pdGlvbiBvZiBERVBSRUNBVEVE X1JFR0lTVEVSX0JZVEVTIg0KKyNlbmRpZg0KKyNpZiAoR0RCX01VTFRJX0FS Q0ggPiBHREJfTVVMVElfQVJDSF9QQVJUSUFMKSB8fCAhZGVmaW5lZCAoREVQ UkVDQVRFRF9SRUdJU1RFUl9CWVRFU19QKQ0KKyNkZWZpbmUgREVQUkVDQVRF RF9SRUdJU1RFUl9CWVRFU19QKCkgKGdkYmFyY2hfZGVwcmVjYXRlZF9yZWdp c3Rlcl9ieXRlc19wIChjdXJyZW50X2dkYmFyY2gpKQ0KKyNlbmRpZg0KKw0K Ky8qIERlZmF1bHQgKHZhbHVlKSBmb3Igbm9uLSBtdWx0aS1hcmNoIHBsYXRm b3Jtcy4gKi8NCisjaWYgKCFHREJfTVVMVElfQVJDSCkgJiYgIWRlZmluZWQg KERFUFJFQ0FURURfUkVHSVNURVJfQllURVMpDQorI2RlZmluZSBERVBSRUNB VEVEX1JFR0lTVEVSX0JZVEVTICgwKQ0KKyNlbmRpZg0KKw0KIGV4dGVybiBp bnQgZ2RiYXJjaF9kZXByZWNhdGVkX3JlZ2lzdGVyX2J5dGVzIChzdHJ1Y3Qg Z2RiYXJjaCAqZ2RiYXJjaCk7DQogZXh0ZXJuIHZvaWQgc2V0X2dkYmFyY2hf ZGVwcmVjYXRlZF9yZWdpc3Rlcl9ieXRlcyAoc3RydWN0IGdkYmFyY2ggKmdk YmFyY2gsIGludCBkZXByZWNhdGVkX3JlZ2lzdGVyX2J5dGVzKTsNCiAjaWYg KEdEQl9NVUxUSV9BUkNIID4gR0RCX01VTFRJX0FSQ0hfUEFSVElBTCkgJiYg ZGVmaW5lZCAoREVQUkVDQVRFRF9SRUdJU1RFUl9CWVRFUykNCkluZGV4OiBn ZGJhcmNoLnNoDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi9nZGJhcmNoLnNoLHYNCnJldHJpZXZpbmcgcmV2 aXNpb24gMS4yNDANCmRpZmYgLXUgLXAgLXIxLjI0MCBnZGJhcmNoLnNoDQot LS0gZ2RiYXJjaC5zaAkyIEp1biAyMDAzIDAyOjU0OjM0IC0wMDAwCTEuMjQw DQorKysgZ2RiYXJjaC5zaAkzIEp1biAyMDAzIDIyOjU4OjU4IC0wMDAwDQpA QCAtNDczLDcgKzQ3Myw3IEBAIGY6MjpTREJfUkVHX1RPX1JFR05VTTppbnQ6 c2RiX3JlZ190b19yZWcNCiBmOjI6RFdBUkYyX1JFR19UT19SRUdOVU06aW50 OmR3YXJmMl9yZWdfdG9fcmVnbnVtOmludCBkd2FyZjJfcmVnbnI6ZHdhcmYy X3JlZ25yOjo6bm9fb3BfcmVnX3RvX3JlZ251bTo6MA0KIGY6MjpSRUdJU1RF Ul9OQU1FOmNvbnN0IGNoYXIgKjpyZWdpc3Rlcl9uYW1lOmludCByZWducjpy ZWducjo6OmxlZ2FjeV9yZWdpc3Rlcl9uYW1lOjowDQogdjo6REVQUkVDQVRF RF9SRUdJU1RFUl9TSVpFOmludDpkZXByZWNhdGVkX3JlZ2lzdGVyX3NpemUN Ci12OjpERVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVTOmludDpkZXByZWNhdGVk X3JlZ2lzdGVyX2J5dGVzDQorVjo6REVQUkVDQVRFRF9SRUdJU1RFUl9CWVRF UzppbnQ6ZGVwcmVjYXRlZF9yZWdpc3Rlcl9ieXRlcw0KICMgTk9URTogY2Fn bmV5LzIwMDItMDUtMDI6IFRoaXMgZnVuY3Rpb24gd2l0aCBwcmVkaWNhdGUg aGFzIGEgdmFsaWQNCiAjIChjYWxsYWJsZSkgaW5pdGlhbCB2YWx1ZS4gIEFz IGEgY29uc2VxdWVuY2UsIGV2ZW4gd2hlbiB0aGUgcHJlZGljYXRlDQogIyBp cyBmYWxzZSwgdGhlIGNvcnJlc3BvbmRpbmcgZnVuY3Rpb24gd29ya3MuICBU aGlzIHNpbXBsaWZpZXMgdGhlDQpJbmRleDogcmVtb3RlLmMNCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3Jl bW90ZS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMDANCmRpZmYgLXUg LXAgLXIxLjEwMCByZW1vdGUuYw0KLS0tIHJlbW90ZS5jCTE3IE1heSAyMDAz IDA1OjU5OjU4IC0wMDAwCTEuMTAwDQorKysgcmVtb3RlLmMJMyBKdW4gMjAw MyAyMjo1OTowMCAtMDAwMA0KQEAgLTI2MSw5ICsyNjEsMTAgQEAgaW5pdF9y ZW1vdGVfc3RhdGUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcg0KICAgaW50IHJl Z251bTsNCiAgIHN0cnVjdCByZW1vdGVfc3RhdGUgKnJzID0geG1hbGxvYyAo c2l6ZW9mIChzdHJ1Y3QgcmVtb3RlX3N0YXRlKSk7DQogDQotICAvKiBTdGFy dCBvdXQgYnkgaGF2aW5nIHRoZSByZW1vdGUgcHJvdG9jb2wgbWltaWMgdGhl IGV4aXN0aW5nDQotICAgICBiZWhhdm91ciAtIGp1c3QgY29weSBpbiB0aGUg ZGVzY3JpcHRpb24gb2YgdGhlIHJlZ2lzdGVyIGNhY2hlLiAgKi8NCi0gIHJz LT5zaXplb2ZfZ19wYWNrZXQgPSBERVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVT OyAvKiBPSyAqLw0KKyAgaWYgKERFUFJFQ0FURURfUkVHSVNURVJfQllURVNf UCAoKSkNCisgICAgcnMtPnNpemVvZl9nX3BhY2tldCA9IERFUFJFQ0FURURf UkVHSVNURVJfQllURVM7DQorICBlbHNlDQorICAgIHJzLT5zaXplb2ZfZ19w YWNrZXQgPSAwOw0KIA0KICAgLyogQXNzdW1lIGEgMToxIHJlZ251bTwtPnBu dW0gdGFibGUuICAqLw0KICAgcnMtPnJlZ3MgPSB4Y2FsbG9jIChOVU1fUkVH UyArIE5VTV9QU0VVRE9fUkVHUywgc2l6ZW9mIChzdHJ1Y3QgcGFja2V0X3Jl ZykpOw0KQEAgLTI3NCw4ICsyNzUsMTEgQEAgaW5pdF9yZW1vdGVfc3RhdGUg KHN0cnVjdCBnZGJhcmNoICpnZGJhcg0KICAgICAgIHItPnJlZ251bSA9IHJl Z251bTsNCiAgICAgICByLT5vZmZzZXQgPSBSRUdJU1RFUl9CWVRFIChyZWdu dW0pOw0KICAgICAgIHItPmluX2dfcGFja2V0ID0gKHJlZ251bSA8IE5VTV9S RUdTKTsNCi0gICAgICAvKiAuLi5zaXplID0gUkVHSVNURVJfUkFXX1NJWkUg KHJlZ251bSk7ICovDQogICAgICAgLyogLi4ubmFtZSA9IFJFR0lTVEVSX05B TUUgKHJlZ251bSk7ICovDQorDQorICAgICAgLyogQ29tcHV0ZSBwYWNrZXQg c2l6ZSBieSBhY2N1bXVsYXRpbmcgdGhlIHNpemUgb2YgYWxsIHJlZ2lzdGVy cy4gKi8NCisgICAgICBpZiAoIURFUFJFQ0FURURfUkVHSVNURVJfQllURVNf UCAoKSkNCisgICAgICAgIHJzLT5zaXplb2ZfZ19wYWNrZXQgKz0gcmVnaXN0 ZXJfc2l6ZSAoY3VycmVudF9nZGJhcmNoLCByZWdudW0pOw0KICAgICB9DQog DQogICAvKiBEZWZhdWx0IG1heGltdW0gbnVtYmVyIG9mIGNoYXJhY3RlcnMg aW4gYSBwYWNrZXQgYm9keS4gTWFueQ0K ---1463804408-1821821505-1054682227=:17269--