From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4060 invoked by alias); 7 Jan 2005 00:23:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4000 invoked from network); 7 Jan 2005 00:23:11 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Jan 2005 00:23:11 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j070NAVt009973 for ; Thu, 6 Jan 2005 19:23:10 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j070NAr10240; Thu, 6 Jan 2005 19:23:10 -0500 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id j070NAoS014036; Thu, 6 Jan 2005 19:23:10 -0500 Received: from tooth.toronto.redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id F2055800001; Thu, 6 Jan 2005 19:23:09 -0500 (EST) Date: Fri, 07 Jan 2005 00:23:00 -0000 From: jjohnstn X-X-Sender: jjohnstn@tooth.toronto.redhat.com To: Michael Snyder Cc: Daniel Jacobowitz , Eli Zaretskii , Subject: Re: [RFA]: Modified Watchthreads Patch In-Reply-To: <41CB482E.1020906@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-01/txt/msg00035.txt.bz2 On Thu, 23 Dec 2004, Michael Snyder wrote: > Jeff Johnston wrote: > > > Originally, S390 also shared this code as it too has to insert > > watchpoints on all threads. However, it stores its own list of > > watchpoints so it doesn't require breakpoint.c to go through the > > breakpoint list and find them anymore. > > Maybe breakpoint.h should export a method for traversing > the breakpoint list (as objfiles.h does for the objfiles > list). > In my particular case, there is more than just traversal logic. I didn't want that to leave breakpoint.c as I felt that future changes to the value chain logic or breakpoint struct logic would be best encapsulated there. Does that seem reasonable? -- Jeff J. > >