From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15306 invoked by alias); 4 Jun 2003 04:35:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15228 invoked from network); 4 Jun 2003 04:35:27 -0000 Received: from unknown (HELO planck.amplepower.com) (216.39.162.139) by sources.redhat.com with SMTP; 4 Jun 2003 04:35:27 -0000 Received: from [192.168.8.29] (helo=bozoland.mynet) by planck.amplepower.com with esmtp (Exim 3.36 #1 (Debian)) id 19NPqd-0007za-00; Tue, 03 Jun 2003 21:26:04 -0700 Date: Wed, 04 Jun 2003 04:35:00 -0000 From: "Theodore A. Roth" X-X-Sender: troth@bozoland.mynet To: Andrew Cagney cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] fix calculation of sizeof_g_packet In-Reply-To: <3EDD5D13.3060902@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463809535-575425996-1054701223=:16658" X-SW-Source: 2003-06/txt/msg00160.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---1463809535-575425996-1054701223=:16658 Content-Type: TEXT/PLAIN; charset=US-ASCII Content-length: 1639 On Tue, 3 Jun 2003, Andrew Cagney wrote: :)> On Tue, 3 Jun 2003, Andrew Cagney wrote: :)> :)> :) > The attached patch changes init_remote_state() so that sizeof_g_packet :)> :) > computed using REGISTER_RAW_SIZE() instead of blindly set to :)> :) > DEPRECATED_REGISTER_BYTES. :)> :) > :)> :) > I'm assuming two things which I'm not sure are true: :)> :) > :)> :) > 1) REGISTER_RAW_SIZE() is usable for all targets now :)> :) > :)> :) > 2) REGISTER_RAW_SIZE() is valid when passed pseudo register. :)> :) > :)> :) > Ok to commit? :)> :) :)> :) Just a few tweaks. :)> :)> :)> :) > - /* Start out by having the remote protocol mimic the existing :)> :) > - behavour - just copy in the description of the register cache. */ :)> :) > - rs->sizeof_g_packet = DEPRECATED_REGISTER_BYTES; /* OK */ :)> :) > + rs->sizeof_g_packet = 0; :)> :) :)> :) For the moment it is safer to do: :)> :) :)> :) if (DEPRECATED_REGISTER_BYTES_P ()) :)> :) rs-> ... = ...; :)> :) else :)> :) rs-> ... = 0; :)> :)> Well, DEPRECATED_REGISTER_BYTES_P() doesn't seem to exist. :)> So there should need to be a change in gdbarch.sh I assume. :) :)Doh, sorry. Easier to just test for a non-zero value: :) :) if (DEPRECATED_REGISTER_BYTES == 0) :) :)With that yes, definitly approved. :) :)Andrew Ok. I've committed the attached. Ted Roth 2003-06-03 Theodore A. Roth * remote.c (init_remote_state): Compute sizeof_g_packet by accumulation of the size of all registers instead of blindly using DEPRECATED_REGISTER_BYTES. ---1463809535-575425996-1054701223=:16658 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="sizeof-g-packet-fix-3.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="sizeof-g-packet-fix-3.diff" Content-length: 2249 MjAwMy0wNi0wMyAgVGhlb2RvcmUgQS4gUm90aCAgPHRyb3RoQG9wZW5hdnIu b3JnPg0KDQoJKiByZW1vdGUuYyAoaW5pdF9yZW1vdGVfc3RhdGUpOiBDb21w dXRlIHNpemVvZl9nX3BhY2tldCBieSANCglhY2N1bXVsYXRpb24gb2YgdGhl IHNpemUgb2YgYWxsIHJlZ2lzdGVycyBpbnN0ZWFkIG9mIGJsaW5kbHkgdXNp bmcNCglERVBSRUNBVEVEX1JFR0lTVEVSX0JZVEVTLg0KDQpJbmRleDogcmVt b3RlLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zz L3NyYy9zcmMvZ2RiL3JlbW90ZS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24g MS4xMDANCmRpZmYgLXUgLXAgLXIxLjEwMCByZW1vdGUuYw0KLS0tIHJlbW90 ZS5jCTE3IE1heSAyMDAzIDA1OjU5OjU4IC0wMDAwCTEuMTAwDQorKysgcmVt b3RlLmMJMyBKdW4gMjAwMyAyMjo1OTowMCAtMDAwMA0KQEAgLTI2MSw5ICsy NjEsMTAgQEAgaW5pdF9yZW1vdGVfc3RhdGUgKHN0cnVjdCBnZGJhcmNoICpn ZGJhcg0KICAgaW50IHJlZ251bTsNCiAgIHN0cnVjdCByZW1vdGVfc3RhdGUg KnJzID0geG1hbGxvYyAoc2l6ZW9mIChzdHJ1Y3QgcmVtb3RlX3N0YXRlKSk7 DQogDQotICAvKiBTdGFydCBvdXQgYnkgaGF2aW5nIHRoZSByZW1vdGUgcHJv dG9jb2wgbWltaWMgdGhlIGV4aXN0aW5nDQotICAgICBiZWhhdm91ciAtIGp1 c3QgY29weSBpbiB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIHJlZ2lzdGVyIGNh Y2hlLiAgKi8NCi0gIHJzLT5zaXplb2ZfZ19wYWNrZXQgPSBERVBSRUNBVEVE X1JFR0lTVEVSX0JZVEVTOyAvKiBPSyAqLw0KKyAgaWYgKERFUFJFQ0FURURf UkVHSVNURVJfQllURVMgIT0gMCkNCisgICAgcnMtPnNpemVvZl9nX3BhY2tl dCA9IERFUFJFQ0FURURfUkVHSVNURVJfQllURVM7DQorICBlbHNlDQorICAg IHJzLT5zaXplb2ZfZ19wYWNrZXQgPSAwOw0KIA0KICAgLyogQXNzdW1lIGEg MToxIHJlZ251bTwtPnBudW0gdGFibGUuICAqLw0KICAgcnMtPnJlZ3MgPSB4 Y2FsbG9jIChOVU1fUkVHUyArIE5VTV9QU0VVRE9fUkVHUywgc2l6ZW9mIChz dHJ1Y3QgcGFja2V0X3JlZykpOw0KQEAgLTI3NCw4ICsyNzUsMTEgQEAgaW5p dF9yZW1vdGVfc3RhdGUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcg0KICAgICAg IHItPnJlZ251bSA9IHJlZ251bTsNCiAgICAgICByLT5vZmZzZXQgPSBSRUdJ U1RFUl9CWVRFIChyZWdudW0pOw0KICAgICAgIHItPmluX2dfcGFja2V0ID0g KHJlZ251bSA8IE5VTV9SRUdTKTsNCi0gICAgICAvKiAuLi5zaXplID0gUkVH SVNURVJfUkFXX1NJWkUgKHJlZ251bSk7ICovDQogICAgICAgLyogLi4ubmFt ZSA9IFJFR0lTVEVSX05BTUUgKHJlZ251bSk7ICovDQorDQorICAgICAgLyog Q29tcHV0ZSBwYWNrZXQgc2l6ZSBieSBhY2N1bXVsYXRpbmcgdGhlIHNpemUg b2YgYWxsIHJlZ2lzdGVycy4gKi8NCisgICAgICBpZiAoIURFUFJFQ0FURURf UkVHSVNURVJfQllURVMgPT0gMCkNCisgICAgICAgIHJzLT5zaXplb2ZfZ19w YWNrZXQgKz0gcmVnaXN0ZXJfc2l6ZSAoY3VycmVudF9nZGJhcmNoLCByZWdu dW0pOw0KICAgICB9DQogDQogICAvKiBEZWZhdWx0IG1heGltdW0gbnVtYmVy IG9mIGNoYXJhY3RlcnMgaW4gYSBwYWNrZXQgYm9keS4gTWFueQ0K ---1463809535-575425996-1054701223=:16658--