Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Theodore A. Roth" <troth@openavr.org>
To: Johannes Stezenbach <js@convergence.de>
Cc: Michael Snyder <msnyder@redhat.com>,  <gdb-patches@sources.redhat.com>
Subject: [RFA] (second rev) broken build using bison-1.75
Date: Wed, 06 Nov 2002 14:31:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0211061424090.12303-200000@knuth.amplepower.com> (raw)
In-Reply-To: <20021106220528.GA20359@convergence.de>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 611 bytes --]



On Wed, 6 Nov 2002, Johannes Stezenbach wrote:

:) Theodore A. Roth wrote:
:) >
:) > That looks much nicer and simpler than my fix. Do you have a reference to
:) > what the binutils people are doing so I can try to grok the fix?
:)
:) Yes:
:) http://sources.redhat.com/ml/binutils/2002-10/msg00230.html

Thanks. It's probably safe to assume Alan knows what he's doing.
(I hope ;-) I'm still not enlightened as to why it's the correct fix
though. Haven't paid my dues to the yacc gods yet.

Attached is a revised patch with Johannes suggested fix for the type clash
error.

Is this ok to commit now?

Ted Roth

[-- Attachment #2: Type: TEXT/PLAIN, Size: 3315 bytes --]

2002-11-06  Theodore A. Roth  <troth@openavr.org>

	* c-exp.y: Add missing semi-colons.
	* f-exp.y: Add missing semi-colons.
	* m2-exp.y: Add missing semi-colons.
	* p-exp.y: Add missing semi-colons.
	Add empty action to start rule to avoid a type clash error when
	building with bison >= 1.50.

Index: gdb/c-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/c-exp.y,v
retrieving revision 1.16
diff -u -r1.16 c-exp.y
--- gdb/c-exp.y	11 Oct 2002 14:02:37 -0000	1.16
+++ gdb/c-exp.y	6 Nov 2002 22:11:34 -0000
@@ -247,9 +247,11 @@
 /* Expressions, not including the comma operator.  */
 exp	:	'*' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_IND); }
+	;
 
 exp	:	'&' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_ADDR); }
+	;
 
 exp	:	'-' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_NEG); }
Index: gdb/f-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/f-exp.y,v
retrieving revision 1.8
diff -u -r1.8 f-exp.y
--- gdb/f-exp.y	3 Sep 2002 02:45:56 -0000	1.8
+++ gdb/f-exp.y	6 Nov 2002 22:11:34 -0000
@@ -241,9 +241,11 @@
 /* Expressions, not including the comma operator.  */
 exp	:	'*' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_IND); }
+	;
 
 exp	:	'&' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_ADDR); }
+	;
 
 exp	:	'-' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_NEG); }
@@ -283,6 +285,7 @@
 
 arglist :      substring
                         { arglist_len = 2;}
+	;
    
 arglist	:	arglist ',' exp   %prec ABOVE_COMMA
 			{ arglist_len++; }
Index: gdb/m2-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/m2-exp.y,v
retrieving revision 1.6
diff -u -r1.6 m2-exp.y
--- gdb/m2-exp.y	3 Sep 2002 02:45:56 -0000	1.6
+++ gdb/m2-exp.y	6 Nov 2002 22:11:35 -0000
@@ -216,6 +216,7 @@
 
 exp     :       exp '^'   %prec UNARY
                         { write_exp_elt_opcode (UNOP_IND); }
+	;
 
 exp	:	'-'
 			{ number_sign = -1; }
@@ -330,6 +331,7 @@
 
 exp	:	EXCL '(' exp ',' exp ')'
 			{ error("Sets are not implemented.");}
+	;
 
 set	:	'{' arglist '}'
 			{ error("Sets are not implemented.");}
Index: gdb/p-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/p-exp.y,v
retrieving revision 1.16
diff -u -r1.16 p-exp.y
--- gdb/p-exp.y	11 Oct 2002 14:02:38 -0000	1.16
+++ gdb/p-exp.y	6 Nov 2002 22:11:35 -0000
@@ -233,7 +233,8 @@
 start   :	{ current_type = NULL;
 		  search_field = 0;
 		}
-		normal_start;
+		normal_start {}
+	;
 
 normal_start	:
 		exp1
@@ -257,11 +258,13 @@
 			{ write_exp_elt_opcode (UNOP_IND);
 			  if (current_type) 
 			    current_type = TYPE_TARGET_TYPE (current_type); }
+	;
 
 exp	:	'@' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_ADDR); 
 			  if (current_type)
 			    current_type = TYPE_POINTER_TYPE (current_type); }
+	;
 
 exp	:	'-' exp    %prec UNARY
 			{ write_exp_elt_opcode (UNOP_NEG); }
@@ -317,6 +320,7 @@
 			  write_exp_elt_opcode (BINOP_SUBSCRIPT);
 			  if (current_type)
 			    current_type = TYPE_TARGET_TYPE (current_type); }
+	;
 
 exp	:	exp '('
 			/* This is to save the value of arglist_len

  reply	other threads:[~2002-11-06 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-06 13:38 [RFC] " Johannes Stezenbach
2002-11-06 13:57 ` Theodore A. Roth
2002-11-06 14:05   ` Johannes Stezenbach
2002-11-06 14:31     ` Theodore A. Roth [this message]
2002-11-06 14:41       ` [RFA] (second rev) " Michael Snyder
2002-11-06 14:57         ` Theodore A. Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0211061424090.12303-200000@knuth.amplepower.com \
    --to=troth@openavr.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=js@convergence.de \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox