From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16592 invoked by alias); 6 Nov 2002 15:13:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16585 invoked from network); 6 Nov 2002 15:13:54 -0000 Received: from unknown (HELO e4.ny.us.ibm.com) (32.97.182.104) by sources.redhat.com with SMTP; 6 Nov 2002 15:13:54 -0000 Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com [9.56.224.206]) by e4.ny.us.ibm.com (8.12.2/8.12.2) with ESMTP id gA6FDmYb220390; Wed, 6 Nov 2002 10:13:48 -0500 Received: from dmfet (dmfet.austin.ibm.com [9.53.216.34]) by northrelay04.pok.ibm.com (8.12.3/NCO/VER6.4) with ESMTP id gA6FDh5G195814; Wed, 6 Nov 2002 10:13:43 -0500 Received: from smoser (helo=localhost) by dmfet with local-esmtp (Exim 3.35 #1 (Debian)) id 189RsG-0000ik-00; Wed, 06 Nov 2002 09:13:44 -0600 Date: Wed, 06 Nov 2002 07:13:00 -0000 From: Scott Moser X-X-Sender: smoser@dmfet To: Jelmer Vernooij cc: Eli Zaretskii , Subject: Re: [PATCH] plugin patch In-Reply-To: <20021106145415.GA2350@charis.vernstok> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-11/txt/msg00097.txt.bz2 On Wed, 6 Nov 2002, Jelmer Vernooij wrote: > On Wed, Nov 06, 2002 at 08:45:18AM -0600, Scott Moser wrote about 'Re: [PATCH] plugin patch': > > > If my patch was submitted incorrectly, there was something else > > that I was missing, or anything else I'd need to change/update/add, > > please let me know. > One small suggestion; add some kind of version system for the plugins. > The API for plugins might change in the future and you don't want bug > reports from users complaining that gdb segfaults when they're trying > to load a plugin. We had the same thing when implementing this in > samba. While its not by any means ideal due to the changing format of the GDB version, the patch did have a method for a plugin to require a specific version of GDB. when the plugin is loaded, its passed the gdb version (from gdb/version.in). If it decides it can't work with that version, then it can return false and the plugin loader will say "failed to load". This way, the weight is on the plugin to decide if it can run or not, rather than GDB. Is that something like what you were looking for? > > Just my two eurocents, :-) > > jelmer > Scott Moser Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-1533 T/L: 678-1533 ssmoser@us.ibm.com , internal zip: 9812