From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19101-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 22069 invoked by alias); 30 Sep 2002 20:11:09 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 21981 invoked from network); 30 Sep 2002 20:11:08 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 30 Sep 2002 20:11:08 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g8UJqXi29038
	for <gdb-patches@sources.redhat.com>; Mon, 30 Sep 2002 15:52:33 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8UKB7f00818;
	Mon, 30 Sep 2002 16:11:07 -0400
Received: from valrhona.uglyboxes.com (IDENT:H2cf3inzDehacDN95rSiZf/TmBQZmq8c@vpn50-40.rdu.redhat.com [172.16.50.40])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8UKB6E05202;
	Mon, 30 Sep 2002 16:11:06 -0400
Date: Mon, 30 Sep 2002 13:11:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: "J. Johnston" <jjohnstn@redhat.com>
cc: gdb-patches@sources.redhat.com
Subject: Re: Patch for gdb/mi problem 672
In-Reply-To: <3D94DB49.BF3C3520@redhat.com>
Message-ID: <Pine.LNX.4.44.0209300936040.1514-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-09/txt/msg00775.txt.bz2

Hi,

Although I know that varobj shouldn't longjmp in case of errors, I don't 
think that this is going to be a safe assumption. I would recommend that 
you refrain from using ui_out_*_begin and ui_out_*_end, and instead use 
make_cleanup_ui_out_*_begin_end and do_cleanups, which will make sure that 
the UIOUT builder is properly reset in case of errors. (See, for example, 
the cleanup that I did in mi_cmd_data_list_registers.)

On Fri, 27 Sep 2002, J. Johnston wrote:

> @@ -419,10 +419,10 @@
>    if ((*name == '*') && (*(name + 1) == '\0'))
>      {
>        nv = varobj_list (&rootlist);
> -      ui_out_tuple_begin (uiout, "changelist");
> +      ui_out_list_begin (uiout, "changelist");
>        if (nv <= 0)
>  	{
> -	  ui_out_tuple_end (uiout);
> +	  ui_out_list_end (uiout);
>  	  return MI_CMD_DONE;
>  	}
>        cr = rootlist;

[Andrew has already addressed the MI0 thing...]

Other than that, I would recommend that it be approved (for whatever 
that's worth).

Keith