From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18990-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 24859 invoked by alias); 27 Sep 2002 14:49:29 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24830 invoked from network); 27 Sep 2002 14:49:27 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 27 Sep 2002 14:49:27 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g8REVEi27147
	for <gdb-patches@sources.redhat.com>; Fri, 27 Sep 2002 10:31:14 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8REnRf18260
	for <gdb-patches@sources.redhat.com>; Fri, 27 Sep 2002 10:49:27 -0400
Received: from valrhona.uglyboxes.com (IDENT:l9W+BtrQeL0d+aPEFS8xkTaHCs9lHdC4@vpn50-63.rdu.redhat.com [172.16.50.63])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8REnQJ21673
	for <gdb-patches@sources.redhat.com>; Fri, 27 Sep 2002 10:49:26 -0400
Date: Fri, 27 Sep 2002 07:49:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: gdb-patches@sources.redhat.com
Subject: Re: 5.3 branch?  Was: insight rename patch
In-Reply-To: <3D934851.3080304@redhat.com>
Message-ID: <Pine.LNX.4.44.0209270750050.1515-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-09/txt/msg00664.txt.bz2

On Thu, 26 Sep 2002, Andrew Cagney wrote:

> Committed to HEAD.....
> > 
> > Index: gdbtk/ChangeLog
> > 2002-09-25  Andrew Cagney  <ac131313@redhat.com>
> > 
> > 	From Grace Sainsbury <graces@redhat.com>:
> > 	* generic/gdbtk-main.c: New file.

FYI, I've committed a testsuite cleanup in 
testsuite/lib/insight-support.exp which will get it to run the "insight" 
executable instead of gdb.

Keith

ChangeLog
2002-09-26  Keith Seitz  <keiths@redhat.com>

        * lib/insight-support.exp (gdbtk_start): Figure out where
        the insight executable is based on where gdb is. Use this
        executable to start insight instead of gdb.

Patch
Index: testsuite/lib/insight-support.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/insight-support.exp,v
retrieving revision 1.5
diff -p -r1.5 insight-support.exp
*** testsuite/lib/insight-support.exp	4 Oct 2001 22:11:12 -0000	1.5
--- testsuite/lib/insight-support.exp	27 Sep 2002 14:47:14 -0000
*************** proc gdbtk_start {test} {
*** 54,60 ****
  
    gdb_stop_suppressing_tests;
  
!   verbose "Starting $GDB -nx -q --tclcommand=$test"
  
    set real_test [which $test]
    if {$real_test == 0} {
--- 54,68 ----
  
    gdb_stop_suppressing_tests;
  
!   # Need to convert ::GDB to use (-)?insight...
!   if {[regsub {gdb$} $GDB insight newGDB]} {
!     set INSIGHT $newGDB
!   } else {
!     perror "Cannot find Insight executable"
!     exit 1
!   }
! 
!   verbose "Starting $INSIGHT -nx -q --tclcommand=$test"
  
    set real_test [which $test]
    if {$real_test == 0} {
*************** proc gdbtk_start {test} {
*** 63,70 ****
    }
  
    if {![is_remote host]} {
!     if { [which $GDB] == 0 } {
!       perror "$GDB does not exist."
        exit 1
      }
    }
--- 71,78 ----
    }
  
    if {![is_remote host]} {
!     if { [which $INSIGHT] == 0 } {
!       perror "$INSIGHT does not exist."
        exit 1
      }
    }
*************** proc gdbtk_start {test} {
*** 91,99 ****
    set env(GDBTK_VERBOSE) 1
    set env(GDBTK_LOGFILE) [to_tcl_path [file join $objdir gdb.log]]
  
!   set err [catch {exec $GDB -nx -q --tclcommand=$test} res]
    if { $err } {
!     perror "Execing $GDB failed: $res"
      append res "\nERROR gdb-crash"
    }
    return $res
--- 99,107 ----
    set env(GDBTK_VERBOSE) 1
    set env(GDBTK_LOGFILE) [to_tcl_path [file join $objdir gdb.log]]
  
!   set err [catch {exec $INSIGHT -nx -q --tclcommand=$test} res]
    if { $err } {
!     perror "Execing $INSIGHT failed: $res"
      append res "\nERROR gdb-crash"
    }
    return $res