From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13182 invoked by alias); 30 Aug 2002 19:47:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13175 invoked from network); 30 Aug 2002 19:47:02 -0000 Received: from unknown (HELO valrhona.uglyboxes.com) (64.1.192.220) by sources.redhat.com with SMTP; 30 Aug 2002 19:47:01 -0000 Received: from localhost.localdomain (IDENT:uZu7c8jcQwEHIjSg5U3Ov79zR38u9KCa@localhost.localdomain [127.0.0.1]) by valrhona.uglyboxes.com (8.11.6/8.11.6) with ESMTP id g7UJnhS18568 for ; Fri, 30 Aug 2002 12:49:44 -0700 Date: Fri, 30 Aug 2002 12:57:00 -0000 From: Keith Seitz X-X-Sender: keiths@valrhona.uglyboxes.com To: gdb-patches@sources.redhat.com Subject: Re: [RFA] stack.c: Always set current_source_{symtab,line} In-Reply-To: <3D6FCA0F.8050407@ges.redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-08/txt/msg01046.txt.bz2 On Fri, 30 Aug 2002, Andrew Cagney wrote: > > Already in mi-cli.exp on the branch. (I think I submitted it, too, to this > > list.) The method is different, but it demonstrates the failure using > > "list" with the console interpreter. > > For MI, the testcase needs to go in at the same time as the fix (this is > stronger then the rest of GDB where it is a ``should''). It's also > important to check that the test actually fails without the fix. That > way we know that the change at least fixed something :-) Ok, but, as with all of this, it is IMPOSSIBLE to get this testcase to do anything UNTIL all the interps stuff is in. This bug only affects the command "-interpreter-exec console list". Well, this command doesn't yet exist in MI, because the infrastructure has not been approved for trunk. Yes, I have confirmed that there is a difference with and without the patch on my branch. mi-cli.exp shows an additional failure without the patch. I'm really at a loss about all this. Testcases, documentation, just about everything exists on the (public) branch. I can submit (and already did, in this case) a testcase to demonstrate the bug. The problem is that you can't run it at all in CVS head right now -- not until all the rest of the changes have been approved and committed. Help me out here. I'm obviously approaching the approval process incorrectly with these (relatively) small, one-at-a-time changes. Is there something I can do to facilitate review/approval of the mega-changes needed to support interpreters in gdb? Can I do something better? Is there a better process that I can follow? Keith