From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18107-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 31259 invoked by alias); 26 Aug 2002 19:04:23 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 31251 invoked from network); 26 Aug 2002 19:04:22 -0000
Received: from unknown (HELO valrhona.uglyboxes.com) (64.1.192.220)
  by sources.redhat.com with SMTP; 26 Aug 2002 19:04:22 -0000
Received: from localhost.localdomain (IDENT:8YYDP3nd8bH03embQvfSkA995d61nywW@localhost.localdomain [127.0.0.1])
	by valrhona.uglyboxes.com (8.11.6/8.11.6) with ESMTP id g7QJ6tY10966;
	Mon, 26 Aug 2002 12:06:55 -0700
Date: Mon, 26 Aug 2002 12:36:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender: keiths@valrhona.uglyboxes.com
To: Grace Sainsbury <graces@redhat.com>
cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] rename insight to insight
In-Reply-To: <20020826142957.A24152@tomago.toronto.redhat.com>
Message-ID: <Pine.LNX.4.44.0208261203180.1964-100000@valrhona.uglyboxes.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-08/txt/msg00857.txt.bz2

On Mon, 26 Aug 2002, Grace Sainsbury wrote:

> 2002-08-26  Grace Sainsbury  <graces@redhat.com>
> 
> 	* top.c: Set use_windows to default to zero.
> 	* main.c: Move main function to insight.c, gdb.c
> 	* insight.c: New File.
> 	* gdb.c: New File.
> 	* Makefile.in: Add rules for gdb.o, insight.o and insight. Change
> 	all, install and clean rules to include insight.

Recommendation:

Move "insight.c" into gdbtk/generic (call it insight-main.c or something) 
and move the Makefile fragments next to the other insight-related files 
(look for all the gdbtk-*.o files). This way we make an attempt at keeping 
insight/gdb cross-contamination to a minimum. We're slowly working toward 
putting all the insight stuff in gdb/gdbtk/, but we've still a little work 
to do (and your patch is a good first step at the most troublesome piece).

Otherwise, I certainly welcome this change (which is far too overdue). Now 
we only need to straighten out the arg parsing stuff and the init.c stuff, 
and we'll be set! ;-)

Keith