From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16719-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 2672 invoked by alias); 8 Jul 2002 20:40:28 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 2662 invoked from network); 8 Jul 2002 20:40:27 -0000
Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10)
  by sources.redhat.com with SMTP; 8 Jul 2002 20:40:27 -0000
Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2])
	by kerberos.suse.cz (SuSE SMTP server) with ESMTP
	id 6919259D351; Mon,  8 Jul 2002 22:40:26 +0200 (CEST)
Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2])
	by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g68KeQg27787;
	Mon, 8 Jul 2002 22:40:26 +0200
Date: Mon, 08 Jul 2002 13:46:00 -0000
From: Michal Ludvig <mludvig@suse.cz>
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] struct context moved
In-Reply-To: <3D29DA42.1060508@ges.redhat.com>
Message-ID: <Pine.LNX.4.33.0207082233090.27221-100000@chimera.suse.cz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-07/txt/msg00122.txt.bz2

On Mon, 8 Jul 2002, Andrew Cagney wrote:

> > Hi all,
> > the appended patch moved declaration of struct context and struct context_reg to frame.h, where these two are used in struct frame_info.
> > OK to commit?
> >
> > 2002-07-08  Michal Ludvig  <mludvig@suse.cz>
> >
> >     * dwarf2cfi.c (struct context, struct context_reg): Moved...
> >     * farme.h (struct context, struct context_reg): ...here.
> >
> > Michal Ludvig
>
> Michael,
>
> I don't understand the rationale behind this.
>
> As a general trend, frame.h / struct frame is becomming increasingly
> opaque.  I don't see a reason for moving dwarf2cfi specific stuff into
> frame.h.

Because we have
	struct context *context;
in the declaration of "struct frame_info", I thought it was logical to
declare "struct context" in the same file. Otherwise, when debugging gdb
itself, I'm getting "incomplete type" message when examining the content
of struct frame_info. AFAIK it doesn't increase the size of the code, it
just gives to debugger the appropriate information about the type of
the structure.

Or am I wrong?

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz