From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11626-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 31359 invoked by alias); 5 Jan 2002 15:44:08 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 31318 invoked from network); 5 Jan 2002 15:44:07 -0000
Received: from unknown (HELO dberlin.org) (64.246.6.106)
  by sources.redhat.com with SMTP; 5 Jan 2002 15:44:07 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
	by dberlin.org (8.11.6/8.11.6) with ESMTP id g05Fhv107409;
	Sat, 5 Jan 2002 10:43:57 -0500
Date: Sat, 05 Jan 2002 07:44:00 -0000
From: Daniel Berlin <dan@dberlin.org>
To: Eli Zaretskii <eliz@is.elta.co.il>
cc: <tromey@redhat.com>, <gdb-patches@sources.redhat.com>
Subject: Re: Patch: completion -vs- duplicates
In-Reply-To: <3596-Sat05Jan2002102225+0200-eliz@is.elta.co.il>
Message-ID: <Pine.LNX.4.33.0201051042460.7370-100000@dberlin.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-01/txt/msg00071.txt.bz2

On Sat, 5 Jan 2002, Eli Zaretskii wrote:

> > From: Tom Tromey <tromey@redhat.com>
> > Date: 04 Jan 2002 17:07:51 -0700
> > 
> > Right now the `complete' command can print duplicates.  readline seems
> > to filter these, so you don't see this using Tab in the CLI, but you
> > can see it in Insight or by using the complete command.
> 
> Hm... shouldn't Insight do the same as readline?
> 
> In my mind, GDB doesn't do any completion at all.  Completion is a
> feature of the UI; GDB just helps the UI by providing a function to
> call to get all the completion candidates.  The rest--how to display
> the candidates, whether to filter out duplicates, etc.--is up to the
> UI's completion machinery.  So conceptually, in my mind, the
> filtering doesn't belong in GDB.
> 
> Concepts aside, the change you suggest has also practical
> disadvantages: filtering duplicates in GDB's completion function would
> mean a performance hit in the CLI version, since readline will try to
> filter again.

Yes. I remember this was the huge lose that caused completion to take 
forever, which is why I removed the duplicate filtering.
I'm surprised you insight guys didn't notice then, actually.
--Dan