Re: [RFA/c++] Fix printing classes with virtual base classes

Daniel Jacobowitz
2001-11-30T06:41:29Z

Jim, can I commit these? It'll make it easier for me to post the
following batch. Now that GCC emits the information I need (on HEAD at
least) I'd like to finish this up.

I guess that I can commit the gnu-v3-abi bits on my own initiative,
since no one objected... actually, I guess the values stuff is
unmaintained too?

MAINTAINERS says:
If there is no maintainer for a given domain then the responsibility
falls to the head maintainer.
So I guess I need approval from one of Ye Divine Entities first.

[Would someone more familiar with the state of affairs than I
explicitly list the unmaintained parts in MAINTAINERS? Quite a few
things seem to have slipped down that path.]

On Tue, Nov 27, 2001 at 04:17:51PM -0500, Jim Blandy wrote:
>
> These are two independent fixes, right? I understand GDB may need
> them both before it works correctly; I'm asking if each of them is a
> correct change in its own right. If so, could you show me a test case
> that each change fixes?
>
> Daniel Jacobowitz <drow@mvista.com> writes:
> > 2001-11-26 Daniel Jacobowitz <drow@mvista.com>
> >
> > * values.c (value_primitive_field): Add embedded_offset to the
> > address of structure members.
> > * gnu-v3-abi.c (gnuv3_rtti_type): Cast to base type before
> > attempting to access vtable pointer. Set using_enc_p if we cast.
> > (gnuv3_virtual_fn_field): Call value_cast with structure rather than
> > structure pointer. Cast to base type before attempting to access
> > vtable pointer.
>

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer