Re: [RFA] deleting breakpoints inside of 'commands' [Repost]

Andrew Cagney
2001-09-24T18:52:00Z

>
> I've looked your patch over, and it looks correct to me. Having said
> that, I think that the correctness of this patch is much less obvious
> than the version that made a copy of the command chain associated with
> a breakpoint. I don't fault you for this; the changes in your current
> patch are somewhat more distributed which means that there's more code
> to consider (and more ways for something to get fouled up later on).

And guess what (sorry but this is funny :-) I suspect it does contain a
bug. Try:

break main
commands
delete NN
leak-memory
end

The command ``leak-memory'' is invalid and will lead to an error() call
and that will in turn long jump over the code that would free the list.

While the duplicate version contains the same bug, I suspect it is
easier to fix vis:

o duplicate list
o add list to a cleanup
o run command
o do cleanups

I suspect to do this with the non-duplicate version you'll need to add a
catch_exceptions() call (nee catch_errors()) and check the state of that
->execute variable to figure out what to do.

I do tend to agree with Kevin though. Some times simplicity is best.

Andrew