From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16087-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13338 invoked by alias); 5 Jun 2002 21:05:20 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13231 invoked from network); 5 Jun 2002 21:05:16 -0000
Received: from unknown (HELO ds9.reckziegel.com) (212.14.90.50)
  by sources.redhat.com with SMTP; 5 Jun 2002 21:05:16 -0000
Received: from localhost (chris@localhost)
	by ds9.reckziegel.com (8.9.3/8.9.3/SuSE Linux 8.9.3-0.1) with ESMTP id XAA10181;
	Wed, 5 Jun 2002 23:05:09 +0200
Date: Wed, 05 Jun 2002 14:05:00 -0000
From: Christian Groessler <chris@groessler.org>
X-Sender:  <chris@ds9.reckziegel.com>
To: Andrew Cagney <ac131313@cygnus.com>
cc: <gdb-patches@sources.redhat.com>
Subject: Re: [patch/rfc] Delete sim/z8k/list.c
In-Reply-To: <3CFA565A.2050609@cygnus.com>
Message-ID: <Pine.LNX.4.30.0206052302020.10179-100000@ds9.reckziegel.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-06/txt/msg00081.txt.bz2

On Sun, 2 Jun 2002, Andrew Cagney wrote:

> Following up the change:
>
> > 2002-05-07  Christian Groessler <chris@groessler.org>
> >> >
> >> >         * list.c: Regenerated with current opcodes/z8k-opc.h.
> >
> >>
> >> How do I do this?  I was thinking that the patch was too big but, if the
> >> bulk is generated then yes, it is ok.
> >
> >
> > It is generated. Edit sim/z8k/writecode.c and set the DIRTY_HACK
> > define to 1. I think it's not really needed anymore, but the old
> > list.c was generated with the same define.
> >
> > Then compile writecode.c (it will also be compiled if you build gdb
> > for z8k-coff) and do a "./writecode -m > list.c".
>
> The attached patch deletes sim/z8k/list.c instead [re]generating its
> contents each time writecode is run.  While it might make building the
> z8k simulator slower, I think it makes its maintenance much easier - one
> less generated file to contend with.

I agree.

> If no one sees problems, I'll commit it in a few days.  The files
> generated by writecode appear to be identical with/without the change
> (but only if the before case has a freshly re-generated list.c, er, hmm
> .... :-).

What do you mean by that? The old list.c was definately wrong (since
z8k-opc.h was changed).

I tried your patch, and it works for me. Please commit.

regards,
chris