Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jimmy Guo <guo@cup.hp.com>
To: Fernando Nasser <fnasser@cygnus.com>
Cc: Geoff Keating <geoffk@cygnus.com>, gdb-patches@sourceware.cygnus.com
Subject: (withdraw) Re: [RFA] dejagnu runtest.exp redundant testing
Date: Fri, 11 Aug 2000 19:17:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.10.10008111913130.780-100000@hpcll168.cup.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10008071129160.5575-100000@hpcll168.cup.hp.com>

I withdraw this patch.  g++ testing reviewed the problem with it -- when
${tool} contains ?*+ chars, TCL will choke on the regexp command below.

I'll post a replacement patch shortly after the new round of
verification on gdb and gcc / g++ testsuites.

- Jimmy

>2000-08-07	Jimmy Guo	<guo@cup.hp.com>
>
>	* runtest.exp: Eliminate from test_top_dirs entries that
>	cause redundant testing.  Entries picked up because of their
>	${tool} prefix under the real top dir with the ${tool} prefix
>	have been making dejagnu run tests under these entries twice,
>	since dejagnu treats all *.exp files under a given directory
>	tree as test files.
>
>*** runtest.exp.orig	Mon Aug  7 11:01:57 2000
>--- runtest.exp	Mon Aug  7 11:21:57 2000
>***************
>*** 1664,1669 ****
>--- 1664,1689 ----
>  	set test_top_dirs [lsort [getdirs -all ${srcdir} "${tool}*"]]
>  	if { ${test_top_dirs} == "" } {
>  	    set test_top_dirs ${srcdir}
>+ 	} else {
>+ 	    # JYG: For test tree layouts with ${tool} prefix on
>+ 	    # both a parent and a child directory, eliminate
>+ 	    # the child directory entry from test_top_dirs list.
>+ 	    # e.g. gdb.hp/gdb.base-hp/ would result in two entries
>+ 	    # in the list: gdb.hp, gdb.hp/gdb.base-hp.
>+ 	    # If the latter not eliminated, test files under
>+ 	    # gdb.hp/gdb.base-hp would be run twice, since test files
>+ 	    # are gathered from all sub-directories underneath a
>+ 	    # directory.
>+ 	    set temp_top_dirs ""
>+ 	    foreach dir "${test_top_dirs}" {
>+ 		if [regexp "${srcdir}/.*${tool}.*/.*${tool}" ${dir}] {
>+ 		    # skip this directory.
>+ 		    continue
>+ 		} else {
>+ 		    lappend temp_top_dirs ${dir}
>+ 		}
>+ 	    }
>+ 	    set test_top_dirs ${temp_top_dirs}
>  	}
>  	verbose "Top level testsuite dirs are ${test_top_dirs}" 2
>  	set testlist "";


  reply	other threads:[~2000-08-11 19:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <398C3E91.D0EDB934@cygnus.com>
2000-08-07 10:09 ` recent dejagnu changes Jimmy Guo
2000-08-07 11:00   ` [RFA] dejagnu runtest.exp *dir_to_run Jimmy Guo
2000-08-07 11:34     ` [RFA] dejagnu runtest.exp redundant testing Jimmy Guo
2000-08-11 19:17       ` Jimmy Guo [this message]
2000-08-14 11:02     ` [RFA] dejagnu runtest.exp *dir_to_run Jimmy Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10008111913130.780-100000@hpcll168.cup.hp.com \
    --to=guo@cup.hp.com \
    --cc=fnasser@cygnus.com \
    --cc=gdb-patches@sourceware.cygnus.com \
    --cc=geoffk@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox