Re: recent dejagnu changes

Geoff Keating
2000-08-08T11:29:00Z

> Date: Tue, 8 Aug 2000 10:16:06 -0700 (PDT)
> From: Jimmy Guo <guo@cup.hp.com>
> Cc: fnasser@cygnus.com, gdb-patches@sourceware.cygnus.com
>
> As part of the _approval_ process, I thought your input might be
> useful, hence the invitation for it ... I test my dejagnu patches with
> the GDB test tree. Given your firm response not to do so, I request
> that the patches be reviewed by the maintainer (and others who might wish
> to do so) ... if and when it's approved, I will commit it ... just like
> you value your time, I value mine as well!

I don't know how it works in GDB-land, but the GCC patch approval
process requires that you include in your message how it was tested.
Failure to test appropriately can cause your patch to be rejected. In
this case, since we already know the patch had problems with the GCC
testsuite, I would immediately reject any patch that doesn't say that
it was tested with the GCC testsuite.

So you can consider your patch pre-rejected.

dejagnu is shared between GDB, GCC, and binutils, just as BFD is
shared between binutils and GDB. For such shared code, it is
extremely impolite to make a change without testing it on all the
users.
--
- Geoffrey Keating <geoffk@cygnus.com>
From guo@cup.hp.com Tue Aug 08 12:12:00 2000
From: Jimmy Guo <guo@cup.hp.com>
To: Geoff Keating <geoffk@cygnus.com>
Cc: fnasser@cygnus.com, gdb-patches@sourceware.cygnus.com
Subject: Re: recent dejagnu changes
Date: Tue, 08 Aug 2000 12:12:00 -0000
Message-id: <Pine.LNX.4.10.10008081145170.12669-100000@hpcll168.cup.hp.com>
References: <200008081827.LAA06137@localhost.cygnus.com>
X-SW-Source: 2000-08/msg00155.html
Content-length: 1750

It looks to me that you are just happy in the patch back-out business
and waving hands post-mortem. I'd never thought asking for your input
is something that big of a deal! You came in, proceeding to back out a
change without any details, except for nonsences like "this will never
work", or "unwise" ... while I earnestly tried to get the best out of it
by working with you to understand what broke and trying to make sure it
wouldn't occur again. I guess you've spent more time in this thread
than simply be a bit more helpful and try the patch out ...

In principle I agree with your patch approval process ... in reality
would you say you've never encountered a case where it would be more
difficult for you to test something under certain configuration than
asking whoever raised the hand to try it out? So much for the spirit of
cooperation on this silly little dejagnu change ... no hard feelings at
my side if they are rejected, cause I'm happy with what I've fixed in my
environment, and I know this dejagnu problem won't bite me again.

- Jimmy

>I don't know how it works in GDB-land, but the GCC patch approval
>process requires that you include in your message how it was tested.
>Failure to test appropriately can cause your patch to be rejected. In
>this case, since we already know the patch had problems with the GCC
>testsuite, I would immediately reject any patch that doesn't say that
>it was tested with the GCC testsuite.
>
>So you can consider your patch pre-rejected.
>
>dejagnu is shared between GDB, GCC, and binutils, just as BFD is
>shared between binutils and GDB. For such shared code, it is
>extremely impolite to make a change without testing it on all the
>users.
>--
>- Geoffrey Keating <geoffk@cygnus.com>