From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47628-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25016 invoked by alias); 9 Feb 2007 20:46:38 -0000
Received: (qmail 25008 invoked by uid 22791); 9 Feb 2007 20:46:37 -0000
X-Spam-Check-By: sourceware.org
Received: from tamu-relay.tamu.edu (HELO tr-5-int.cis.tamu.edu) (165.91.22.121)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 20:46:30 +0000
Received: from localhost (localhost.tamu.edu [127.0.0.1]) 	by tr-5-int.cis.tamu.edu (Postfix) with ESMTP id A1842C94F4; 	Fri,  9 Feb 2007 14:46:28 -0600 (CST)
Received: from tr-5-int.cis.tamu.edu ([127.0.0.1])  by localhost (smtp-relay.tamu.edu [127.0.0.1]) (amavisd-new, port 10024)  with ESMTP id 11018-04-2; Fri,  9 Feb 2007 14:46:27 -0600 (CST)
Received: from postal.cs.tamu.edu (smtp.cs.tamu.edu [128.194.138.100]) 	by tr-5-int.cis.tamu.edu (Postfix) with ESMTP id 49369C94B4; 	Fri,  9 Feb 2007 14:46:27 -0600 (CST)
Received: from sun (sun.cs.tamu.edu [128.194.138.51]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by postal.cs.tamu.edu (Postfix) with ESMTP id 2408A46DE01; 	Fri,  9 Feb 2007 14:46:27 -0600 (CST)
Date: Fri, 09 Feb 2007 20:46:00 -0000
From: Gabriel Dos Reis <gdr@cs.tamu.edu>
To: Daniel Jacobowitz <dan@codesourcery.com>
cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: PATCH to gdb/ada-lang.c
In-Reply-To: <20070209202545.GA998@nevyn.them.org>
Message-ID: <Pine.GSO.4.58.0702091446100.11220@sun>
References: <8764ab4iy2.fsf@soliton.cs.tamu.edu> <20070209202527.GF3365@adacore.com>  <20070209202545.GA998@nevyn.them.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00148.txt.bz2

On Fri, 9 Feb 2007, Daniel Jacobowitz wrote:

| On Fri, Feb 09, 2007 at 12:25:27PM -0800, Joel Brobecker wrote:
| > Hello Gaby,
| >
| > Thanks for your patch.
| >
| > > 2007-02-09  Gabriel Dos Reis  <gdr@integrable-solutions.net>
| > >
| > > 	* ada-lang.c (remove_out_of_scope_renamings): Change third parameter's
| > > 	type to a pointer to const struct block.
| > > 	(ada_lookup_symbol_list): Don't cast away constness when calling
| > > 	remove_out_of_scope_renamings.
| >
| > I had a look, and although I cannot approve your change, I agree
| > with your conclusions and your patch.
|
| Good enough for me; is OK.

Many thanks to all of you.

-- Gaby