From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32154-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25169 invoked by alias); 7 Apr 2004 16:25:29 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25129 invoked from network); 7 Apr 2004 16:25:25 -0000
Received: from unknown (HELO esds.vss.fsi.com) (66.136.174.212)
  by sources.redhat.com with SMTP; 7 Apr 2004 16:25:25 -0000
Received: from thing1.vss.fsi.com (thing1.vss.fsi.com [198.51.29.21])
	by esds.vss.fsi.com (8.11.6+Sun/8.9.1) with ESMTP id i37GPMB04265
	for <gdb-patches@sources.redhat.com>; Wed, 7 Apr 2004 11:25:22 -0500 (CDT)
Received: from localhost (ford@localhost)
	by thing1.vss.fsi.com (8.11.6+Sun/8.11.6) with ESMTP id i37GPLP03627
	for <gdb-patches@sources.redhat.com>; Wed, 7 Apr 2004 11:25:22 -0500 (CDT)
X-Authentication-Warning: thing1-200.fsi.com: ford owned process doing -bs
Date: Wed, 07 Apr 2004 16:25:00 -0000
From: Brian Ford <ford@vss.fsi.com>
X-X-Sender: ford@thing1-200
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp)
In-Reply-To: <200404062324.i36NOeA9001063@elgar.kettenis.dyndns.org>
Message-ID: <Pine.GSO.4.58.0404071117430.1086@thing1-200>
References: <8011-Fri02Apr2004094123+0300-eliz@gnu.org> <Pine dot GSO dot 4
 dot 58 dot 0404021000390 dot 21204 at thing1-200> <2719-Fri02Apr2004213907+0300-eliz
 at gnu dot org> <Pine dot GSO dot 4 dot 58 dot 0404021648050 dot 21204 at
 thing1-200> <vt2ptam2gg1 dot fsf at zenia dot home>
 <Pine.GSO.4.58.0404051748340.21204@thing1-200>
 <200404062324.i36NOeA9001063@elgar.kettenis.dyndns.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2004-04/txt/msg00169.txt.bz2

On Wed, 7 Apr 2004, Mark Kettenis wrote:

> Brian Ford wrote:
>
>> I still propose we rename the _to_regnum functions, replacing
>> stabs and dwarf with dbx and svr4 to reduce confusion.  I'll be happy
>> to make a patch :-).
>
> Please do so.

Ok, I'm working this up and fixing all the misleading comments.  I do have
a stupid style question, though.  This bugs me:

if (a)
  return x;
else if (b)
  return y;
else
  return z;

Can that simply be:

if (a)
  return x;

if (b)
  return y;

return z;

?  I can't find any mention of this in the GNU coding standards.

Thanks.

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444