From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3066 invoked by alias); 6 Apr 2004 14:53:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3015 invoked from network); 6 Apr 2004 14:53:49 -0000 Received: from unknown (HELO esds.vss.fsi.com) (66.136.174.212) by sources.redhat.com with SMTP; 6 Apr 2004 14:53:49 -0000 Received: from thing1.vss.fsi.com (thing1.vss.fsi.com [198.51.29.21]) by esds.vss.fsi.com (8.11.6+Sun/8.9.1) with ESMTP id i36ErdB19301; Tue, 6 Apr 2004 09:53:39 -0500 (CDT) Received: from localhost (ford@localhost) by thing1.vss.fsi.com (8.11.6+Sun/8.11.6) with ESMTP id i36ErcJ12377; Tue, 6 Apr 2004 09:53:38 -0500 (CDT) X-Authentication-Warning: thing1-200.fsi.com: ford owned process doing -bs Date: Tue, 06 Apr 2004 14:53:00 -0000 From: Brian Ford X-X-Sender: ford@thing1-200 To: Jim Blandy cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp) In-Reply-To: Message-ID: References: <8011-Fri02Apr2004094123+0300-eliz@gnu.org> <2719-Fri02Apr2004213907+0300-eliz@gnu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004-04/txt/msg00139.txt.bz2 On Mon, 5 Apr 2004, Jim Blandy wrote: > Brian Ford writes: > > ... I still propose we rename the _to_regnum functions, replacing > > stabs and dwarf with dbx and svr4 to reduce confusion. I'll be happy to > > make a patch :-). > > I agree that would be better. > > (I should make it clear that I can't approve this patch. We need Mark > Kettenis's okay.) Ok, I'll submit a patch after this thread is resolved. > > On Mon, 5 Apr 2004, Jim Blandy wrote: > > > It's true that the comments for svr4_dbx_register_map in > > > > Just svr4_register_map (so noone gets confused). > > Really? I'm looking at revision 1.660 of gcc/config/i386/i386.c, like > 657: > > int const svr4_dbx_register_map[FIRST_PSEUDO_REGISTER] = > > Not to be "back-atcha" or anything like that; this is just such a maze > of twisty little... You are correct. I guess I was just having an off day and I got it stuck in my head wrong. > > > ... every i386 GCC configuration uses either dbx_register_map or > > > svr4_dbx_register_map for both debug formats. > > > > Agreed. I'm happy to stick with dbx_register_map on Cygwin for all debug > > formats if a version of my patch is accepted. DWARF 2 (and STABS) will > > work fine then. And, I'd be glad to help Eli sort through the > > ramifications, since his is just about the only target to be affected. > > Sounds great. Now we just need some words from Eli and an approval for your version of my patch, I think. -- Brian Ford Senior Realtime Software Engineer VITAL - Visual Simulation Systems FlightSafety International Phone: 314-551-8460 Fax: 314-551-8444