Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Brian Ford <ford@vss.fsi.com>
To: gdb-patches@sources.redhat.com
Subject: coff mixed debug formats
Date: Wed, 24 Mar 2004 00:22:00 -0000	[thread overview]
Message-ID: <Pine.GSO.4.58.0403231818210.17486@thing1-200> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 410 bytes --]

2004-03-23  Brian Ford  <ford@vss.fsi.com>

        * coffread.c (coff_symfile_read): Prevent mixed debugging formats from
        corrupting/reinitializing the psymtab like elf_symfile_read.
        * dbxread.c (elfstab_build_psymtabs): Remove bogus comment.

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444

[-- Attachment #2: Type: TEXT/PLAIN, Size: 2229 bytes --]

? coffmixeddebug.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.5602
diff -u -p -r1.5602 ChangeLog
--- ChangeLog	23 Mar 2004 21:21:36 -0000	1.5602
+++ ChangeLog	24 Mar 2004 00:17:03 -0000
@@ -1,3 +1,9 @@
+2004-03-23  Brian Ford  <ford@vss.fsi.com>
+
+	* coffread.c (coff_symfile_read): Prevent mixed debugging formats from
+	corrupting/reinitializing the psymtab like elf_symfile_read.
+	* dbxread.c (elfstab_build_psymtabs): Remove bogus comment.
+
 2004-03-23  Andrew Cagney  <cagney@redhat.com>
 
 	* MAINTAINERS (Past Maintainers): Add Mark Salter and Fernando
Index: coffread.c
===================================================================
RCS file: /cvs/src/src/gdb/coffread.c,v
retrieving revision 1.53
diff -u -p -r1.53 coffread.c
--- coffread.c	27 Feb 2004 17:46:11 -0000	1.53
+++ coffread.c	24 Mar 2004 00:17:03 -0000
@@ -610,6 +610,15 @@ coff_symfile_read (struct objfile *objfi
   /* Free the installed minimal symbol data.  */
   do_cleanups (cleanup_minimal_symbols);
 
+  /* If we are reinitializing, or if we have never loaded syms yet,
+     set table to empty.  MAINLINE is cleared so that *_read_psymtab
+     functions do not all also re-initialize the psymbol table. */
+  if (mainline)
+    {
+      init_psymbol_list (objfile, 0);
+      mainline = 0;
+    }
+
   bfd_map_over_sections (abfd, coff_locate_sections, (void *) info);
 
   if (info->stabsects)
Index: dbxread.c
===================================================================
RCS file: /cvs/src/src/gdb/dbxread.c,v
retrieving revision 1.64
diff -u -p -r1.64 dbxread.c
--- dbxread.c	14 Feb 2004 15:46:32 -0000	1.64
+++ dbxread.c	24 Mar 2004 00:17:07 -0000
@@ -3392,8 +3392,7 @@ coffstab_build_psymtabs (struct objfile 
 }
 \f
 /* Scan and build partial symbols for an ELF symbol file.
-   This ELF file has already been processed to get its minimal symbols,
-   and any DWARF symbols that were in it.
+   This ELF file has already been processed to get its minimal symbols.
 
    This routine is the equivalent of dbx_symfile_init and dbx_symfile_read
    rolled into one.

             reply	other threads:[~2004-03-24  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-24  0:22 Brian Ford [this message]
2004-03-24 22:09 ` Jim Blandy
2004-04-07 21:56   ` [patch ping/update] " Brian Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.58.0403231818210.17486@thing1-200 \
    --to=ford@vss.fsi.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox