From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23998 invoked by alias); 24 May 2002 22:38:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23985 invoked from network); 24 May 2002 22:38:15 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 24 May 2002 22:38:15 -0000 Received: from makita.cygnus.com (makita.sfbay.redhat.com [192.168.30.83]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA17213; Fri, 24 May 2002 15:38:14 -0700 (PDT) Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id PAA19835; Fri, 24 May 2002 15:38:14 -0700 (PDT) X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs Date: Fri, 24 May 2002 16:20:00 -0000 From: Keith Seitz X-X-Sender: To: Andrew Cagney cc: Subject: Re: [RFC] GDB interpreters In-Reply-To: <3CEEB81A.2010407@cygnus.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-05/txt/msg00907.txt.bz2 On Fri, 24 May 2002, Andrew Cagney wrote: > Do you have a [working] draft? It is hard to see how it hangs together > with out some additional context. Consider doing what I did and drop > the work in progress onto a branch. Yeah, I've got a massive set of changes that a compilation of this from Apple and some of my own changes. (Most of my own changes are just cosmetic: move things to separate files and whatnot. Apple crammed everything in mi-main.c) > The things I'm wondering about are: > > - how the ``struct gdb_interpreter'' gets called (can it be opaque?). > There is a comment talking about how it is tied into the event loop. These are completely opaque. Although Apple has a public definition of it in interpreter.h, I was going to move it into interpreter.c. The only way the code accessing this structure is via accessor functions (gdb_interpreter_display_prompt, gdb_interpreter_set_quiet, etc). > - what goes with hooks (I get the feeling that it is caught in the > middle between ..._hook and gdb-event*) Apple is using only hooks. It was my intent to swap it all to events, so that all of the events/hooks are located in one place. > Perhaphs consider a name other than interpreter.[hc]. Something to > reflect that this isn't ``the'' interpreter but rather a part of the > interpreters. terps? :-^ interps? Ok, I think that's valid: interps.h and interps.c (unless I hear otherwise). > > static struct gdb_interpreter *interp_list = NULL; > > static struct gdb_interpreter *current = NULL; > > Suggest ``current_interpreter''. Very good. > > static int initialized = 0; > > Same. Ok. > > > /* gdb_new_interpreter - This allocates space for a new interpreter, > > * fills the fields from the inputs, and returns a pointer to the > > * interpreter. */ > > I think it is ment to be: > > /* ..... > ..... */ > > i.e. no `*' on each line. Yes. Hmm. Does gdb_indent.sh catch this? I though I ran it on the files before submitting them. Oh well, no matter. I'll double check for this. Thanks for the comments. Keith