From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7066 invoked by alias); 13 Feb 2002 05:10:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7001 invoked from network); 13 Feb 2002 05:10:24 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 13 Feb 2002 05:10:24 -0000 Received: from makita.cygnus.com (makita.cygnus.com [205.180.230.78]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id VAA13744 for ; Tue, 12 Feb 2002 21:10:22 -0800 (PST) Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id VAA24074 for ; Tue, 12 Feb 2002 21:10:22 -0800 (PST) X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs Date: Tue, 12 Feb 2002 21:10:00 -0000 From: Keith Seitz X-X-Sender: To: Subject: [RFA] core_addr_string and core_addr_to_string_nz Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-02/txt/msg00346.txt.bz2 Hi, I would like to change the current core_addr_to_string and add a new core_add_to_string_nz so that these functions parallel the usage of phex and phex_nz. Since Insight is the only client for these, there are no test regressions anywhere. Keith ChangeLog 2002-02-12 Keith Seitz * defs.h (core_addr_to_string_nz): New function. * utils.c (core_addr_to_string): Use phex instead of phex_nz. (core_addr_to_string_nz): New function. Patch Index: defs.h =================================================================== RCS file: /cvs/src/src/gdb/defs.h,v retrieving revision 1.77 diff -p -r1.77 defs.h *** defs.h 2002/02/10 04:08:41 1.77 --- defs.h 2002/02/13 04:58:48 *************** extern char *phex_nz (ULONGEST l, int si *** 692,697 **** --- 692,698 ---- core_addr_to_string() can be passed direct to string_to_core_addr(). */ extern const char *core_addr_to_string (const CORE_ADDR addr); + extern const char *core_addr_to_string_nz (const CORE_ADDR addr); extern CORE_ADDR string_to_core_addr (const char *my_string); extern void fprintf_symbol_filtered (struct ui_file *, char *, Index: utils.c =================================================================== RCS file: /cvs/src/src/gdb/utils.c,v retrieving revision 1.63 diff -p -r1.63 utils.c *** utils.c 2002/02/10 04:08:42 1.63 --- utils.c 2002/02/13 04:58:49 *************** core_addr_to_string (const CORE_ADDR add *** 2476,2481 **** --- 2476,2490 ---- { char *str = get_cell (); strcpy (str, "0x"); + strcat (str, phex (addr, sizeof (addr))); + return str; + } + + const char * + core_addr_to_string_nz (const CORE_ADDR addr) + { + char *str = get_cell (); + strcpy (str, "0x"); strcat (str, phex_nz (addr, sizeof (addr))); return str; }