From: Keith Seitz <keiths@cygnus.com>
To: Fernando Nasser <fnasser@redhat.com>
Cc: <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] varobj.c: check wrapper return value
Date: Wed, 10 Oct 2001 10:02:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.33.0110101001500.2918-100000@makita.cygnus.com> (raw)
In-Reply-To: <3BC47BC7.E4556D90@redhat.com>
On Wed, 10 Oct 2001, Fernando Nasser wrote:
> Thanks. Please check it in the trunk.
Done. Thanks for the ultra-fast response!! What service!
Keith
> > ChangeLog
> > 2001-10-10 Keith Seitz <keiths@redhat.com>
> >
> > * varobj.c (cplus_value_of_child): Deal with a failure
> > to dereference a pointer object.
> >
> > Patch
> > Index: varobj.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/varobj.c,v
> > retrieving revision 1.20
> > diff -u -p -r1.20 varobj.c
> > --- varobj.c 2001/08/17 18:56:49 1.20
> > +++ varobj.c 2001/10/10 15:59:38
> > @@ -2313,7 +2313,10 @@ cplus_value_of_child (struct varobj *par
> >
> > if (TYPE_CODE (VALUE_TYPE (parent->value)) == TYPE_CODE_PTR
> > || TYPE_CODE (VALUE_TYPE (parent->value)) == TYPE_CODE_REF)
> > - gdb_value_ind (parent->value, &temp);
> > + {
> > + if (!gdb_value_ind (parent->value, &temp))
> > + return NULL;
> > + }
> > else
> > temp = parent->value;
>
> --
> Fernando Nasser
> Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario M4P 2C9
>
next prev parent reply other threads:[~2001-10-10 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-10 9:06 Keith Seitz
2001-10-10 9:52 ` Fernando Nasser
2001-10-10 10:02 ` Keith Seitz [this message]
2001-10-10 11:01 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.33.0110101001500.2918-100000@makita.cygnus.com \
--to=keiths@cygnus.com \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox