From: Keith Seitz <keiths@cygnus.com>
To: <gdb-patches@sources.redhat.com>
Subject: [RFC] Architecture change events
Date: Fri, 10 Aug 2001 13:50:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.33.0108101340340.20557-100000@makita.cygnus.com> (raw)
Hi,
I would like some advice for how to complete this patch for submission
into the repository.
The patch simply adds an "architecture_changed" event and notification.
Problem: we need to pass a thread id around with this, but my
understanding of gdb in this area is a little deficient. It's been a long
time.
So, how do I go about figuring out what thread id to pass along with this?
(Is there even a way to do this yet?)
I dunno. Help!
Keith
Here's what I'm looking at:
ChangeLog
2001-08-10 Keith Seitz <keiths@redhat.com>
* gdb-events.sh: Add architecture_changed event.
* gdbarch.sh: Include gdb-event.h.
(gdbarch_update_p): Notify UIs when architecture changes.
* gdb-events.h: Regenerated.
* gdb-events.c: Regenerated.
* gdbarch.c: Regenerated.
Almost complete patch (notice missing thread argument)
Index: gdb-events.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdb-events.sh,v
retrieving revision 1.10
diff -u -p -r1.10 gdb-events.sh
--- gdb-events.sh 2001/08/10 16:05:30 1.10
+++ gdb-events.sh 2001/08/10 20:40:03
@@ -64,6 +64,7 @@ f:void:breakpoint_modify:int b:b
f:void:tracepoint_create:int number:number
f:void:tracepoint_delete:int number:number
f:void:tracepoint_modify:int number:number
+f:void:architecture_changed:void
#*:void:annotate_starting_hook:void
#*:void:annotate_stopped_hook:void
#*:void:annotate_signalled_hook:void
Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.73
diff -u -p -r1.73 gdbarch.sh
--- gdbarch.sh 2001/07/10 21:24:48 1.73
+++ gdbarch.sh 2001/08/10 20:40:04
@@ -1129,6 +1129,7 @@ cat <<EOF
#include "floatformat.h"
#include "gdb_assert.h"
+#include "gdb-events.h"
/* Static function declarations */
@@ -2066,6 +2067,7 @@ gdbarch_update_p (struct gdbarch_info in
new_gdbarch->bfd_arch_info->printable_name);
current_gdbarch = new_gdbarch;
swapin_gdbarch_swap (new_gdbarch);
+ architecture_changed_event (/*thread??*/);
return 1;
}
}
@@ -2099,7 +2101,8 @@ gdbarch_update_p (struct gdbarch_info in
registered an interest in this architecture. CURRENT_GDBARCH
must be updated before these modules are called. */
init_gdbarch_data (new_gdbarch);
-
+ architecture_changed_event (/*thread??*/);
+
if (gdbarch_debug)
gdbarch_dump (current_gdbarch, gdb_stdlog);
next reply other threads:[~2001-08-10 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-10 13:50 Keith Seitz [this message]
2001-08-10 14:06 ` Andrew Cagney
2001-08-10 14:23 ` Keith Seitz
2001-08-10 16:48 ` Andrew Cagney
2001-08-10 17:41 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.33.0108101340340.20557-100000@makita.cygnus.com \
--to=keiths@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox