From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Seitz <keiths@cygnus.com>
To: <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] gdb-events.sh: event notifications w/o args
Date: Fri, 10 Aug 2001 09:05:00 -0000
Message-id: <Pine.GSO.4.33.0108100900140.17932-100000@makita.cygnus.com>
References: <3B738662.30601@cygnus.com>
X-SW-Source: 2001-08/msg00107.html

On Fri, 10 Aug 2001, Andrew Cagney wrote:

> Yes, ok (almost).  Can you just change the ``if'' to use the:
>
> 	if test ...
> 	then
> 	    ..
> 	fi
>
> rather than
>
> 	if test ...; then
> 	    ..
> 	fi
>
> so that it is consistent with the rest of the file (unless you can find
> a GNU SH SCRIPT coding standard which indicates otherwize :-).

Did I do that! Sheesh. Sorry.

For the record, I've committed this patch:

Index: gdb-events.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdb-events.sh,v
retrieving revision 1.9
diff -u -p -r1.9 gdb-events.sh
--- gdb-events.sh	2001/06/07 20:18:45	1.9
+++ gdb-events.sh	2001/08/10 16:03:11
@@ -419,11 +419,14 @@ function_list | while eval read $read
 do
   case "${class}" in
     "f" )
-      echo "struct ${function}"
-      echo "  {"
-      echo "    `echo ${formal} | tr '[,]' '[;]'`;"
-      echo "  };"
-      echo ""
+      if test ${actual}
+      then
+        echo "struct ${function}"
+        echo "  {"
+        echo "    `echo ${formal} | tr '[,]' '[;]'`;"
+        echo "  };"
+        echo ""
+      fi
       ;;
   esac
 done
@@ -441,7 +444,10 @@ function_list | while eval read $read
 do
   case "${class}" in
     "f" )
-      echo "        struct ${function} ${function};"
+      if test ${actual}
+      then
+        echo "        struct ${function} ${function};"
+      fi
       ;;
   esac
 done
@@ -517,15 +523,20 @@ do
   case "${class}" in
     "f" )
       echo "        case ${function}:"
-      echo "          vector->${function}"
-      sep="            ("
-      ass=""
-      for arg in `echo ${actual} | tr '[,]' '[:]' | tr -d '[ ]'`; do
-        ass="${ass}${sep}event->data.${function}.${arg}"
-	sep=",
-             "
-      done
-      echo "${ass});"
+      if test ${actual}
+      then
+        echo "          vector->${function}"
+        sep="            ("
+        ass=""
+        for arg in `echo ${actual} | tr '[,]' '[:]' | tr -d '[ ]'`; do
+          ass="${ass}${sep}event->data.${function}.${arg}"
+	  sep=",
+               "
+        done
+        echo "${ass});"
+      else
+        echo "          vector->${function} ();"
+      fi
       echo "          break;"
       ;;
   esac

> I'm also trying to remember if TR has any portability issues (not your
> problem but your patch reminded me :-)

It's always possible... FWIW, I checked the last patch I had on this file
(which did fiddle with tr) on many hosts, linux, hpux, aix,
solaris, cygwin, osf, and anything else I could get my hands on. It worked
(after much fiddling) on all of them.

Keith