Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "John R. Moore" <jmoore@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Fix to handle enums with values above LONG_MAX
Date: Thu, 10 May 2001 09:28:00 -0000	[thread overview]
Message-ID: <Pine.GSO.4.31.0105100923580.16086-100000@makita.cygnus.com> (raw)
In-Reply-To: <Pine.GSO.4.31.0105081000430.8166-100000@makita.cygnus.com>

Ok, this went on deaf ears... to illustrate, do the following:

------------------------- example.c ---------------------------
#include <stdio.h>

enum AAA
{
  a = 0x1,
  b = 0xFFFFFFFF,  /* If this is > LONG_MAX we core dump */
};

int
main ()
{
  unsigned int x = a;
  printf ("x = 0x%x\n", x);
}
----------------------- end example.c -------------------------

% gcc -g example.c -o example
% gdb -nw example
(gdb) print a
Segmentation fault (core dumped)
%

John Moore

On Tue, 8 May 2001, John R. Moore wrote:

>
> This fix has been tested on linux 2.4.4 kernel using gcc RedHat-2.97.
> Without this fix, gdb simply core-dumps.
>
>
> 2001-05-08  John Moore  <jmoore@redhat.com>
>
> 	* stabsread.c (read_huge_number): Fix to allow gdb to handle
> 	enums with unsigned long values above LONG_MAX.
>
> Index: gdb/stabsread.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/stabsread.c,v
> retrieving revision 2.178
> diff -p -u -r2.178 stabsread.c
> --- gdb/stabsread.c	2001/03/26 19:54:39	2.178
> +++ gdb/stabsread.c	2001/05/07 22:45:47
> @@ -4433,10 +4433,7 @@ read_huge_number (char **pp, int end, in
>        p++;
>      }
>
> -  if (os9k_stabs)
> -    upper_limit = ULONG_MAX / radix;
> -  else
> -    upper_limit = LONG_MAX / radix;
> +  upper_limit = ULONG_MAX / radix;
>
>    while ((c = *p++) >= '0' && c < ('0' + radix))
>      {
>
>
>


  reply	other threads:[~2001-05-10  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-08 10:05 John R. Moore
2001-05-10  9:28 ` John R. Moore [this message]
2001-05-10 10:04   ` Elena Zannoni
2001-05-11 13:08     ` Daniel Berlin
2001-06-12 10:47 ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.31.0105100923580.16086-100000@makita.cygnus.com \
    --to=jmoore@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox