From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20192 invoked by alias); 20 Apr 2004 16:30:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20174 invoked from network); 20 Apr 2004 16:30:36 -0000 Received: from unknown (HELO esds.vss.fsi.com) (66.136.174.212) by sources.redhat.com with SMTP; 20 Apr 2004 16:30:36 -0000 Received: from fordpc.vss.fsi.com (fordpc [198.51.27.93]) by esds.vss.fsi.com (8.11.6+Sun/8.9.1) with ESMTP id i3KGUTd22258; Tue, 20 Apr 2004 11:30:31 -0500 (CDT) Date: Tue, 20 Apr 2004 16:30:00 -0000 From: Brian Ford To: Mark Kettenis cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Proper _to_regnum for DWARF on Cygwin In-Reply-To: Message-ID: References: <200404161650.i3GGoPxI054716@elgar.kettenis.dyndns.org> <200404181838.i3IIccMf006115@elgar.kettenis.dyndns.org> <200404191959.i3JJxQoQ000336@elgar.kettenis.dyndns.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-1896639259-1082478622=:3620" X-SW-Source: 2004-04/txt/msg00465.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---559023410-1896639259-1082478622=:3620 Content-Type: TEXT/PLAIN; charset=US-ASCII Content-length: 2092 Oops, missed the comment refering to the removed function. Updated patch attached. ChangeLog unchanged from below. Ok to apply? On Mon, 19 Apr 2004, Brian Ford wrote: > On Mon, 19 Apr 2004, Mark Kettenis wrote: > > > Hmm. I very much agree with what Brian wrote in his follow-up > > messages. I think DJGPP is doing the right thing using the SVR4 > > scheme for DWARF2 while staying backwards compatible for stabs. I'd > > advise him to do the same for cygwin. > > Ok, do I need approval to revert my own patch ;-) ? > > 2004-04-19 Brian Ford > > Revert 2004-04-16 change. > * i386-tdep.c (i386_gdbarch_init): Fix comment typos. > (i386_coff_init_abi): Remove. > * i386-tdep.h (i386_coff_init_abi): Remove. > * i386-cygwin-tdep.c (i386_cygwin_init_abi): Remove call to above. > > > If i386_coff_init_abi will be gone, the comments aren't contradictiory > > anymore. > > Not exactly, as Eli pointed out before, both of the following will be > false for DJGPP and Cygwin/Mingw: > > Currently, each GCC i386 target always uses the same register > numbering scheme across all its supported debugging formats > i.e. SDB (COFF), stabs and DWARF 2. This is because > gcc/sdbout.c, gcc/dbxout.c and gcc/dwarf2out.c all use the > DBX_REGISTER_NUMBER macro which is defined by each target's > respective config header in a manner independent of the requested > output debugging format. > > > On Mon, 19 Apr 2004 at 08:50:59 +0200, Eli Zaretskii wrote: > > > >> On Sun, 18 Apr 2004 20:38:38 +0200 (CEST), Mark Kettenis wrote: > >> > >>>+ floating-point registers, and are implemented by the attays > >> ^^^^^^ > >> A typo. > > > > I though I'd fixed that one :-(. > > and another: > > implemented in dbx64_register_map, and us used for AMD64; see > ^^ > both of which are fixed in the attached patch. Ok to apply? -- Brian Ford Senior Realtime Software Engineer VITAL - Visual Simulation Systems FlightSafety International Phone: 314-551-8460 Fax: 314-551-8444 ---559023410-1896639259-1082478622=:3620 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="cygwin_revert_dwarf_regnum.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="cygwin_revert_dwarf_regnum.patch" Content-length: 4750 SW5kZXg6IGkzODYtdGRlcC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9pMzg2LXRkZXAuYyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTg3DQpkaWZmIC11IC1wIC1yMS4xODcgaTM4 Ni10ZGVwLmMNCi0tLSBpMzg2LXRkZXAuYwkxOCBBcHIgMjAwNCAxODozODow NCAtMDAwMAkxLjE4Nw0KKysrIGkzODYtdGRlcC5jCTIwIEFwciAyMDA0IDE2 OjE4OjM3IC0wMDAwDQpAQCAtMTc4MiwxNiArMTc4Miw2IEBAIGkzODZfc3Zy NF9zaWdjb250ZXh0X2FkZHIgKHN0cnVjdCBmcmFtZV8NCiB9DQogDA0KIA0K LS8qIEdlbmVyaWMgQ09GRi4gICovDQotDQotdm9pZA0KLWkzODZfY29mZl9p bml0X2FiaSAoc3RydWN0IGdkYmFyY2hfaW5mbyBpbmZvLCBzdHJ1Y3QgZ2Ri YXJjaCAqZ2RiYXJjaCkNCi17DQotICAvKiBXZSB0eXBpY2FsbHkgdXNlIERX QVJGLWluLUNPRkYgd2l0aCB0aGUgZGJ4IHJlZ2lzdGVyIG51bWJlcmluZy4g ICovDQotICBzZXRfZ2RiYXJjaF9kd2FyZl9yZWdfdG9fcmVnbnVtIChnZGJh cmNoLCBpMzg2X2RieF9yZWdfdG9fcmVnbnVtKTsNCi0gIHNldF9nZGJhcmNo X2R3YXJmMl9yZWdfdG9fcmVnbnVtIChnZGJhcmNoLCBpMzg2X2RieF9yZWdf dG9fcmVnbnVtKTsNCi19DQotDQogLyogR2VuZXJpYyBFTEYuICAqLw0KIA0K IHZvaWQNCkBAIC0xOTk1LDEyICsxOTg1LDEyIEBAIGkzODZfZ2RiYXJjaF9p bml0IChzdHJ1Y3QgZ2RiYXJjaF9pbmZvIGkNCiAgIC8qIE5PVEU6IGtldHRl bmlzLzIwMDQwNDE4OiBHQ0MgZG9lcyBoYXZlIHR3byBwb3NzaWJsZSByZWdp c3Rlcg0KICAgICAgbnVtYmVyaW5nIHNjaGVtZXMgb24gdGhlIGkzODY6IGRi eCBhbmQgU1ZSNC4gIFRoZXNlIHNjaGVtZXMNCiAgICAgIGRpZmZlciBpbiBo b3cgdGhleSBudW1iZXIgJWVicCwgJWVzcCwgJWVmbGFncywgYW5kIHRoZQ0K LSAgICAgZmxvYXRpbmctcG9pbnQgcmVnaXN0ZXJzLCBhbmQgYXJlIGltcGxl bWVudGVkIGJ5IHRoZSBhdHRheXMNCisgICAgIGZsb2F0aW5nLXBvaW50IHJl Z2lzdGVycywgYW5kIGFyZSBpbXBsZW1lbnRlZCBieSB0aGUgYXJyYXlzDQog ICAgICBkYnhfcmVnaXN0ZXJfbWFwW10gYW5kIHN2cjRfZGJ4X3JlZ2lzdGVy X21hcCBpbg0KICAgICAgZ2NjL2NvbmZpZy9pMzg2LmMuICBHQ0MgYWxzbyBk ZWZpbmVzIGEgdGhpcmQgbnVtYmVyaW5nIHNjaGVtZSBpbg0KICAgICAgZ2Nj L2NvbmZpZy9pMzg2LmMsIHdoaWNoIGl0IGRlc2lnbmF0ZXMgYXMgdGhlICJk ZWZhdWx0IiByZWdpc3Rlcg0KICAgICAgbWFwIHVzZWQgaW4gNjRiaXQgbW9k ZS4gIFRoaXMgbGFzdCByZWdpc3RlciBudW1iZXJpbmcgc2NoZW1lIGlzDQot ICAgICBpbXBsZW1lbnRlZCBpbiBkYng2NF9yZWdpc3Rlcl9tYXAsIGFuZCB1 cyB1c2VkIGZvciBBTUQ2NDsgc2VlDQorICAgICBpbXBsZW1lbnRlZCBpbiBk Yng2NF9yZWdpc3Rlcl9tYXAsIGFuZCBpcyB1c2VkIGZvciBBTUQ2NDsgc2Vl DQogICAgICBhbWQ2NC10ZGVwLmMuDQogDQogICAgICBDdXJyZW50bHksIGVh Y2ggR0NDIGkzODYgdGFyZ2V0IGFsd2F5cyB1c2VzIHRoZSBzYW1lIHJlZ2lz dGVyDQpAQCAtMjAxOSw4ICsyMDA5LDggQEAgaTM4Nl9nZGJhcmNoX2luaXQg KHN0cnVjdCBnZGJhcmNoX2luZm8gaQ0KICAgICAgbmF0aXZlIGNvbXBpbGVy IChGcmVlQlNELCBOZXRCU0QsIE9wZW5CU0QsIEdOVS9MaW51eCkgb3IgZm9y DQogICAgICB0YXJnZXRzIHdoZXJlIHRoZSBuYXRpdmUgdG9vbGNoYWluIHVz ZXMgYSBkaWZmZXJlbnQgbnVtYmVyaW5nDQogICAgICBzY2hlbWUgZm9yIGEg cGFydGljdWxhciBkZWJ1ZyBmb3JtYXQgKHN0YWJzLWluLUVMRiBvbiBTb2xh cmlzKQ0KLSAgICAgdGhlIGRlZmF1bHRzIGJlbG93IHdpbGwgaGF2ZSB0byBi ZSBvdmVycmlkZGVuLCBsaWtlIHRoZSBmdW5jdGlvbnMNCi0gICAgIGkzODZf Y29mZl9pbml0X2FiaSgpIGFuZCBpMzg2X2VsZl9pbml0X2FiaSgpIGRvLiAg Ki8NCisgICAgIHRoZSBkZWZhdWx0cyBiZWxvdyB3aWxsIGhhdmUgdG8gYmUg b3ZlcnJpZGRlbiwgbGlrZQ0KKyAgICAgaTM4Nl9lbGZfaW5pdF9hYmkoKSBk b2VzLiAgKi8NCiANCiAgIC8qIFVzZSB0aGUgZGJ4IHJlZ2lzdGVyIG51bWJl cmluZyBzY2hlbWUgZm9yIHN0YWJzIGFuZCBDT0ZGLiAgKi8NCiAgIHNldF9n ZGJhcmNoX3N0YWJfcmVnX3RvX3JlZ251bSAoZ2RiYXJjaCwgaTM4Nl9kYnhf cmVnX3RvX3JlZ251bSk7DQpJbmRleDogaTM4Ni10ZGVwLmgNCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2kz ODYtdGRlcC5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4zOQ0KZGlmZiAt dSAtcCAtcjEuMzkgaTM4Ni10ZGVwLmgNCi0tLSBpMzg2LXRkZXAuaAkxNiBB cHIgMjAwNCAxNjo0OTo1NSAtMDAwMAkxLjM5DQorKysgaTM4Ni10ZGVwLmgJ MjAgQXByIDIwMDQgMTY6MTg6MzcgLTAwMDANCkBAIC0yMTAsOSArMjEwLDYg QEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCByZWdzZXQgKg0KICAgaTM4Nl9yZWdz ZXRfZnJvbV9jb3JlX3NlY3Rpb24gKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNo LA0KIAkJCQkgY29uc3QgY2hhciAqc2VjdF9uYW1lLCBzaXplX3Qgc2VjdF9z aXplKTsNCiANCi0vKiBJbml0aWFsaXplIGEgYmFzaWMgQ09GRiBhcmNoaXRl Y3R1cmUgdmFyaWFudC4gICovDQotZXh0ZXJuIHZvaWQgaTM4Nl9jb2ZmX2lu aXRfYWJpIChzdHJ1Y3QgZ2RiYXJjaF9pbmZvLCBzdHJ1Y3QgZ2RiYXJjaCAq KTsNCi0NCiAvKiBJbml0aWFsaXplIGEgYmFzaWMgRUxGIGFyY2hpdGVjdHVy ZSB2YXJpYW50LiAgKi8NCiBleHRlcm4gdm9pZCBpMzg2X2VsZl9pbml0X2Fi aSAoc3RydWN0IGdkYmFyY2hfaW5mbywgc3RydWN0IGdkYmFyY2ggKik7DQog DQpJbmRleDogaTM4Ni1jeWd3aW4tdGRlcC5jDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9pMzg2LWN5Z3dp bi10ZGVwLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjQNCmRpZmYgLXUg LXAgLXIxLjQgaTM4Ni1jeWd3aW4tdGRlcC5jDQotLS0gaTM4Ni1jeWd3aW4t dGRlcC5jCTE2IEFwciAyMDA0IDE2OjQ5OjU1IC0wMDAwCTEuNA0KKysrIGkz ODYtY3lnd2luLXRkZXAuYwkyMCBBcHIgMjAwNCAxNjoxODozNyAtMDAwMA0K QEAgLTMxLDggKzMxLDYgQEAgaTM4Nl9jeWd3aW5faW5pdF9hYmkgKHN0cnVj dCBnZGJhcmNoX2luZg0KIHsNCiAgIHN0cnVjdCBnZGJhcmNoX3RkZXAgKnRk ZXAgPSBnZGJhcmNoX3RkZXAgKGdkYmFyY2gpOw0KIA0KLSAgaTM4Nl9jb2Zm X2luaXRfYWJpIChpbmZvLCBnZGJhcmNoKTsNCi0NCiAgIHRkZXAtPnN0cnVj dF9yZXR1cm4gPSByZWdfc3RydWN0X3JldHVybjsNCiB9DQogDQo= ---559023410-1896639259-1082478622=:3620--