From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4562 invoked by alias); 25 Feb 2004 09:22:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4553 invoked from network); 25 Feb 2004 09:22:11 -0000 Received: from unknown (HELO mudkip.internal.custodix.com) (193.121.186.60) by sources.redhat.com with SMTP; 25 Feb 2004 09:22:11 -0000 Received: from snorlax.internal.custodix.com (snorlax.internal.custodix.com [10.32.2.14]) by mudkip.internal.custodix.com (8.12.9/8.12.9) with ESMTP id i1P9M6Fn023376; Wed, 25 Feb 2004 10:22:06 +0100 (CET) Received: from localhost (dlucq@localhost) by snorlax.internal.custodix.com (8.12.9/8.12.9/Submit) with ESMTP id i1P9M6OX022413; Wed, 25 Feb 2004 10:22:06 +0100 (CET) Date: Wed, 25 Feb 2004 09:22:00 -0000 From: Daniel Lucq X-X-Sender: dlucq@snorlax.internal.custodix.com To: Michael Snyder cc: gdb-patches@sources.redhat.com Subject: Re: exec_file_hook_count data-type In-Reply-To: <403BD111.3060909@redhat.com> Message-ID: References: <403BD111.3060909@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004-02/txt/msg00725.txt.bz2 On Tue, 24 Feb 2004, Michael Snyder wrote: > Looks good. I won't demand that you use "unsigned int", but I'd > like it. I don't think it's covered by the coding standard, but > it seems to be the norm within gdb code (with exceptions), and in > my old age I find consistency comforting. ;-) OK, I concur whole-heartedly :-). Re-attached with "unsigned int" instead of "int"... Regards, Daniel Lucq --- corefile.c.orig Sun Feb 22 19:44:17 2004 +++ corefile.c Sun Feb 22 19:45:18 2004 @@ -53,7 +53,7 @@ hook_type exec_file_display_hook; /* the original hook */ static hook_type *exec_file_extra_hooks; /* array of additional hooks */ -static int exec_file_hook_count = 0; /* size of array */ +static unsigned int exec_file_hook_count = 0; /* size of array */ /* Binary file diddling handle for the core file. */ @@ -86,7 +86,7 @@ static void call_extra_exec_file_hooks (char *filename) { - int i; + unsigned int i; for (i = 0; i < exec_file_hook_count; i++) (*exec_file_extra_hooks[i]) (filename);