From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1078 invoked by alias); 29 Nov 2005 02:34:48 -0000 Received: (qmail 1071 invoked by uid 22791); 29 Nov 2005 02:34:48 -0000 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.31) with SMTP; Tue, 29 Nov 2005 02:34:47 +0000 Received: (qmail 86902 invoked by uid 20157); 29 Nov 2005 02:34:45 -0000 Date: Tue, 29 Nov 2005 13:03:00 -0000 From: Hans-Peter Nilsson To: Mark Mitchell cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: PATCH: Use target values for signals in simulator In-Reply-To: <438B5AC8.1050700@codesourcery.com> Message-ID: References: <20051123185806.29594.qmail@mail.codesourcery.com> <20051125182514.GG736@nevyn.them.org> <43875A5A.3060808@codesourcery.com> <20051128153706.GA31595@nevyn.them.org> <438B5AC8.1050700@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00496.txt.bz2 On Mon, 28 Nov 2005, Mark Mitchell wrote: > Daniel Jacobowitz wrote: > > > OK with that change. > > Here's the version I checked in, for the record. (Sent as attachment, so I can't quote in pine...) Something went generally wrong. For cris-elf, I see (cutnpaste): gcc -c /home/hp/combined/combined/sim/cris/../common/sim-signal.c -DHAVE_CONFIG_H -DWITH_DEFAULT_MODEL='"crisv32"' -DPROFILE=1\ -DWITH_PROFILE=-1 -DWITH_ALIGNMENT=NONSTRICT_ALIGNMENT -DWITH_ENVIRONMENT=ALL_ENVIRONMENT -DWITH_HOST_BYTE_ORDER=LITTLE_EN\ DIAN -DWITH_SCACHE=16384 -I. -I/home/hp/combined/combined/sim/cris -I../common -I/home/hp/combined/combined/sim/cris\ /../common -I../../include -I/home/hp/combined/combined/sim/cris/../../include -I../../bfd -I/home/hp/combined/combined/sim/cris/\ ../../bfd -I../../opcodes -I/home/hp/combined/combined/sim/cris/../../opcodes -I../../intl -I/home/hp/combined/combined/sim/cris/\ ../../intl -g -O2 /home/hp/combined/combined/sim/common/sim-signal.c:100: error: conflicting types for `sim_signal_to_target' /home/hp/combined/combined/sim/common/sim-signal.h:50: error: previous declaration of `sim_signal_to_target' /home/hp/combined/combined/sim/common/sim-signal.c: In function `sim_signal_to_target': /home/hp/combined/combined/sim/common/sim-signal.c:119: error: syntax error before "return" make[5]: *** [sim-signal.o] Error 1 To wit: sim-signal.h: enum target_signal sim_signal_to_target (SIM_DESC sd, SIM_SIGNAL); sim-signal.c: int sim_signal_to_target (SIM_DESC sd, SIM_SIGNAL sig) I guess you attached and committed the wrong version. There's an obvious syntax error; missing ":" on one case line, see above. brgds, H-P