From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EeTvB2HqVGqKNwYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 09:38:41 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nZT1r8ZB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1C48F1E033; Mon, 13 Jul 2026 09:38:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 83F7F1E033 for ; Mon, 13 Jul 2026 09:38:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87D524BA2E10 for ; Mon, 13 Jul 2026 13:38:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87D524BA2E10 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nZT1r8ZB Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazlp170120007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c101::7]) by sourceware.org (Postfix) with ESMTPS id D0D894BA5435 for ; Mon, 13 Jul 2026 13:38:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0D894BA5435 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0D894BA5435 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c101::7 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783949891; cv=pass; b=tEpCxK69yvbzNlpNwvcqe7NFriREnW6kNfrb1lF/oh0fFVRBL33W68utdZQ0uepB5xk+UZlsBl2gfVo3s9l91y0wj9N2lXU8PuM848XzmuRPfoAMawxBoa18o0qoUMC/uvm7PgA3nvC7GIifbybnIZvm4NBbiXm7TNNULMHaCiU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783949891; c=relaxed/simple; bh=0ioGSMnY16I+g1D2kp/YonGW0LcVig6zKhZvXcAMvzE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ky0L5UzKzEddx/MipTq+yjp4/ZOD5lUq9UwDdddLQfiqOuaoWEH630eb0BnvGjcgbbvaTBRP+g/0l8svIMDZA7PFzS9YhLptTWoTAbfVc33p/fycaR2PWgZ4WFQnhsp8vl4JsCxNjTktP9uw3+fIBJTyCLjsch/LTAYEmy7ddq0= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=nZT1r8ZB DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0D894BA5435 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fv5F9lPcHNhKcIpb4i+oSsixmMTjcqniHrldwX7mY06JY9U+9NbatQj2yWg7xilUlk1PBFzsP4oXdL9QAzQx+sRIE4PtM8qkE7d3F9pAMqJDavpblHct0PDOYsp9D/5o1BzpsGIbBG6qqDF0502ymL8S7N7FW5MyVL7aTDX/+vTLhG6dFMIT9mzsao8PtrWj6REu1cuhT+kT/rP1bn0ZovfFiuauKr//eU1A5LMIqM25Te9iG4Qkq81p02dhT1mZjkhPcdBsu7E2/hKvEMyjmuwotWkBMTZoGG2MRgW+6rcU3+PGX++vZymiuHpFiQpYcuShdaV9bnHNfjhm17u+hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0TUFVjEmLTYwqkcFb/Jk6pUuROfRFq2/hGXdsF4DKAw=; b=RgB5ykWQQqqIkDbxMNWRQj3Pv12B5PxaqcY1dMsRK6O+OGPqs9tCtEBObBqv9L3BOh7zQ7QG9S9TsStKgzezFKvF9KnkhnYTqFQxlTmPVG6Rkvg1yOtTki88TTY6LrXZt8XhFiCiEHJjCs+bB4HppEpp17FCEAhD2gyKVLf6ACmmPQSzh2lZvayzVpSic3ERAArJk8sguRagfOi+V/SmHotWfDx1yRH4EgtzSjSKRegUSNz3/4OoycGx7UR3Nw/eOwftr0ax2/7KZmMK0Ccj4pr5xmG2JQPIf02F0cFjk0+mP/OLmDO7dwohlRrSFa7Hs7oIj/FhfXJhmxwbhpY9hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0TUFVjEmLTYwqkcFb/Jk6pUuROfRFq2/hGXdsF4DKAw=; b=nZT1r8ZB6OGC4Qnle4hTok/+1mKeDvEEXU7yv38f8XJ1QEc7Gz6xS3I1uDdxAe9ede22DKm011kUiQVAs2fpXbYMY6Ow1lOntu1QllG71/Awfye/5ZS4eFxUtfQZTURpw34kpgpWMp52UhkTBrz6qOwi65jw2vTq/tAO+j4IwG0= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by CH1PR12MB9624.namprd12.prod.outlook.com (2603:10b6:610:2b3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 13:37:59 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::df2a:814c:6046:48b]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::df2a:814c:6046:48b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:37:57 +0000 From: "Aktemur, Baris" To: "srinath.parvathaneni@arm.com" , "gdb-patches@sourceware.org" CC: "guinevere@redhat.com" , "thiago.bauermann@linaro.org" , "luis.machado.foss@gmail.com" , "Ezra.Sitorus@arm.com" Subject: RE: [PATCH v1] gdb: Fix assignment to TYPE_CODE_FLAGS registers Thread-Topic: [PATCH v1] gdb: Fix assignment to TYPE_CODE_FLAGS registers Thread-Index: AQHdEqgADQyzLkPqREGmM1TXpt/Yv7Zrcwzw Date: Mon, 13 Jul 2026 13:37:57 +0000 Message-ID: References: <20260713091126.2914903-1-srinath.parvathaneni@arm.com> In-Reply-To: <20260713091126.2914903-1-srinath.parvathaneni@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-13T13:33:24.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|CH1PR12MB9624:EE_ x-ms-office365-filtering-correlation-id: 0b2b97de-9ed0-4f74-6e8b-08dee0e3f344 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|38070700021|11063799006|56012099006|18002099003|22082099003; x-microsoft-antispam-message-info: KYJNZzX2zX5bKGCxnyGJdQtB74MPxi0Zam1++TnRb3Ni1TzTQhVJNSq5hKzVT559f3Qd374/uFicl6p+f+ytmBDPwebtOdgkrkhJh0X07asiEpVr/ph3JyFe9RVqSPB8n7F53+r/lBU16ymu95JTiZAaXF5vp4PPCX7iFmczrmMzvADQWB7mHQXVUnJuLu4TM0tu72pgJIPJbq9HDaA5wLJ5yDlk8hGcA+dLrgvYuqFI2ivBMVaXBuDec/xnsjTxoKLphL7h0jI7SVIuVVuGHcne86t7mZDrlq5SktC2n1Y87PQY5YeSYnKS29zB5H50h30mBOA98wG6n8Y6o94aZYYQZYWNG2rkeP7CcnVqbvqWR1SK7Lb4de7v493xAwOkEg91Nd+ldvjRfxRjt9o8Sf+RO+2ZkDa6NkSwGIOm+cy+jD1Sa4LSg10po6lpkvPefjdiG4+WDecq02xFepHR3wfzBQk5WpGjhXEcAwvC5KDGY8bX76ZrLj7YkGNhw2tfMSJjxZrekOy+uAPGKe5nLzz8Vj+A9X2Fl+3LEvXicXYkuC+J23+ANjipqlz+z3dpG2hGmvs3zzGuwMH0uA57ExK6TzUnfVE+G/D1+0XiGNBmIDxjtpSzee19ic1DuojIOv/MZ2PLwNUHssrpidQCOyh3JkL4sdlThBh7orYNrXmE03pbemoeJXgXTWOM2KxdFhbdNCmxsiQV8FyQpr+eyoL2Tc3G/pUoOpG1k89shy4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB6466.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(38070700021)(11063799006)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eBFAPewLveseFuPqDIGxU9Y99V61MAIoJ4KBqHLrkvID1p9hTYFCqbcDkeX7?= =?us-ascii?Q?RelYzdSXCw+hJ8PKSlDgLEr0YBca8bISzHIkUyfcRec8ipkBTi2ix4ZqOHbJ?= =?us-ascii?Q?q6w3ODdK9lK1+gOiTVPvKVrG7cHPH/4X19eaNNlY4owSdZpNzmXucaCTO7tF?= =?us-ascii?Q?M+QDNePawngJow5TXXGsSL7bUxbSEmYa1KyE3VSfwqOBpc53oznHNWmmlV/S?= =?us-ascii?Q?gKYvunLKzK3c8LGNF3YRD7HLXK8P1VMuSuGOL+lWFL264zAMmOjUjsyeFQNF?= =?us-ascii?Q?JVXywPZrSfDmLAgL1ZEtCXjm9Ns7HiPL+DOk606K88S4zwWx9B60i7QqAWdH?= =?us-ascii?Q?KePWiTD2OvhV+wsU8r8g/vsypzi/nk1ducmvhAsEFoGhfYywOXfHnpcw4YNI?= =?us-ascii?Q?BD+zLKlgNkRXWXsQRQA5RadIaq9UtUW5hHFx+Rz2PCWn5DKqjK5DkqM2q396?= =?us-ascii?Q?uYO2D/XRp/O+ltzCx3dd8DNgAMqw6RUEhkWNtYkH0DhKAVXozLAuXpOjJPVV?= =?us-ascii?Q?r96UBNOaBCuLty73iW9Ad1XuQidXFL2sQcAniLOGLVroRAV9/Ser7VQXfbAZ?= =?us-ascii?Q?VY1Y2ReszznQQug3kyDqdGDaJE6Ya5Ryw8fnHAGZrKyrIe4dq6Dnwja7NK6L?= =?us-ascii?Q?xk5k6VIvU2QXqMq78SWkpC2tpbv6FgqEMrhJxH4MLhDyBp/4A6/yEAQSaTuQ?= =?us-ascii?Q?/PvQezFs5RAB1TYF1UIP5cI8N3PMUseyY78HQynoBbxizyezq7HQCeXi/xmN?= =?us-ascii?Q?z4XQVNjeuN94o7oBza8F6F6ecDDy/F+tpWuDTr71syUs+almyAYZEi4vbbdJ?= =?us-ascii?Q?JR46pk4/knd8MreBYW8PVr8j93HvRqlQcN8eWRQAmvltQxEi+4+gO2KcOVKo?= =?us-ascii?Q?fj5GlQi6W8pY8MdU85S0eBbI6K5ocaLGiJDqMKeV3SrzbJzxJ2c+QRqAkEEY?= =?us-ascii?Q?lA0/W5eeU0S5tc4PT9IEqloprXsMAMVdp9oNQ4YiPugL3mgKI8QUIXo8ASOv?= =?us-ascii?Q?xFV4Z0z94rgUuQFGJCD6Ddded/bU/uO0NqkjZJlnjWWLw6zZCVNMQc2u1DIV?= =?us-ascii?Q?kPtYwr3ObvQAAyALXmeMR8KvxiaoAISHh/HR4yymZfrlxQJ3B8bHkZRUrME/?= =?us-ascii?Q?VVgPnkDcEaa890d3UBVrwejTKtCScMPcya8nLJ2VeF5oRvzq40JirOS7w2dM?= =?us-ascii?Q?xn86h3YC2zn9bTvv209yvzQSHkXog/5bcTOLuS3pfFZc4ZJ4rlFlu6LQHeP2?= =?us-ascii?Q?Z+lCcl1hxOEkFwHMo+Hl2m7zweY9xvs/m+JysVhvOLwDMoxqEoom98gHWmGU?= =?us-ascii?Q?JkqE9B+FQ4kXCoTVd54zZRCK1woktlMY3bsYQQWrc77oRb3SEzEG4r1O4How?= =?us-ascii?Q?iAkhipI2oKiqrpuLoD/9I6Z74mdbhrPA1W5cvsgZlVIkZfm2b9BWkv32+VRU?= =?us-ascii?Q?t1/TAwAF5wcDLY6thG4Z5x2lBInJnUaNPj7lm1OKk9ZuHAGRGDlmVE9d+Y+d?= =?us-ascii?Q?X8Nq/pm0IEMyjrmi2W9ODxD0MGigkU1FCFMYMotIDZK+nPJuxpLrcA1I2u5P?= =?us-ascii?Q?K1xRFbrweGODPbP9utM+R1guTZSvJMu/nn9tRQiFuQ+Lq7Q5WGTbk0jl0UXV?= =?us-ascii?Q?yLyrojv5lpEATOy4JGfqt6nZrgM+tfNIQbz+ikcuB7WRE2SjRdyE/VhhH3RH?= =?us-ascii?Q?ASW/dGTpMp0W1yT3p31kHBeJ0shF9VkSTB2/tB2s3O83LabB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b2b97de-9ed0-4f74-6e8b-08dee0e3f344 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2026 13:37:57.5955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mClcbOKkzPJ1FlKiK4cllpMdfCLcPI62DxrfGOPyOkq2MCWp7efuGgtSrQHAfA30yfQk1hh51ANt1W9J2/jFyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR12MB9624 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General On Monday, July 13, 2026 11:11 AM, srinath.parvathaneni@arm.com wrote: > From: Srinath Parvathaneni > > GDB reports "Invalid cast" when assigning small integer literals (32-bit)= to > 64-bit TYPE_CODE_FLAGS registers. For example, with the existing upstream= FPMR > register, set $fpmr =3D 0x777777777 succeeds, whereas set $fpmr =3D 0x77 = fails with > "Invalid cast" and this patch fixes the issue but makes changes to a gene= ric > function value_cast in gdb/valops.c. > > * testsuite/gdb.arch/aarch64-fpmr.exp : Add "set $fpmr" test. > * gdb/valops.c (value_cast): Add TYPE_CODE_FLAGS condition to int= eger > assignment. > > Regression tested on aarch64-none-linux-gnu with no regressions. > > Ok for GDB master? > > Regards, > Srinath > --- > gdb/testsuite/gdb.arch/aarch64-fpmr.exp | 6 ++++++ > gdb/valops.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.arch/aarch64-fpmr.exp b/gdb/testsuite/gdb.= arch/aarch64- > fpmr.exp > index 72fd977fc67..2eee10fe924 100644 > --- a/gdb/testsuite/gdb.arch/aarch64-fpmr.exp > +++ b/gdb/testsuite/gdb.arch/aarch64-fpmr.exp > @@ -97,3 +97,9 @@ gdb_test_multiple "set \$fpmr=3D0x3f007f4008" "" { > pass "Write to FPMR from GDB" > } > } > + > +gdb_test_multiple "set \$fpmr=3D0x1255C041" "" { > + -re ".*\r\n.*\[ F8S1=3DE4M3 F8S2=3DE5M2 F8D=3DE4M3 OSM=3DMaxNormal O= SC=3DMaxNormal It should be possible to remove ".*\r\n.*" from the beginning of the regexp= . Is there a specific reason gdb_test_multiple was used instead of a simpler = gdb_test? If gdb_test_multiple is necessary for some reason, I'd also suggest adding = -wrap to avoid leaving unmatched contents in the buffer. Regards, -Baris > LSCALE=3D85 NSCALE=3D18 LSCALE2=3D0 \]" { > + pass "Write 32-bit value to 64-bit register FPMR from GDB" > + } > +} > diff --git a/gdb/valops.c b/gdb/valops.c > index ab6fd5079e1..170311dc63c 100644 > --- a/gdb/valops.c > +++ b/gdb/valops.c > @@ -557,7 +557,7 @@ value_cast (struct type *type, struct value *arg2) > return value_from_longest (to_type, value_as_long (arg2)); > } > else if ((code1 =3D=3D TYPE_CODE_INT || code1 =3D=3D TYPE_CODE_ENUM > - || code1 =3D=3D TYPE_CODE_RANGE) > + || code1 =3D=3D TYPE_CODE_RANGE || code1 =3D=3D TYPE_CODE_FLA= GS) > && (scalar || code2 =3D=3D TYPE_CODE_PTR > || code2 =3D=3D TYPE_CODE_MEMBERPTR)) > { > -- > 2.43.0