RE: [PATCH v2] gdb, amdgpu: add config guards for AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE

["Six, Lancelot" <Lancelot.Six@amd.com>]

AMD General

> -----Original Message-----
> From: Aktemur, Baris <TankutBaris.Aktemur@amd.com>
> Sent: 16 October 2026 07:53
> To: Simon Marchi <simark@simark.ca>; gdb-patches@sourceware.org; Six,
> Lancelot <Lancelot.Six@amd.com>
> Subject: RE: [PATCH v2] gdb, amdgpu: add config guards for
> AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE
>
> AMD General
>
> On Thursday, October 15, 2026 9:04 PM, Simon Marchi wrote:
> > On 10/15/26 2:15 PM, Tankut Baris Aktemur wrote:
> > > diff --git a/gdb/configure.ac b/gdb/configure.ac
> > > index e0117ede292..7a437747e35 100644
> > > --- a/gdb/configure.ac
> > > +++ b/gdb/configure.ac
> > > @@ -368,6 +368,27 @@ if test "$gdb_require_amd_dbgapi" = true \
> > >       AC_MSG_ERROR([amd-dbgapi not supported for host ${gdb_host}])
> > >       ;;
> > >      esac
> > > +
> > > +    # Detect if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE can
> be used.
> >
> > As a person who likes to clean up obsolete code, may I ask you to
> > mention which dbgapi version introduced
> > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE?  This way it will
> become easier
> > to spot when this configure check is no longer necessary.
>
> It became available with rocm-dbgapi-0.78.  I'll add this to the comment
> above.
>
> -Baris
>

Hi,

I was wondering if AC_CHECK_DECLS wouldn't be a better fit than AC_COMPILE_IFELSE.  Would probably simplify things a bit.

WDYT?

Best,
Lanceloet.