From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qOv1GtgJ0Wp41BIAWB0awg (envelope-from ) for ; Thu, 15 Oct 2026 13:14:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=DHi/BNIU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4D7491E04E; Thu, 15 Oct 2026 13:14:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D22B81E04E for ; Thu, 15 Oct 2026 13:13:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8DBB74BA2E1D for ; Thu, 15 Oct 2026 17:13:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DBB74BA2E1D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=DHi/BNIU Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c10d::3]) by sourceware.org (Postfix) with ESMTPS id 700204BA2E09 for ; Thu, 15 Oct 2026 17:13:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 700204BA2E09 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 700204BA2E09 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c10d::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792084409; cv=pass; b=W6RSsEzD4JEsnZKZVpy6JrugCKbztq/HvqasWf4bd7vCfLi9u2Ic7X0ugY72E68jag1YM3ffvXAYpCy3m5boimM0CmWSFkb5ag0eiyfyeaz/LzWZmtzaBfxZEo8pnSrtB1M+dohibb5TLJw+NOJ8ie4xSc0GWShalO9v8Wq3RpE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1792084409; c=relaxed/simple; bh=hU8hYSxmzadr3Kr1y74c4/l81rho+Z3ee907vI1Buqk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LFUiTNdn28NfW6K35CY8rSl8ZguHxW91St8diy1bVT/UyBnAeF2PmuxwDkGuTfi5sPM1jvKXAQkdSNgJ7LT3jQ04j/TbkXd1fQyt/WnqgY56Cj/W8CxWlLO/AxNbBwqYE88BT+HEz/qgHPB6tRTnv00tidZcnlzMJsgQWshIyY4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=DHi/BNIU DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 700204BA2E09 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l6qzSuRma7LVkUWAXP4qVWUMLyniY1L774hIY8y3cUl3hdccqckAGa4oJ1hdHVAwXJ6/dwavZ8Imz7OoSPrGT5G+fWuK7KbJIsfehybOWkqC28UwdUPgUHofbkYZak/coaNXl8C57yMw/X2fDYxlLIwjQrzRAgthy8w2zLHACZ9L9PO3yXaq6UtK9n1RdVD80d8KRe6Yme8NeGG8RKDq9OZzWvpSO7phoaaCvcVsSQdrxWdW9A3c7PYQGGh3YadOtQGTAbCZ3j3Mb2oPjKh0nPNu4F28m48J4LISBsE8XbLVNxIwM2ocmkIUcYES7MtPXF7PKs1gcU9SA4TyGTIOaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=raWVRHO3Iq41A8hYZVjMAv5kKwgMbqh4VRC4En7H8HU=; b=HoGmpTQ8dj1VwShV2388bbhQ2GEI0dUpJoap2rnMX8Ik9RnmUqCvkxOIx/j9alMD2ZpGNDTq039GFT+QW3NVEU/cjg4x2Gy7pc2j+dQWSXxT06yOdLBa1ePT10wNdJwMKaYJMKaQXJtTZEYAMTigEAeXTAr70xr4BFGRlTPDpLFAvcU/g4omAr2+hD8mB34qxBP7xRB/B8fqrKLqiP0lOy4ApaXOy79R3QTCkQxn584U4rmoNQRUBMNq8IbJCupH/6tQD2YjrndgsgDgwtlm7EjUw0udzn6y38ggUStaYdNJwW47ODRo+BqvLXHJJqvPY3JcqXbLCG3ed9MU217tzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raWVRHO3Iq41A8hYZVjMAv5kKwgMbqh4VRC4En7H8HU=; b=DHi/BNIUVMVOmmCFF3igb5jErHMEPezRlFSTzMGG1fKmqIbS/64ctIskfBhVY2YO1VfvHFzzNAn4lyVaCCK5EYj9j6fyd13e0nn4VxbLjnQqby7wjNzm0zSSPhHzVwl/KqabISiHEnOSbbatgyRjdxwikZpcvsIiTn9ePPnBz9A= Received: from PH0PR12MB5607.namprd12.prod.outlook.com (2603:10b6:510:142::22) by DS7PR12MB6261.namprd12.prod.outlook.com (2603:10b6:8:97::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.13; Thu, 15 Oct 2026 17:13:23 +0000 Received: from PH0PR12MB5607.namprd12.prod.outlook.com ([fe80::26e0:df91:f91:c41]) by PH0PR12MB5607.namprd12.prod.outlook.com ([fe80::26e0:df91:f91:c41%4]) with mapi id 15.21.0522.013; Thu, 15 Oct 2026 17:13:23 +0000 From: "Six, Lancelot" To: "Aktemur, Baris" , "gdb-patches@sourceware.org" , "tom@tromey.com" Subject: RE: [PATCH] gdb, amdgpu: add config guards for AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE Thread-Topic: [PATCH] gdb, amdgpu: add config guards for AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE Thread-Index: AQHdXMdW8XNFvay69Eq4nT7YPbVDMbb+1rxQ Date: Thu, 15 Oct 2026 17:13:23 +0000 Message-ID: References: <20261015170450.2520815-1-tankutbaris.aktemur@amd.com> In-Reply-To: <20261015170450.2520815-1-tankutbaris.aktemur@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-10-15T17:10:58.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR12MB5607:EE_|DS7PR12MB6261:EE_ x-ms-office365-filtering-correlation-id: b5e5474b-fce9-40f9-a7e6-08df2adf9e3a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|6133799003|22082099003|10067099003|18002099003|261009223027099003|5023799004|11063799006|38070700021|56012099006; x-microsoft-antispam-message-info: /QlBoTrjqLveXiY7krKFyzKkVtUBPcZQCgi1pn3JL2QMGJRnadnIi7NNgnb0F51HXz88gKzHQw6YW/P65LK34dx4O0iSdUzJ8NPAin4VNnDmSh+i6TiXFPIGk0SJDLimrUDbD5MY/EvAHxPN3QlKaOyVG9xCYwSta9jXY/wUJaUsnnOojuWTXmRkJmW5DLGOO75lmtwGmQETc6dR+T1vPfgN9qnLoWKsc8opaNusxnGP1VBwU93CVykyiIemZMjl1TMSi20KyII1R/cA8m9tjFOBYyEjJUmVkLayTxJeY7C0W7fp9B6Ef1fw1VCiJpeYhy4nlELdriCijD6id8psZjAItrqZ4YZOyh0AtA7tfpMr9jUYzzgtjndLbxCYaTF938nLk/NyTK1QVczZ4cDffs4M7Y4QKhuhMCeX4T/b85ekPjN7kRtdAHB/csir5DN+fTM01T2145zq+bRaTvuUWSwrO3uz5NLzDX3GBpZ8sAF7OvFqNG8ZcvQhueAU0sEgyfDY6Lbt8qqhrm1xJqOLLDtwXAh089Q1rpLu4d3Kg5iYVj9skVMUmqi5sMcDTeTa3GGdhpwt+RMgrYM3ip3vGyPxcvn4sRYyOAMgcaQpwJ5xd+5ShTVTWurHM/zurywpqX5EnLqhKo80he4EUKXk1zb9ZCkMwSvqUSV8BOY7rH0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB5607.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(6133799003)(22082099003)(10067099003)(18002099003)(261009223027099003)(5023799004)(11063799006)(38070700021)(56012099006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AppkfbWAUQMCXuF5p4ylmxgCv8qgmkz6IrBMYx2djjOK5C/+nmfu0A+CYJA+?= =?us-ascii?Q?DK3eXPganbcxCEgnEJqdMQrOZLFDd3D/DNxDpawZvN0rfCorY5lgDy4qHj+G?= =?us-ascii?Q?f233/+zFNXyPwbnPPj4X1ccP+yVfdYAAmDQMRAA+4POAcxu9WJrVKewYl4dD?= =?us-ascii?Q?4Sx3ar2eYwgqmWw/9dLa2Kx9BzqiQCoo1lNb7epxw0CfrPX2XlOzWBty89o+?= =?us-ascii?Q?MaJ+HFKBLI6+j3YQcQumWUWu2PUh+toJ8aJyvls+z0XK/MNQEzN/oLMG2VqQ?= =?us-ascii?Q?PLkup+8F6uQcvTBdtmFOcoiXsqIafMxO8Qpixt5JfLY7o96aAH/Jr97++HKs?= =?us-ascii?Q?BvS4NUuGo8lpUpYzNycKVC4ZMGigGQbeq7QCNpkTX1TZyXlv4lpYA6BLAGAu?= =?us-ascii?Q?HSd64THYJMIzZDDjMG5bfVl+43MM+MFKgWHJ84TujS+cR9uD95adtKODnq/K?= =?us-ascii?Q?YwkQzp9E3Y2KZeQTEswq0RuLAAvUMw0XAJHQ/hUG4G1PTEc+RFibByhybx2B?= =?us-ascii?Q?/PwJwELz6sSGONCfIxjJ4pP1bsjZC+WlsUxLYSVs5rKONqXOAd6UMxWjqm7q?= =?us-ascii?Q?nopHPmv0ohvhrEQudAnOZJ4K5YqCFhCdT9QnXDg7C6LGWYhcvaYQ11vHNb+l?= =?us-ascii?Q?76a8ADF9Dq52WFDOt89c3m69HNucz+MgWAumiCEzwJmDWO7VQSeRWfuIO1Ea?= =?us-ascii?Q?7j81RhQf6GNGIs7h2tCUFvquDpo4dHkPRunlSDUWd6yuUpOHRgiclvYiaq1d?= =?us-ascii?Q?oV1/K2osBkrckEMiw/5HJNVkiiHFkbMEPvZsWYtTpb/A3AZA/2M50WfOr9Yd?= =?us-ascii?Q?mPbpVQGLd06a+y7ZAyJmniFa3Lv1sOgeQeFoaY84itq/xxEDQSUmTB/gYhAu?= =?us-ascii?Q?jD5TzkjO2QQDATcksTwZc5VYDXyfkvY/3H1tJ2s+UCnDxLt2bKxLPFGuUAe0?= =?us-ascii?Q?t6xeN/Wir2sW0PGgidzdHmVtCoCZdJ4HoXxAREYOWUN4Ig3MHhefwcYTs99y?= =?us-ascii?Q?C04nqXThAvV3maJVnTmYhy8dRUBMwZcjyDN1tVhl7rHqydxYkQgJhSmmqP8G?= =?us-ascii?Q?QL5KZKS5fuOkG+cBVmLjD3j4+/DL5M9IUJkan8mvGOozPSUdBnxrHEbr6Sfl?= =?us-ascii?Q?qroPO5zdr+wBZoznZevglA+/2JU1d2eMOyiGJ8l1cQ/pD5v+opXjogRO5Ubw?= =?us-ascii?Q?kIHf34UUnH5D+IT0tcp1bh6WJ1ui7Py6CeBkye9zbHhQML4cAVX1FtMKU2xn?= =?us-ascii?Q?3q3gDDTkkX6e8FCOQqrN8tCcKYtTzeMTNdPgFXuakEb7wfUbwBL8Vux6qfad?= =?us-ascii?Q?nTlURtzvmvYVG2lyD9GTRcZW7wSPg1QnfZC7AdLAbLUaAYk3NYrMBVt6weIT?= =?us-ascii?Q?N6ZtXwZekr68X1icj0sltU0X2q0Vj4S/VUVTdJ2sqvLgmJ6OAOUDOAtugqNG?= =?us-ascii?Q?MAAguO1mBdKcGKmqTgIvWZvgbxakatnCEt9mzsqW4AhXguVcYF4YfchLrWcu?= =?us-ascii?Q?0EK+YTdRSZBfWjud68E7hIfy75FpjNfae1MUeicnxC/1Z3I4YqIvkr/jSTYf?= =?us-ascii?Q?bXYnzTpco2dVxnGyEdJyjmkTkyIjhQmox/fry+8GAktVaLyfaIoPzb4GF+qy?= =?us-ascii?Q?rI6gQMFuDOu7WiWiCtafQ85bXDGZWP5KZ9OL49e8KD+QFsakBy5CmqQdKgxa?= =?us-ascii?Q?uF57xOGxfelK891hBPMKDTOT8hokXPHZ/ahVWHF1L0cPoDJa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5607.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5e5474b-fce9-40f9-a7e6-08df2adf9e3a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2026 17:13:23.0451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7UXDjZKhfHKQCBH5+o/tE/GBbHWhqmxbws0Dok7CxtayCPHSII51gKcI/5ZFXfMA0qJZdeO7Z3zoa6YCbK+EPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6261 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General > -----Original Message----- > From: Aktemur, Baris > Sent: 15 October 2026 18:05 > To: gdb-patches@sourceware.org; Six, Lancelot ; > tom@tromey.com > Subject: [PATCH] gdb, amdgpu: add config guards for > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE > > Commit e52a8aca2baf6481c4e8fea45530283759096be5 "gdb, amdgpu: > handle > UNAVAILABLE error when accessing memory" used an enum value from > amd-dbgapi named AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE > that may > not be available in all installed packages. This causes a build > failure as reported by Tom Tromey at > > https://sourceware.org/pipermail/gdb-patches/2026-October/231115.html > > Detect at configuration time if the enum value exists and guard the > newly added code accordingly. > --- > gdb/amd-dbgapi-target.c | 4 ++++ > gdb/config.in | 3 +++ > gdb/configure | 36 ++++++++++++++++++++++++++++++++++++ > gdb/configure.ac | 21 +++++++++++++++++++++ > 4 files changed, 64 insertions(+) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 2fd175de6f7..1446187c75f 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -786,11 +786,13 @@ amd_dbgapi_target::xfer_partial (enum > target_object object, const char *annex, > AMD_DBGAPI_ADDRESS_SPACE_GLOBAL, > offset, &len, writebuf); > > +#if AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE > if (status =3D=3D AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE) > { > *xfered_len =3D requested_len; > return TARGET_XFER_UNAVAILABLE; > } > +#endif > > if (status !=3D AMD_DBGAPI_STATUS_SUCCESS) > return TARGET_XFER_E_IO; > @@ -2576,8 +2578,10 @@ amd_dbgapi_xfer_global_memory_callback > > if (status =3D=3D TARGET_XFER_EOF) > return AMD_DBGAPI_STATUS_ERROR_PROCESS_EXITED; > +#if AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE > else if (status =3D=3D TARGET_XFER_UNAVAILABLE) > return AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE; > +#endif > else if (status !=3D TARGET_XFER_OK) > return AMD_DBGAPI_STATUS_ERROR_MEMORY_ACCESS; > > diff --git a/gdb/config.in b/gdb/config.in > index 7ea0e9cfce8..93060f573c5 100644 > --- a/gdb/config.in > +++ b/gdb/config.in > @@ -6,6 +6,9 @@ > /* Additional directories to look for separate debug info. */ > #undef ADDITIONAL_DEBUG_DIRS > > +/* Define if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is > available. */ > +#undef AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE > + > /* Directories from which to load auto-loaded scripts. */ > #undef AUTO_LOAD_DIR > > diff --git a/gdb/configure b/gdb/configure > index 0ed49887480..eaa8588fe69 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -25105,6 +25105,42 @@ $as_echo "#define HAVE_AMD_DBGAPI 1" > >>confdefs.h > as_fn_error $? "amd-dbgapi not supported for host ${gdb_host}" > "$LINENO" 5 > ;; > esac > + > + # Detect if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE can be > used. > + save_CPPFLAGS=3D"$CPPFLAGS" > + CPPFLAGS=3D"$CPPFLAGS $AMD_DBGAPI_CFLAGS" > + { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available" >&5 > +$as_echo_n "checking whether > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available... " >&6; } > + cat confdefs.h - <<_ACEOF >conftest.$ac_ext > +/* end confdefs.h. */ > +#include > +int > +main () > +{ > +amd_dbgapi_status_t s =3D > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE; > + > + ; > + return 0; > +} > +_ACEOF > +if ac_fn_c_try_compile "$LINENO"; then : > + amd_dbgapi_has_status_error_memory_unavailable=3Dyes > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5 > +$as_echo "yes" >&6; } > +else > + amd_dbgapi_has_status_error_memory_unavailable=3Dno > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > +fi > +rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext > + CPPFLAGS=3D"$save_CPPFLAGS" > + > + if test "x${amd_dbgapi_has_status_error_memory_unavailable}" =3D "xy= es"; > then > + > +$as_echo "#define > AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE 1" > >>confdefs.h > + > + fi > + > elif test "$gdb_require_amd_dbgapi" =3D true -o "$with_amd_dbgapi" =3D= yes; > then > # amd-dbgapi was not found and... > # > diff --git a/gdb/configure.ac b/gdb/configure.ac > index e0117ede292..274d248a64d 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -368,6 +368,27 @@ if test "$gdb_require_amd_dbgapi" =3D true \ > AC_MSG_ERROR([amd-dbgapi not supported for host ${gdb_host}]) > ;; > esac > + > + # Detect if AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE can be > used. > + save_CPPFLAGS=3D"$CPPFLAGS" > + CPPFLAGS=3D"$CPPFLAGS $AMD_DBGAPI_CFLAGS" > + AC_MSG_CHECKING([whether > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available]) > + AC_COMPILE_IFELSE( > + [AC_LANG_PROGRAM( > + [[#include ]], > + [[amd_dbgapi_status_t s =3D > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE;]] > + )], Hi, Silly question. If CPPFLAGS contains "-Werror -Wall", wouldn't this risk t= o complain about s not being used? Would fallback to the conservative solu= tion to not use MEMORY_UNAVAILABLE, so nothing really dramatic. Might be worth using "(void) AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE" (o= r anything to avoid the potential warning). Best, Lancelot. > + [amd_dbgapi_has_status_error_memory_unavailable=3Dyes > + AC_MSG_RESULT([yes])], > + [amd_dbgapi_has_status_error_memory_unavailable=3Dno > + AC_MSG_RESULT([no])]) > + CPPFLAGS=3D"$save_CPPFLAGS" > + > + if test "x${amd_dbgapi_has_status_error_memory_unavailable}" =3D "xy= es"; > then > + > AC_DEFINE(AMD_DBGAPI_HAS_STATUS_ERROR_MEMORY_UNAVAILABLE, 1, > + [Define if > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE is available.]) > + fi > + > elif test "$gdb_require_amd_dbgapi" =3D true -o "$with_amd_dbgapi" =3D= yes; > then > # amd-dbgapi was not found and... > # > -- > 2.53.0