Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Six, Lancelot" <Lancelot.Six@amd.com>
To: Simon Marchi <simark@simark.ca>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "Aktemur, Baris" <TankutBaris.Aktemur@amd.com>,
	"Machado, Luis" <Luis.Machado@amd.com>
Subject: RE: [PATCH] gdb/testsuite: Fix gdb.rocm/displaced-stepping.exp
Date: Wed, 21 Oct 2026 14:23:54 +0000	[thread overview]
Message-ID: <PH0PR12MB56075BB7A28799D78EFF205383662@PH0PR12MB5607.namprd12.prod.outlook.com> (raw)
In-Reply-To: <fe90ceda-4dc7-4719-bb72-19347451d77e@simark.ca>

AMD General

> -----Original Message-----
> From: Simon Marchi <simark@simark.ca>
> Sent: 21 October 2026 15:22
> To: Six, Lancelot <Lancelot.Six@amd.com>; gdb-patches@sourceware.org
> Cc: Aktemur, Baris <TankutBaris.Aktemur@amd.com>; Machado, Luis
> <Luis.Machado@amd.com>
> Subject: Re: [PATCH] gdb/testsuite: Fix gdb.rocm/displaced-stepping.exp
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 10/21/26 9:39 AM, Lancelot SIX wrote:
> > The gdb.rocm/displaced-stepping.exp testcase currently fails with:
> >
> >   with debug displaced on -- stepi
> >   Unhandled dwarf expression opcode 0xe9
> >   (gdb) FAIL: gdb.rocm/displaced-stepping.exp: with debug displaced on --
> stepi
> >
> > This is because when doing the stepi, GDB computes the current frame ID
> > in set_step_info.  This will go and evaluate the CFA for the current
> > frame, which reads AMDGPU debug info, which is not supported by GDB
> > currently.
> >
> > Current AMDGPU DWARF requires changes expected to be available in the
> > future DWARF-6 standard (address space support), as well as llvm private
> > opcodes (DW_OP_LLVM_user DW_OP_LLVM_form_aspace_address):
> >
> >     $ llvm-dwarfdump --debug-frame displaced-stepping.0.hip-amdgcn-amd-
> amdhsa--gfx1031
> >     [...]
> >     00000014 00000018 00000018 FDE cie=00000000
> pc=00001a00...00001b64
> >       Format:       DWARF32
> >       DW_CFA_def_cfa_expression: DW_OP_lit0, DW_OP_lit6,
> DW_OP_LLVM_user DW_OP_LLVM_form_aspace_address
> >
> > At this point, there is no way to support this in GDB, so instead this
> > patch proposes to fix the failure by instructing the compiler to not
> > produce any unwind table.
> >
> > Tested on x86_64-linux + AMDGPU-gfx1031.
> >
> > Change-Id: I2e62270f39c9e96324ae01d401bafb46cfff596c
>
> I suppose something changed in the compiler since the test was merged,
> since it used to pass.  Did it not emit those tables before?
>

Indeed.  I have not tracked when the compiler started to emit those by default. As you say, this used to pass.

Thanks for the review.

> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Simon

  reply	other threads:[~2026-10-21 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 13:39 Lancelot SIX
2026-10-21 14:21 ` Simon Marchi
2026-10-21 14:23   ` Six, Lancelot [this message]
2026-10-21 14:22 ` Aktemur, Baris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR12MB56075BB7A28799D78EFF205383662@PH0PR12MB5607.namprd12.prod.outlook.com \
    --to=lancelot.six@amd.com \
    --cc=Luis.Machado@amd.com \
    --cc=TankutBaris.Aktemur@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox