From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PFEwKdsB5mL1jx0AWB0awg (envelope-from ) for ; Sun, 31 Jul 2022 00:15:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 9493C1EA04; Sun, 31 Jul 2022 00:15:23 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=LtHpuKj/; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1E8CB1E9ED for ; Sun, 31 Jul 2022 00:15:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E11B93856DE2 for ; Sun, 31 Jul 2022 04:15:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E11B93856DE2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659240921; bh=oEIg1xIp4mjbYxX2TW9nR+7qriHIkhpMZKiTwVno/jc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=LtHpuKj/z5L86FZ16vJTikJEtvNo9N15smO2T3dTkAL9w+vSKjehMn2T1eesfvKQW GvJ81uk50GN//M6VklKuKTo4XW37NspMJLe1IT9glOW9DZvixIYBpdZXV6NUHBy6Wy GWaWtVrpCl5euW7XK/Zur2xDLYG8gF6zHDzp++Qo= Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2070.outbound.protection.outlook.com [40.92.98.70]) by sourceware.org (Postfix) with ESMTPS id B0B263858406 for ; Sun, 31 Jul 2022 04:15:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0B263858406 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUN3qH3RoOaI+p/TaAwuF7zDlw64e8XMxGJ7xOgQSf1WF1HKXRyEXhI5pOB6+9tUyavgaSaS5pqkz8rInwi5Ji76u/OZTY5gPyA4T4PcGXzOi4qGEtF52vKqK1L7hhlcHTqEtW3BLiSbzlJgS4E55YSTRLki8qzUrqhNILgr7lyy0pOO8vDKSM/g7F1pFIdYkghVPKqSlft2SCODsVDCSGpcCy7FsEuBHfwCJ+1fvyRclDpgObKhkrD21UhOFWIsc0FR1vFrRwy2KVfTJHaPxU0ito/I0kSaEwcq0YR1V3FYKgNI8z9qLkG0JFI7/a3b+smW7FOgvUs7FCXwy7fK3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oEIg1xIp4mjbYxX2TW9nR+7qriHIkhpMZKiTwVno/jc=; b=M3560StTqP535DeUJ/vhja14b1c6AMUEsmTBg5nuN4Yyn783BDO1lapHXWsRYpYM5Hzoyj34NGQT6GDZnncDLaYuqnYYuJALzVG1YUvMr6/u1AbnMxVyCUN3Hy5SlF4bYswRTZ41y4zf0VFQwcmBnos7toRSSldS1evfbCP8xU5hxHJbNzRbGgu1KkjLZaNz2lbxAHMMKitlI0BfiNZvbdY1vVLaLf83j/8yJnErYFtbYqruBGPLONW886kPQKGLehjpmXZar9CkRINksqiU/WuTaeJZWXtHTOC1/AtHyVIxpmRpnMu9KGBwkhB9VWP+Y+0mWYdisvOqKHdwz69gKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYYP286MB1691.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:fd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Sun, 31 Jul 2022 04:14:57 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5482.010; Sun, 31 Jul 2022 04:14:57 +0000 To: gdb-patches@sourceware.org Subject: [PATCH] gdb/amd64: clean up unused variable Date: Sun, 31 Jul 2022 12:14:44 +0800 Message-ID: X-Mailer: git-send-email 2.37.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [s7KD0cU5Eg/6eMrTrRq3jUmEl89JNILM] X-ClientProxiedBy: SG2PR02CA0105.apcprd02.prod.outlook.com (2603:1096:4:92::21) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20220731041444.12752-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c040511d-396e-43d4-a12b-08da72ab3ac0 X-MS-TrafficTypeDiagnostic: TYYP286MB1691:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +9HWHB2VjayalALva/htIb0KS0JfZEQyzh4MfsyRz3/d3J5GqCMxPA0TLBlkdwxrGVGeIjulFKLDhDBtDyXUOkJ+Qrl1xRcrJDGjy3ZHVx02pcGm1LxyuP7ZNk05qFngSKFajtfEEdp2pw748x5Qn3gh/Va+NmFDcV3wZnbvf/076p6T0D9BVy6fIVR1izIztRCuU+pp6OKR4jPcsdywHRLHRELuyrK3Y87e2+T1eDbj+erxm4XR19cuMUUXsQqVcXoPo0YJ0h9jgt71dutotpGT0ofxQ6F02yh2G+wgIE80Y/0mC8748a7Jqokcw3EQ11og8BpoRBj68CWjUQuhxZaVbY/dA23V7BhzkEnIiPHkI9A54E0h6dZQkcCI/E30TZzR4aK41XZwZiBYbrCva2vyUbuL6w3LZHV/sKtLwjhJGJlTFR+cxkn5Mqqs+BQNrHPXUZPXRatyo3egPiPCDsrMyjXnQvDYEv5jPrxhSNwqKQ+Rqai0VRPEzYCemWJ0qeyt2vWXxDuPvS3IHS8X0TXXtoEjsdAwta8BB4NtjxWkK3EBHZGclI6F158QSCs5Pi8v3I480Vq3XkcZwA1U9xtFd33xpHqMx4/sKTAd2P7oylaS1tyrFcdn0xQK+DTif+7dNhdNdv8K1V5IgQf5rA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jWqSHQ4ir0IZymSrdC3X/jIXIySDoVS53jwEo6jMDAcqhREmTq7LDDJIuQvf?= =?us-ascii?Q?RnwHyzlrinGkccmn/LO6lecAACPwAKDz1+IoEKEUvILgY77Tx+mhDo+7NEfN?= =?us-ascii?Q?zhIxbK3B/xgu8tWihtnxhk6TR3peucYniNyUh28PoYbDqrPIqE/0swtfe+0u?= =?us-ascii?Q?FxdEW7FcVIdCaIC6rlOfw8ZN6LoP3rRReonKBnPZ8uA3itNiC6OVhs+sHIMi?= =?us-ascii?Q?PlPHiatyQRuobEETFjE+ppP5GF+kOzNX5zzIE6j5iCgko79TsSqCc3v5hD32?= =?us-ascii?Q?q9w9HkKMH0OFHi2Hy9TeV5AzzYTpKDiHML6uFeQ7F8w5cJz7bOKiQDxPzHUG?= =?us-ascii?Q?1D0XkgFbvZ3/FYvaWw+7rDB7NCNrMO9w9KMUgA/fM9MUIkM+zqZqHkCYUHea?= =?us-ascii?Q?6kuRijbwm2tVsJ5R8bf1L2gpoUeL22qi0R5bgdnDBTka/e6WTdQUreqQ2GkJ?= =?us-ascii?Q?ggMxxamBU+JHvNVHlS2dm+YLJgZgzk/DkrgwwoSvAJnNewLwKnxPLGQQwhRw?= =?us-ascii?Q?ItgIltVYWLac1eJDle0JP2ANqvl6UK+P+chNBziKEt9waV0/lnC2DPx7wT0v?= =?us-ascii?Q?65c3WOsW9VQE1UtyKWhD+EPTpOyqaRSj3xkPm9OiLGZayn9bx0PZu4uiS8Gx?= =?us-ascii?Q?Lo3npSKEyb80id/zxIoQib/HZIdO8faJ5nlpX6vtygFC8mm6rCfPQcnMSqHo?= =?us-ascii?Q?+Q6T7FzMlIQ3eRab0rMdXEsUIaX8jydGkRZRa+G/66w87vclMFQxLIKLlPWe?= =?us-ascii?Q?HTbOgOfgpWXmfMIVLrXrkb9lsLRtHKhNOrqVbbSQZZrAuEMGvGY1+hMJrThd?= =?us-ascii?Q?+AwHm1ukYRoZsbIvoywJ8fQmnewyIT7OVgvUSo4BpCCqCoYDBri1qWuzX0cH?= =?us-ascii?Q?0+gZihzTcN0SbAii8OhAc9hED7/G3k5CCfhotoSEw5Qr75z9WbzE60i5RZ1q?= =?us-ascii?Q?CXVpdI5JJr35xlu5q3jdG39P9riGWZmn4BVpYYU/PA/EGUk8gNOt8X2Eck+M?= =?us-ascii?Q?0UB7v3xYYCvqSLBqP/B6bTXh75Bs4vNFgEyFkzMeI4ifFtLiDjIaiqYAhTmY?= =?us-ascii?Q?d6MmKJ2ReVcziURy9ym4LFm5PE0qHioSoUKmLOSroJth3/KsH92R1e/n1BAj?= =?us-ascii?Q?ZC0/IkTyQuYnofKHvFVAw46gSxnpeQkeQWVjS12tRuLJikRpRDBf7Kvb7kAZ?= =?us-ascii?Q?6GFQfHU6kZOKXynqxFw65zRg/DU3nnkb/XDT8rxHYqPtV7JaHP6+jMX5krum?= =?us-ascii?Q?a5zm0g/8xPdwZjDlEQGzuH4p+w+/YgR8qFxPdDk6Aw=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: c040511d-396e-43d4-a12b-08da72ab3ac0 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2022 04:14:57.8585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB1691 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Cc: enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When building with clang 15, I got this, CXX amd64-tdep.o amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-Werror,-Wunused-but-set-variable] gdb_byte *insn = insn_details->raw_insn + modrm_offset; ^ 1 error generated. The function that uses this variable has been removed in this commit, commit 870f88f7551b0f2d6aaaa36fb684b5ff8f468107 Date: Mon Apr 18 13:16:27 2016 -0400 remove trivialy unused variables Fix this by removing unused variable. Tested by rebuilding on x86_64-linux with clang 15 and gcc 12. --- gdb/amd64-tdep.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 0563b32a54bf..3fbbf20fc2b1 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -1407,14 +1407,12 @@ fixup_riprel (struct gdbarch *gdbarch, { const struct amd64_insn *insn_details = &dsc->insn_details; int modrm_offset = insn_details->modrm_offset; - gdb_byte *insn = insn_details->raw_insn + modrm_offset; CORE_ADDR rip_base; int insn_length; int arch_tmp_regno, tmp_regno; ULONGEST orig_value; /* %rip+disp32 addressing mode, displacement follows ModRM byte. */ - ++insn; /* Compute the rip-relative address. */ insn_length = gdb_buffered_insn_length (gdbarch, dsc->insn_buf.data (), -- 2.37.1