From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mPkfK7NS6GKSux4AWB0awg (envelope-from ) for ; Mon, 01 Aug 2022 18:24:51 -0400 Received: by simark.ca (Postfix, from userid 112) id A235F1EA05; Mon, 1 Aug 2022 18:24:51 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=x62LlI6I; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4AC161E9EB for ; Mon, 1 Aug 2022 18:24:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B4063857C7A for ; Mon, 1 Aug 2022 22:24:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B4063857C7A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659392690; bh=qG7nPen5e69qA+NI5Eg+qJt3mr9PTzP2MuDSHUUjnN8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=x62LlI6Im5zQ+OGtRWJCyxhTCHR4BoBIsVCScbvUNe75TCvJOAYZc4lW9BFtOWAqH dwWtPAgS0UvpJ22GNWBIH4dFng4FGYVHnsFsgK8Va9kW6YFsK0i2mJFm6THEoEH3dk 1745BFiYItgPKwJgfBcQHM6VWw+I7BKRhKBsRY0w= Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2045.outbound.protection.outlook.com [40.92.98.45]) by sourceware.org (Postfix) with ESMTPS id 435F1385800D for ; Mon, 1 Aug 2022 22:24:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 435F1385800D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLnIIcwdxgZk21fkfJRQ5QPkoQdVplzwRmhKkJfrM4MDPd+9Dm+NxlK73CBppQ9GLgE1GWYfcsQOdm6+GmCow7Ja00t8I/7v1V6524bNESXSUVXZyZbva02i1vlroiBFbLvB1Q2SqAL1YYdFg+2xrwcCwr6zuJ5zn1eA+Mmaj1U/m+srZnm5zwJKWkbqrt5R3+sFMFXiCrz3SOD4+be82mJRxSueBxy/DQDRQdq1AxBfuhPB0FMKg74UcigUvGBMNz3zUlm9fJ96fOGlmLE0O6whNEpy1HTilCn5O0Elptya63jNrIrVLLbLkuiy1B9H9GpVCMawpLbeUopUZdYHrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qG7nPen5e69qA+NI5Eg+qJt3mr9PTzP2MuDSHUUjnN8=; b=UY+IwvJ3QpkMj+FulVp6bxwcb+Xk/tf1LfornxQ3BberTRYBUUXrB06CdGJmw2xwci2eyj7OxqCOCf8egzZUeTvwuUT+BSOgyjFhNC17jrJEO1+RhYLewRl5kqeAl+kuw4bM3A4FTCogWIa+/TUiSRlPC5ipyyP9DNv+ChwGpsgmojBQW2416z7gPbssemwUKzHCkx5Drspcteg/gURaM4Oew1hrGsxcgx09Dm4tfm2naUShcr7sl4btDBp6yO2Bt4VatkhJoIqbMapp4Xb4siI+QFaOi4D1M7XPWCP9sxcZNPnIa47OCqAyD3e8mWyx4DaBhzorHoHTOeKtUTX1sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OSZP286MB1133.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:130::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Mon, 1 Aug 2022 22:24:25 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5482.010; Mon, 1 Aug 2022 22:24:25 +0000 To: gdb-patches@sourceware.org Subject: [PATCH v2] gdb/amd64: clean up unused variable Date: Tue, 2 Aug 2022 06:23:57 +0800 Message-ID: X-Mailer: git-send-email 2.37.1 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [hbjx91YTslkxlLnPvSDCYUrPh9sVJe2N] X-ClientProxiedBy: SG2PR06CA0207.apcprd06.prod.outlook.com (2603:1096:4:68::15) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20220801222357.6124-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9ab46b1-690d-4c5c-8ccc-08da740c96e6 X-MS-TrafficTypeDiagnostic: OSZP286MB1133:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iVnzyj0bz9F24vdNgmfNCCfXDZqqYFFjYPom7ZID1oOPinyMqYppGAuDZDLlam4AnRlXsfUwfuWDhQBk3GJUYVNzjoRJErUyjTHGmILKEkEDmevRHzWLrTqdWhVszjrJWyEp0KDmJBn9IyaNUYoJbdYaYdR2U/vd7Jsyd+AN8PxiUl/hEH2m0DS86j4sVVnyNhPlYytpw0tMSRRNV6/Iy/uZajEmWo/CCMTCb7lwwx98Rmol9FKNmFb3sKqLsJsth95MDlTRptDgUAd967bBVnL/LTPS0cC98OhxFSk1yhYRseayZ1Xdy/8iSZRzI6lJdF1qhS/aRC+J8uK4CGqOB/v6PWNUje5uxjHaWKhoaiEfEPiMbKHqMd9BmUPOjakZSmZR5mwUiurK8/0iTP4zYA+B8b/J6gDi8IpQO7o+N2hXd1v4jBT9XOJO8DlAukCGGOylQVKPtfocRcE4NrBoObw1M3LtxImDkPj0NTFsqN8W2u+LrRbPiTFSGHTEwYMtT9YUxlesHxE5Bv0aSaXMuo8ki1jmtEojJ+4S5QzdHLsExTuCCSTcKOPy8xaJntp7nWRN8GElzz8tQAVh16ixFRIgucGCmrmiscaNauY4XcUbUPeW/tQemv3SVkfvn2d1rQ/rFnyF0FId00CzTXg5dQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?umP/YAJDq4sYuZgjWzPlJoJ7ZULh2fs5oRmayC10Y57df3fSQ4jun8TDy//8?= =?us-ascii?Q?xIhIEF8mQBR0p2CmDgadMHEOCCgfM8MXDyDfo6EYyHudfoSAcHFxlr8AJKkZ?= =?us-ascii?Q?dOfaYV76tMpMNI4OKlDN3QlGRqJmfEAeXE9pMy2JHffJaCNN1ItpVBZKN3Uv?= =?us-ascii?Q?BcF4NQzFGYW+ZV7rs31nlQWwagDWdCUFGl3liI9FDP/DRVypxIatrROpkG2M?= =?us-ascii?Q?ISAsl4D/fINHH6FoAHGcNWprbuCNp+loeE7eBC1x7C+b2F1JWbvyldj7On3W?= =?us-ascii?Q?GhF80onTdXCqjZAi8H/kcmviq8UVgnNFSuPQ5fyuvqca9tDCMo2H6A+jWX2C?= =?us-ascii?Q?GNz8S+xYGqW/N/V33gaV8nGLirFVwsxZ2UkwQRxMinkP4Aw/ilnFYMvqeBF2?= =?us-ascii?Q?uEBYlcJNylYQRkzfqtMh1df37N+7eL43/JbRjvgRrI/+fH321k7beBAi0Oaz?= =?us-ascii?Q?DnkwM8zWDp0I13Es/UU6i0ta++MjFBrJ+TjADE9x5aZg5cp1OQ8y/zcqPgzV?= =?us-ascii?Q?LOtOPhzZK/wd7iVm7VBgd4LM7NK/B+bDgytwMjcb6f2MD6rRKqaVVdSxwMmU?= =?us-ascii?Q?ufgP9dobyrU2UrJLm1iKaZgS2ZI/B4GuoKeeHxrqkw8x/TxPgb5s1VftVFR4?= =?us-ascii?Q?dXSbalhhkdEHLOpkeH3plVZIdfhq5GrGjwu+Z5T1I5K79wBuR6dv2W9ZNdVL?= =?us-ascii?Q?AHVDZW4psCIpKgHo4giXObMG5YUZuexADqr3LFHwzxtNjv7xY+eT3CTRvQf/?= =?us-ascii?Q?dO2Pw1S53zOfiillFO/HK8NeL5HikS7EOE62HUd7IVZjNIWrEoab/7KvZr5m?= =?us-ascii?Q?X9UXkQdl72Wha5AoMN2t6813z68Ck4uz6xUJXkhhYCZCfEyFB/vb5KVW8MjK?= =?us-ascii?Q?PvKMapeOZGR8Lmiv569kbIF2WPHBJr0271BA3Z46SkbVd7QTtsccCQscArw/?= =?us-ascii?Q?wMuCdlQyW7F1vxPM98rNNFIrk4QJiUNAl8zYDLcOdfgeXxz8slc7jzZ0oxPd?= =?us-ascii?Q?uyYlvuEw1PA+uLrpcz+gWJRHPVR0ijmmwbe9HWKavZ2+itWiZkpDRQ8CDS91?= =?us-ascii?Q?A4DefSvFeDu4wLLsQlmkAFIA0GPwKsN9RVp0Wpvfze5bWelZSbz0DuSioyPF?= =?us-ascii?Q?a7fQlnqggB58P2nch1yT6Yo1JMB9bZ/mUd/uB1PNfg3SWhEqm12Ao4UmVmyO?= =?us-ascii?Q?75BpxzEtsXvA1bMlJzpiFtuWNYthgnhn+n8o7DmBsSEPU67iNBJc0vbRfZHd?= =?us-ascii?Q?QTrT+rGMCo8vooGvgsTwwfx3JxW2OneBngzAsYzTDA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: d9ab46b1-690d-4c5c-8ccc-08da740c96e6 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 22:24:25.8340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZP286MB1133 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Cc: enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When building with clang 15, I got this, CXX amd64-tdep.o amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-Werror,-Wunused-but-set-variable] gdb_byte *insn = insn_details->raw_insn + modrm_offset; ^ 1 error generated. The function that uses this variable has been removed in this commit, commit 870f88f7551b0f2d6aaaa36fb684b5ff8f468107 Date: Mon Apr 18 13:16:27 2016 -0400 remove trivialy unused variables Fix this by removing unused variable. Tested by rebuilding on x86_64-linux with clang 15 and gcc 12. --- gdb/amd64-tdep.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 0563b32a54b..d89e06d27cb 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -1407,15 +1407,11 @@ fixup_riprel (struct gdbarch *gdbarch, { const struct amd64_insn *insn_details = &dsc->insn_details; int modrm_offset = insn_details->modrm_offset; - gdb_byte *insn = insn_details->raw_insn + modrm_offset; CORE_ADDR rip_base; int insn_length; int arch_tmp_regno, tmp_regno; ULONGEST orig_value; - /* %rip+disp32 addressing mode, displacement follows ModRM byte. */ - ++insn; - /* Compute the rip-relative address. */ insn_length = gdb_buffered_insn_length (gdbarch, dsc->insn_buf.data (), dsc->insn_buf.size (), from); -- 2.37.1