From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x8eVKEogAGWsyRQAWB0awg (envelope-from ) for ; Tue, 12 Sep 2023 04:24:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=E7mE7G7/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 985DE1E0C3; Tue, 12 Sep 2023 04:24:42 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 884161E028 for ; Tue, 12 Sep 2023 04:24:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18DD2385842C for ; Tue, 12 Sep 2023 08:24:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18DD2385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694507080; bh=b1ysCu+NZbyiT81Qu3ZOV+rSRhlPTBrX5pshWQaf3sw=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=E7mE7G7/T40GX3OT6vnDVe/o5qBDM1GwGMGrDY/ugN1oj8NWXiW0BadmaTNeIyTZu 8CZo4s2eqNwp51eHTFWSwjMQZ8U6wu8b0BA2FqCR87AP11rum56cffncvjCQUIx/Js NTdrIUf5fyFIrT/2xS+XdY/vkMBQoL1sqkzbaZuc= Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2010.outbound.protection.outlook.com [40.92.99.10]) by sourceware.org (Postfix) with ESMTPS id 1479B3858D3C for ; Tue, 12 Sep 2023 08:24:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1479B3858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RKc4W460QFLAIHLJbpHrhf/za/2k9z1dT2khqQGVHf+kQvXswiJi8D4me0Ur+9ozqIYTBZXEmAtezpFRiJmsAuoBjEh0YM9cltxpVGkhMe2z3e1DqJ65xJVb70sthjjXvDYSnYRY1cZ6z08mPD1qMqf83C7M9JDE+nIFVRPzUS/ixj0GypG3xiCtq3nRqYYgXdemE4Uo2GCnA9qJ38MC0qZNWNx+WGBLTCUsU/LEl+GUGRzIrwT/5OK4atwhSwtPdMsSnNM0x01hwVQ08Lcw5pk3WfIwDOZhT0NL+wBXn73OoM1jbHX/CdqOd/6p8tNnkhr/XMXo7ioIYAuVvMCOJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1ysCu+NZbyiT81Qu3ZOV+rSRhlPTBrX5pshWQaf3sw=; b=jS+agfdU4Fr966lUgky1shQ4HLJzsWiPHYc6hk+7CTtH1E99n4+AoxKfPXBwR3dyKPThkxIofNtBdV9U4KV84FgIMetOoQcYTuDTyFCZwm4zsXR0KUBn4cpBlaVLMOeckFRjFcFD5alKuNIeonOP0ZD5UUdLaYwYYW8ka7TRDooROgp4zyCwCqW4TxH56PqdZLw8MedPXlv0q0pk96QZA7xWaeO65DQ7IjXgC7A7X3KyGAcdgWDlIIkZ/A/Dxeuan4suklgscqTRLJBRzczEqlUFjPpcKfHvVxSxE3klI9HYYPlkxeJqUvvNhV5sCQ0MwR+qh1nMsQfK4AuVjeofuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OSZP286MB1941.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:164::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.16; Tue, 12 Sep 2023 08:24:09 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::72d7:4747:7f49:f811]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::72d7:4747:7f49:f811%7]) with mapi id 15.20.6792.015; Tue, 12 Sep 2023 08:24:09 +0000 To: gdb-patches@sourceware.org Cc: enze.li@gmx.com, tdevries@suse.de Subject: [PATCH] gdb: Fix -Wuninitialied issue Date: Tue, 12 Sep 2023 16:22:49 +0800 Message-ID: X-Mailer: git-send-email 2.41.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [o3mnDU+do4zZp+uI/wkShQ0QFuGexVXY] X-ClientProxiedBy: SE2P216CA0050.KORP216.PROD.OUTLOOK.COM (2603:1096:101:115::13) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <20230912082249.96133-1-enze.li@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB2152:EE_|OSZP286MB1941:EE_ X-MS-Office365-Filtering-Correlation-Id: efda96f0-5189-4642-13f0-08dbb369a33a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JrfbUb+REwhvh/xAOZBDGIddKrt+9Fux0ogXf4sh/Rzc0xx7KF/6B3r9xP+CbEHhS8yUc3ruTsMMimcf3pwZkouxjzMq/v110rldbKm31EirsxlEq17RedFteTvSwdiyoZp7oJVDsSI4oBTR/AUT/k0RCkBdJ0Jvzv1rL3Je9ThpkA7fDkBF6ot5GbyZZJzzqGu5sJiCDtzdkquU6y4Rr1AaX+PC8OyTXKohKSkbrikoPoVH+D9DEe/b/omSnWaNluLGkBqXhw9wbhCK6RAYT6gXd+OJReHHSv5sO/+0DwKFdfJyTgvGZZzJWUrBro8RBoiZAqCJUnwO/OjM55/LKLKh9Z2+QXu5qvap8sAKp9aMcB1ryPF6+89/2dnCZ51UHKvpvTUhswB+TUL1ajDkjQbJOXDRKU93ETfur4QzcfA8h1wacjg5Zi6vLS52xWs8bZEakhs2YfgogoZet8Awq9DMIk+NvIv01N48rhXeEgoR2eppgHFcWm/pVxsL8SQUW89Nk70si3eBIHWI8pH6pAAyo0XYHbh1WuTRcp88w7v1oqTkLBUr19KHm28my7J7 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qZ+LnXRBM8TydmkN1xCbewBXZPSqTeiNJRHuf3be2xvRcSB3mX/brCvD7BNb?= =?us-ascii?Q?ILRrmjFHH395k/Fzk1gAX1/j8145fZK2nOntVsWwArL1zxQFvirqAGnFqT60?= =?us-ascii?Q?MvX/VaVGrf4MVraioI5s6Opbc3vTxmX9GIJqgE9mUxM6u/cji63prXN+/JvR?= =?us-ascii?Q?a07uyjVYH8NrsG+8YQyLLLh7EPzkLA5Rr1M1BRKSgYu75hcHjTcoOw5jedop?= =?us-ascii?Q?Vw7kRe/NkxVCh81NuNaZ/vdro36rD7J8trxBm3jMni3oZ6LR2ydjxtGyUyVD?= =?us-ascii?Q?NbAOf8SucHcZfRJ37c7zQDAbCJqeR2S3bX/u59LECwZKVcEZwY9pdxo9hYG2?= =?us-ascii?Q?ngV7Y4jDXLqp6rgZOJ6m2O320DRK8L7pY7d6XzEEJnD6IyJYAzll/YoZ+oG8?= =?us-ascii?Q?WVbCxkwf3jSlAEOLA5s8J/PUna1ODIlkl1q2MwJxjcGhGahJTYJeVHhDee+Q?= =?us-ascii?Q?StPU9PLpeW3P1XjGzfAaY4aEKYaTeUVyCcOvOAApAMUPYWrhOa0fHlbp3/JW?= =?us-ascii?Q?9dhCwqNgs8r3x5gkgI0IGF5EwrGT8fwQLymwKF+Own4olt4ipMcfKVwbvRJC?= =?us-ascii?Q?4mavDCGu/2ih+y3WmhxtqcW/3I+BxKYP9U+83d1CywremhXm57iu8CdjzqIE?= =?us-ascii?Q?40rwTv1+4APh2C3KAyIFf8275POLr1zpAChQCmP4KP0Qm8bfa1epw0o/1BJ9?= =?us-ascii?Q?IikEQPIk9y5AViP2gNOCz5o3h88Xza33OdbngI8EBqCQW1cLaY254iigfCDD?= =?us-ascii?Q?q/wW3PM3d47ndG2X0kMpjyikOigrrFar69iOWdJSiNCano1SBL1HvXsVBTJI?= =?us-ascii?Q?AcPaelNqT9cATQ8HuEMAigG92itT7QcfjOsEA4TBtv8mREU0pUwezpSF7k3C?= =?us-ascii?Q?RMGzC93mKLV9eVwX2cXJ9JaUelNGNPgcGqdVrwvFxeOOUZJeLvdpXBx6FcZk?= =?us-ascii?Q?XOikFWsGnSk7kGYTNoZw3XmaWQCu+XQPttyeZUXX6AmelEX4H1Hdc+/+B1zt?= =?us-ascii?Q?75xEIVngPWOTwh2hl5md695LyjNOKUi3vehdXIIdueutSbBOKwNE9ykXrB9M?= =?us-ascii?Q?eNjjPIU//4z5MzRgtgZv0KVMgiHAU/DXHMdskussU46oxbzDDylCUyN7r96G?= =?us-ascii?Q?+HmY70dScprCeGsxvzZHZ+/BsC3VYZi+IodLGfnZolAbrW+lsGogOKjke9l5?= =?us-ascii?Q?islhRhovKcFoz3I8RoijGfz56CBknp+uhlyQBQ=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: efda96f0-5189-4642-13f0-08dbb369a33a X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 08:24:09.8158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZP286MB1941 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" I see the following warning when building GDB on FreeBSD/amd64 with Clang 14, ====================================================================== CXX mdebugread.o mdebugread.c:1069:3: error: variable 'f' is uninitialized when used here [-Werror,-Wuninitialized] f->set_loc_enumval (tsym.value); ^ mdebugread.c:836:17: note: initialize the variable 'f' to silence this warning struct field *f; ^ = nullptr ====================================================================== after digging a little, I realized that we can not simply do what Clang 14 says. The root cause of this issue is that we lost the initialization of the variable 'f' in this commit, commit 2774f2dad5f05e68771c07df6ab0fb23baa2118e Date: Thu Aug 31 09:37:44 2023 +0200 [gdb/symtab] Factor out type::{alloc_fields,copy_fields} we have made these modifications, ---------------------------------------------------------------------- --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -1034,9 +1034,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend, t->set_code (type_code); t->set_length (sh->value); - t->set_num_fields (nfields); - f = ((struct field *) TYPE_ALLOC (t, nfields * sizeof (struct field))); - t->set_fields (f); + t->alloc_fields (nfields, false); ---------------------------------------------------------------------- The problem is that the variable 'f' is used in the second half of parse_symbol, that's why Clang complained. To fix this issue we need to ensure that the varibale 'f' is initialized. Calling the fields method is an obvious way to fix this issue. Tested on FreeBSD/amd64 by rebuilding. --- gdb/mdebugread.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index ea3e15be53b2..9cb30ce0acd0 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -1035,6 +1035,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, char *ext_sh, int bigend, t->set_code (type_code); t->set_length (sh->value); t->alloc_fields (nfields); + f = t->fields(); if (type_code == TYPE_CODE_ENUM) { base-commit: 318d3bda5cad124bd11eebb0349d0f183ba625b1 -- 2.41.0