From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 58hOH/cK8WJJwyIAWB0awg (envelope-from ) for ; Mon, 08 Aug 2022 09:09:11 -0400 Received: by simark.ca (Postfix, from userid 112) id 73A6C1EA06; Mon, 8 Aug 2022 09:09:11 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sSn3B2E4; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 55D501E9EB for ; Mon, 8 Aug 2022 09:09:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEEB9385736E for ; Mon, 8 Aug 2022 13:09:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEEB9385736E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659964150; bh=6TEf4mtzwjR8OBnB5LDT0DQ/qtN5YeO4Vstt5Z81aGs=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sSn3B2E4mXx1njonfdVzg500KtO9SIFOw/twt809uMl8otwemEeCyjZV0LaqiIjpX yJ69wumETlFi/YOeqJnnXn7UAnUBJaFsTgCvNcoXlRtH1Gb1G4XDm9xCfdEIYFtcuR oSChoCHQYwlUnKcD27IC7w4CuDs7WEA723Ka/w/k= Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2055.outbound.protection.outlook.com [40.92.99.55]) by sourceware.org (Postfix) with ESMTPS id 8EE1638582BF for ; Mon, 8 Aug 2022 13:08:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EE1638582BF ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZTwnxmOWqzV8qBcdufPy3OF7WortDMwbpvDrvtboEYJM7cqJAL7Clt0ox9haop8672CCjI9IQuBPNseAgv+B1OD/m01gwosaYRT1veeU5WYqGCbff8v6FAkLDtR9NtvrnJb8drLa9zx3J/yZDPlse+m/L624j0TJyCLX8p6ddVfVq2tf+aVODiOyBlRcmXHfZx9GawU1zS8Ps/ssNU1uwxbZe/mp3USbtq4oHH16mIIdDWFMvhm9ZNvImT1ZFjOwxGHOXD6lMl+sVDyI9TA9esAsw/mnjXVpo4znvWFd6xLyk3m7k1UUZ/82waDLvxrMJTyYK2cPwZLgHSMGuZG9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6TEf4mtzwjR8OBnB5LDT0DQ/qtN5YeO4Vstt5Z81aGs=; b=MB+m8ZIzLt2f+L+vIJCo3XDTvrP59xt22Tu5xJn100KBgekvthGD3TTF4tSiZ1rs+kh0Fpnnwg5X9LdB0nx4HoNcjXdjIBmvb+UcJuwhj7Otn1lVJUQIiSSOfYasiXtlKKXqSPAL2JUkbQR8A7w+W8h09htsHiO+SYDOdS80GvzvqxV2R1kyJlNaSLnWiq4s4uMGMvnJlRmpjufn2LBTpxEvfBc57/PlnfdO+/nxeCpxtoROvF/RYUX51ktJGTpCyfxTfIQw3lT8kaveQ/jtRLzUGXqg+4XdE4vQqML9yHit7uIxpiplt/vcdDlRJoT3tnV1Lm+k/DfgQTH+VgPtTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by OSZP286MB1062.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:fb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Mon, 8 Aug 2022 13:08:47 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022 13:08:47 +0000 Message-ID: Subject: Re: [PATCH] gdb: add constructor to gdb_user_regs To: Tom de Vries , gdb-patches@sourceware.org Date: Mon, 08 Aug 2022 21:08:42 +0800 In-Reply-To: <7fc69637-ecd5-01e5-0db1-32fb2117322f@suse.de> References: <7fc69637-ecd5-01e5-0db1-32fb2117322f@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 X-TMN: [+c/NmlUbIvexrQNNEt69TI1KDEY+MWDP] X-ClientProxiedBy: SG2PR02CA0031.apcprd02.prod.outlook.com (2603:1096:3:18::19) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <08d6d5b3f0188edf5d3c39c6c25f8b99f907d361.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f87af10f-bf87-4e56-5d5c-08da793f211d X-MS-TrafficTypeDiagnostic: OSZP286MB1062:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fuLSanty5J/SCxCA2Y9DSJwTmQEHvT/ohUX1swNQ7T5Vp6hLywN41+Nxk0r/y2G660LSTR7IZAuKZvdb2xnD7SMwrUeU9+Bbgycq7KD4Q8WzCiRsoPQuv8ilnJ/v7mMWqljQ9uQVGJiclV67Omw9Dh2h2f2lSzabpvbroBfZg2SQYmvZQ/Fw+eUv2E8Hq2lrGwmEpSbO32t5as4wEp3RYNVF3OGQA4zHxEGgrHaxczr5CO5WB2AnWZ8dS46PUXNeoxtuN5zPhSzlvUC2TQTQyPoxJAQDbyhTvZ6NgTKzki0Qe7cxQ/NG9aTRdvyqsWpj7kv6t26sSDsKpprMoxyg5jWlnDa2haulak1AUQ+mxk8DAGwg6Rg2hANQFOo7SCmEjn2Vb317Y1JDyTvSX2GncXQQAatmE80hIcaoQqf/eNJ0YagYKU/1dHFgLg0NTaZxtOr5V3ScNSXcJ0sRlN9Mr348ViOHSYFlAUcsl6OsXbamZTBMb47+qxBbul0fS4tIv3PhOlhtOFnnEnY4aMgXhohwfn7OQg2J+sHQfR/lmcHxUfPp5HPUiaXKBUAwdWmht2x8qmzvX+dx2wyVohl/B8ACJ5QHI1GqC0fhqfiLoCA7A23V5OTQ4rwuBRRnB+VqUmGP1UgfzAqq4n5CIQOWlk69O94MKiwJ2VT9k+VB3svlnhcxxfqR9FFWCCQRfWy9 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWt1aDJUMklPeHM3MS9wQ1JwZVBVZDh3T3cwSWs4MzNWTTB1M1hmbnovaWRj?= =?utf-8?B?dkhCOXZLTXNIalROUllKVjZhYmV5N3VaeWlWclBBM2tuOUd1bmlxcVBSY0pK?= =?utf-8?B?cnBLY3ovVmYvd0drQTNPNEY3R01rZ2VDelBsbVFKWTdYOSt2ZXZXWC8vaFFB?= =?utf-8?B?OEpNajA0MUZ0ckVKUXcwNWFEa2daVTV3S0FXY2ZBbGtoMzQ4RlIrREUvdFBY?= =?utf-8?B?Q3ZBYkJFdGtKVDcyc0Y5bFJpSURtcTNXUGdTZU5IRmR5a21tNEdqVlFwek1m?= =?utf-8?B?cnhxM2dMTVorWWVYR3hhYTZKRDd6Y3lMcmtHUHpXSGhid2NuMVRYa29iZHMz?= =?utf-8?B?NkRycTlLRFVXdDBwTFJWOEUza1lnckMxdndGTjZkbXE5LzJaYkduN2xNZ21X?= =?utf-8?B?SUprbnBzNUlEUnl0c1NnTkxsVXpVLy9vVWt1OTdqT05mWFk4U0ZsMU5wUUx1?= =?utf-8?B?MUk5UVFSRTh6ZzM4cTdlNS9abG1ibzdxVnhKZmxobmlPWjNRdDlYTTlCUkp0?= =?utf-8?B?VlZCdy96dHpScmJyMXlsTkQwemdCTDl6WkJSVVFkL2M1SDVydkRBVHgzcVRn?= =?utf-8?B?b3plOWNqZ0ppT2NRVVBaQkRhN2VmeGxNTjdZaTF5Z2o4VzhkZ1F6U2YyRUpw?= =?utf-8?B?aVZNeE1VU2pwaS9tMitvUFErNW5nMmVSK212c045SFJ1bkJQdXRSd05wYVNz?= =?utf-8?B?UmFqMFRTVVdyelc2ZnlJTWY1TkNaREk3bUJ4OGNqT0lXTEczeThDVDREYWRH?= =?utf-8?B?MHNWVm80dHI4L2FhZ0FUUzc1YUVlbVRyb2UvOG9wUHRISzV6Ull6QmxmY01r?= =?utf-8?B?REwxZ0x5MVlEc2Fyd2lwcFhHNzhHRDRmT1VsVFBsaGlvOVBoYU55YUFiUUtw?= =?utf-8?B?YlFGendzK3kzbXl4MzVWUmZLTG9tUTU2ZWQwWEJFRU9KOGNoNE5Zd09hVWE5?= =?utf-8?B?VWxWbUtmSU92dFhLdDRNVnRGWG1Pcy9idUJrVkVqbkQ4NUduSUFWSVBZVEJX?= =?utf-8?B?Tk12WEhRcE9JS3dYNXdsSVRxZTErNUNsMEh2Qm9aY1Q5Y2dlemdtM0hMVS9z?= =?utf-8?B?T3FSR2RBZ0FYL2xvclJ3Mm10UW1sZEI0NjJJUVk0SDhQVDBkYzUxaHp2MU5z?= =?utf-8?B?WFJDOXF6NXo2NkpHZWErUnBta2RTU1ZTb3dvaCtZRXR0SU5GaDZaTXlHVGNx?= =?utf-8?B?RWZDRENWNVhoOEgvL0NIb3VheWp6RGtEMnpGaGwyVHZxaWkyMHB1WHhpSy9B?= =?utf-8?B?UDB4b0hVakdSWk9FWnpJaXpmdmkyWkxjODR3Y0xuajZwcnVmWGhWTkNLRTBQ?= =?utf-8?B?M2hUVkJNbzNDdmNpWHhaYko3bUhCNW0xMm1FWTg4TU5wRDVWSjVoelVPNjM1?= =?utf-8?B?eG1tbHl5N0dSeU85WURnbndhdmNUbm9IMEhqdWIzOUM4RlRwQXJWZERZTkdt?= =?utf-8?B?bWZXZjZ0dnJMN3BqSXg1bmFNd2RBK1pmamQ5N1E4emNtUmh1UVJMeXMrb0Vq?= =?utf-8?B?NTNObm1EckI1d2lBcTJiWU5zYWtKa2lpMW9mK3hBVkl2UFpqWlg3Zm84MDJX?= =?utf-8?B?R1VRKy9mZjBhS1BqZFFlRjNyTEl1NUVlaTNpb1h5Qkh5YXdDa1duRDhhQTFn?= =?utf-8?B?NG1yTFFqcW9qWWptZE5nRXdFRVZmeG1xZ0t0QXQreldrU1FBZ3VJWjg1RTBy?= =?utf-8?B?dGdLM0tjQVY3dlRQdVZaRWswUDMxMUFwN2NtSVd3Tk9oZndSc1dOTk5BPT0=?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f87af10f-bf87-4e56-5d5c-08da793f211d X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 13:08:47.5412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZP286MB1062 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Cc: enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Tom, On Mon, 2022-08-08 at 10:03 +0200, Tom de Vries wrote: > > On 8/6/22 07:14, Enze Li via Gdb-patches wrote: > > > > When building gdb with clang 14 and -std=3Dgnu++11, I ran into: > > > >=20 > > > > =C2=A0=C2=A0=C2=A0CXX=C2=A0=C2=A0=C2=A0=C2=A0user-regs.o > > > > user-regs.c:83:29: error: no matching constructor for> > > > initialization of 'struct gdb_user_regs' > > > > static struct gdb_user_regs builtin_user_regs =3D { > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0^=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= ~ > > > > user-regs.c:58:8: note: candidate constructor (the implicit > > > > copy> > > > constructor) not viable: requires 1 argument, but 2 were provided > > > > struct gdb_user_regs > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0^ > > > > user-regs.c:58:8: note: candidate constructor (the implicit > > > > move> > > > constructor) not viable: requires 1 argument, but 2 were provided > > > > user-regs.c:58:8: note: candidate constructor (the implicit > > default> > constructor) not viable: requires 0 arguments, but 2 > > were > > provided > > > > 1 error generated. > > > >=20 > > > > The fundamental reason is that C++11 does not support this> > > > approach. > > > > This patch adds a constructor to gdb_user_regs to avoid the > > > > build > > > > failure. > > > >=20 > >=20 > > Hi, > >=20 > > I ran into a similar problem with gcc 4.8 (I noticed a build > > failure=C2=A0 > > with centos @ builder.sourceware.org) and fixed it here (=C2=A0 > > https://sourceware.org/git/?p=3Dbinutils- > gdb.git;a=3Dcommit;h=3D411c7e044fa99089d3030f2c61525c4d415f7b45=C2=A0 > > ). > >=20 > > My apologies that I didn't notice your patch. It's okay, mine is just a proposed one. =C2=A0 > >=20 > > Anyway, I hope that this fixes the problem for you as well.=C2=A0=C2=A0= I've=C2=A0 > > managed to do a build using clang-13.0.0 (with --disable-werror) > > up> > to=C2=A0 > > the point of an AFAICT unrelated linker failure. > >=20 > > Thanks, > > - Tom With your patch applied, I have tested with clang 13, 14 and 15, and they all built successfully. Thanks for doing this. Thanks, Enze > >=20 > > > > Tested by rebuilding on x86_64-linux with clang 14 and gcc 12, > > with> > and > > > > without -std=3Dgnu++11. > > > > --- > > > > =C2=A0 gdb/user-regs.c | 12 ++++++++++-- > > > > =C2=A0 1 file changed, 10 insertions(+), 2 deletions(-) > > > >=20 > > > > diff --git a/gdb/user-regs.c b/gdb/user-regs.c > > > > index 4bc4685387f..a2012b84534 100644 > > > > --- a/gdb/user-regs.c > > > > +++ b/gdb/user-regs.c > > > > @@ -57,8 +57,16 @@ struct user_reg > > > > =C2=A0=C2=A0 > > > > =C2=A0 struct gdb_user_regs > > > > =C2=A0 { > > > > -=C2=A0=C2=A0struct user_reg *first =3D nullptr; > > > > -=C2=A0=C2=A0struct user_reg **last =3D nullptr; > > > > +=C2=A0=C2=A0gdb_user_regs (struct user_reg *mfirst, struct user_re= g > > > > **mlast) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0: first (mfirst), > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0last (mlast) > > > > +=C2=A0=C2=A0{ > > > > +=C2=A0=C2=A0} > > > > + > > > > +=C2=A0=C2=A0gdb_user_regs () =3D default; > > > > + > > > > +=C2=A0=C2=A0struct user_reg *first; > > > > +=C2=A0=C2=A0struct user_reg **last; > > > > =C2=A0 }; > > > > =C2=A0=C2=A0 > > > > =C2=A0 static void